From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28060C83F12 for ; Mon, 28 Aug 2023 18:58:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233309AbjH1S5m (ORCPT ); Mon, 28 Aug 2023 14:57:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233271AbjH1S50 (ORCPT ); Mon, 28 Aug 2023 14:57:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA74CEB for ; Mon, 28 Aug 2023 11:57:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 56C0463D3D for ; Mon, 28 Aug 2023 18:57:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42181C433C7; Mon, 28 Aug 2023 18:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693249041; bh=lHQWUIGPBs3/A8CdAI4l/jbbdBYxLqQ8A2lhdNBEVfE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZCadsNZxlGDGpGa6XJH546B0ODhgLEfTmy08o6mWMCPnNV7mIwGmC7jBOH/Gozu11 +dST19qPTlm7TN4twVIHgnDSyHUFnV722IjFxBb/FAm3uORnEMOsizquhX2i80I3YU 6oCv3TqW/pSTFh/z97eGbTlCVhFNsg/+LYIqkmam8V1nZVCKI5Ke1uHS7fk9//r1av JS6l9w41IXoLweaA81JP/FIex0jaFkoRjfHB3P1jL5Wwjs17dJfEd8LsVstdO5CyTm yFQOanVjMD3cjNNfHrpHAe9wR4YlLFDoQcWxkxPK5DB6vfXTneXnmzmcg3f6L9KWIZ umuldV564dHDA== Message-ID: Date: Mon, 28 Aug 2023 12:57:20 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH net v3 3/3] selftests: fib_tests: Add multipath list receive tests Content-Language: en-US To: Ido Schimmel , Sriram Yagnaraman , kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, "David S . Miller" , Eric Dumazet , Ido Schimmel , Shuah Khan , Petr Machata References: <20230828113221.20123-1-sriram.yagnaraman@est.tech> <20230828113221.20123-4-sriram.yagnaraman@est.tech> From: David Ahern In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 8/28/23 9:24 AM, Ido Schimmel wrote: > On Mon, Aug 28, 2023 at 01:32:21PM +0200, Sriram Yagnaraman wrote: >> The test uses perf stat to count the number of fib:fib_table_lookup >> tracepoint hits for IPv4 and the number of fib6:fib6_table_lookup for >> IPv6. The measured count is checked to be within 5% of the total number >> of packets sent via veth1. >> >> Signed-off-by: Sriram Yagnaraman > > I just tested this with a debug config and noticed that the single path > test is not very stable. It's not really related to the bug fix, so I > think you can simply remove it. > > Jakub / Paolo, this change conflicts with changes in net-next and I > assume that the next PR that you are going to send is from net-next. > What is your preference in this case? Wait for the PR to be accepted and > for master to be merged into net? > > Thanks Ido, thanks for staying on top of this change and the details with the test cases.