From: Cosmin Ratiu <cratiu@nvidia.com>
To: "razor@blackwall.org" <razor@blackwall.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "anthony.l.nguyen@intel.com" <anthony.l.nguyen@intel.com>,
"bbhushan2@marvell.com" <bbhushan2@marvell.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"hkelam@marvell.com" <hkelam@marvell.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"jv@jvosburgh.net" <jv@jvosburgh.net>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"liuhangbin@gmail.com" <liuhangbin@gmail.com>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
Leon Romanovsky <leonro@nvidia.com>,
"ayush.sawal@chelsio.com" <ayush.sawal@chelsio.com>,
Jianbo Liu <jianbol@nvidia.com>,
"sbhatta@marvell.com" <sbhatta@marvell.com>,
"horms@kernel.org" <horms@kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>,
"przemyslaw.kitszel@intel.com" <przemyslaw.kitszel@intel.com>,
"steffen.klassert@secunet.com" <steffen.klassert@secunet.com>,
"gakula@marvell.com" <gakula@marvell.com>,
"sgoutham@marvell.com" <sgoutham@marvell.com>,
"louis.peens@corigine.com" <louis.peens@corigine.com>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH net-next v2 0/6] xfrm & bonding: Correct use of xso.real_dev
Date: Fri, 11 Apr 2025 07:46:15 +0000 [thread overview]
Message-ID: <a4b514e8a5bcbbe5dc1e6b6c9076b7a7afa57b45.camel@nvidia.com> (raw)
In-Reply-To: <a7989f85-7699-4b90-9328-9480297a1765@blackwall.org>
On Thu, 2025-04-10 at 14:10 +0300, Nikolay Aleksandrov wrote:
>
> Thank you for following up on this. It's definitely not getting
> cleaner with a bond
> ptr in xfrm protected by two locks in different drivers, but it
> should do AFAICT.
> In case there is another version I'd add a big comment of the locking
> expectations
> for real_dev, and maybe in the future it can fully move to the
> bonding as well.
>
> For the set:
> Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
Thanks for the review, I'll send v3 with the comment added.
I would have liked to push this a bit further with making real_dev
private, but I didn't find a way and that can be done separately.
Cosmin.
prev parent reply other threads:[~2025-04-11 7:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 14:41 [PATCH net-next v2 0/6] xfrm & bonding: Correct use of xso.real_dev Cosmin Ratiu
2025-04-09 14:41 ` [PATCH net-next v2 1/6] net/mlx5: Avoid using xso.real_dev unnecessarily Cosmin Ratiu
2025-04-09 14:41 ` [PATCH net-next v2 2/6] xfrm: Use xdo.dev instead of xdo.real_dev Cosmin Ratiu
2025-04-09 14:41 ` [PATCH net-next v2 3/6] xfrm: Remove unneeded device check from validate_xmit_xfrm Cosmin Ratiu
2025-04-09 14:41 ` [PATCH net-next v2 4/6] xfrm: Add explicit dev to .xdo_dev_state_{add,delete,free} Cosmin Ratiu
2025-04-09 14:41 ` [PATCH net-next v2 5/6] bonding: Mark active offloaded xfrm_states Cosmin Ratiu
2025-04-10 2:54 ` Hangbin Liu
2025-04-09 14:41 ` [PATCH net-next v2 6/6] bonding: Fix multiple long standing offload races Cosmin Ratiu
2025-04-10 3:07 ` Hangbin Liu
2025-04-11 7:06 ` Cosmin Ratiu
2025-04-10 11:10 ` [PATCH net-next v2 0/6] xfrm & bonding: Correct use of xso.real_dev Nikolay Aleksandrov
2025-04-11 7:46 ` Cosmin Ratiu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4b514e8a5bcbbe5dc1e6b6c9076b7a7afa57b45.camel@nvidia.com \
--to=cratiu@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=ayush.sawal@chelsio.com \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=herbert@gondor.apana.org.au \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=jianbol@nvidia.com \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=razor@blackwall.org \
--cc=saeedm@nvidia.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=steffen.klassert@secunet.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox