From: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
To: Jeffle Xu <jefflexu@linux.alibaba.com>, shuah@kernel.org
Cc: linux-kselftest@vger.kernel.org, James Wang <jnwang@linux.alibaba.com>
Subject: Re: [PATCH v3] selftests/mincore: get readahead size for check_file_mmap()
Date: Mon, 12 Apr 2021 09:15:41 +0200 [thread overview]
Message-ID: <a582e59cdca782125929a88318eeebd24c7fda8f.camel@collabora.com> (raw)
In-Reply-To: <20210412034622.59737-1-jefflexu@linux.alibaba.com>
Hi Jeffle,
Thanks for the patch.
On Mon, 2021-04-12 at 11:46 +0800, Jeffle Xu wrote:
> - i = FILE_SIZE / 2 / page_size + 1;
> + i = file_size / 2 / page_size + 1;
> while (i < vec_size && vec[i]) {
> ra_pages++;
> i++;
One minor nit: now that you know the readahead size exactly, this could check
that only the readahead window has been loaded and that anything beyond that is
still not populated.
Acked-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
next prev parent reply other threads:[~2021-04-12 7:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 6:38 [PATCH v2] selftests/mincore: get readahead size for check_file_mmap() Jeffle Xu
2021-04-12 3:10 ` JeffleXu
2021-04-12 3:46 ` [PATCH v3] " Jeffle Xu
2021-04-12 7:15 ` Ricardo Cañuelo [this message]
2021-04-14 9:17 ` JeffleXu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a582e59cdca782125929a88318eeebd24c7fda8f.camel@collabora.com \
--to=ricardo.canuelo@collabora.com \
--cc=jefflexu@linux.alibaba.com \
--cc=jnwang@linux.alibaba.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox