Re: [PATCH v2 19/53] selftests/mm: va_high_addr_switch: use kselftest framework

Mike Rapoport
2026-04-21T08:33:46Z

On Mon, Apr 20, 2026 at 07:11:30PM +0100, Mark Brown wrote:
> On Sat, Apr 18, 2026 at 01:55:04PM +0300, Mike Rapoport wrote:
>
> > if (p == MAP_FAILED) {
> > - printf("FAILED\n");
> > - ret = KSFT_FAIL;
> > + ksft_test_result_fail("%s: MAP_FAILED\n", t->msg);
> > continue;
> > }
> >
> > if (t->low_addr_required && p >= (void *)(switch_hint)) {
> > - printf("FAILED\n");
> > - ret = KSFT_FAIL;
> > + ksft_test_result_fail("%s: %p not below switch hint\n", t->msg, p);
>
> The test result reports should use a consistent name for each test and
> log any diagnostic information about the source of failure in separate
> prints.

Ok, will fix.

--
Sincerely yours,
Mike.