From: Bastien Curutchet <bastien.curutchet@bootlin.com>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: "Björn Töpel" <bjorn@kernel.org>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Song Liu" <song@kernel.org>,
"Yonghong Song" <yonghong.song@linux.dev>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
"Mykola Lysenko" <mykolal@fb.com>,
"Shuah Khan" <shuah@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Alexis Lothore" <alexis.lothore@bootlin.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/13] selftests/bpf: Integrate test_xsk.c to test_progs framework
Date: Fri, 14 Mar 2025 17:08:31 +0100 [thread overview]
Message-ID: <a8c7e353-2e5f-4cdc-99fb-0937b8121b38@bootlin.com> (raw)
In-Reply-To: <Z9RPNzJtBgheiTeS@boxer>
Hi Maciej
On 3/14/25 4:45 PM, Maciej Fijalkowski wrote:
> On Thu, Mar 13, 2025 at 11:47:58AM +0100, Bastien Curutchet (eBPF Foundation) wrote:
>> Hi all,
>>
>> This patch series continues the work to migrate the script tests into
>> prog_tests.
>
> Hi Bastien,
>
> the sole purpose of this is a cleanup of some sort?
>
The goal is to have more tests run by the CI and fewer standalone
scripts so that regressions are spotted more efficiently.
>>
>> The test_xsk.sh script tests lots of AF_XDP use cases. The tests it uses
>> are defined in xksxceiver.c. As this script is used to test real
>> hardware, the goal here is to keep it as is and only integrate the
>> tests on veth peers into the test_progs framework.
>
> We're doubling the functionality for no additional benefits? Or the
> benefit of this set would be the veth xsk tests execution within BPF CI?
>
Yes the benefit would be the tests execution within BPF CI.
>> Three tests are flaky on s390 so they won't be integrated to test_progs
>> yet (I'm currently trying to make them more robust).
>>
>> PATCH 1 & 2 fix some small issues xskxceiver.c
>> PATCH 3 to 9 rework the xskxceiver to ease the integration in the
>> test_progs framework. Two main points are addressed in them :
>> - wrap kselftest calls behind macros to ease their replacement later
>> - handle all errors to release resources instead of calling exit() when
>> any error occurs.
>> PATCH 10 extracts test_xsk[.c/.h] from xskxceiver[.c/.h] to make the
>> tests available to test_progs
>> PATCH 11 enables kselftest de-activation
>> PATCH 12 isolates the flaky tests
>> PATCH 13 integrate the non-flaky tests to the test_progs framework
>
> I didn't bisect but this set breaks the HW tests for me which *is* what we
> care about. I'll dig onto that on monday and will get back to you.
>
Ok, thank you. Can you tell me what hardware you use please ? If by any
chance I have the same HW somewhere in my office, I can try to reproduce
on my side.
Best regards,
Bastien
prev parent reply other threads:[~2025-03-14 16:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 10:47 [PATCH 00/13] selftests/bpf: Integrate test_xsk.c to test_progs framework Bastien Curutchet (eBPF Foundation)
2025-03-13 10:47 ` [PATCH 01/13] selftests/bpf: test_xsk: Initialize bitmap before use Bastien Curutchet (eBPF Foundation)
2025-03-13 10:48 ` [PATCH 02/13] selftests/bpf: test_xsk: Fix memory leaks Bastien Curutchet (eBPF Foundation)
2025-03-13 10:48 ` [PATCH 03/13] selftests/bpf: test_xsk: Wrap ksft_*() behind macros Bastien Curutchet (eBPF Foundation)
2025-03-13 10:48 ` [PATCH 04/13] selftests/bpf: test_xsk: Add return value to init_iface() Bastien Curutchet (eBPF Foundation)
2025-03-13 10:48 ` [PATCH 05/13] selftests/bpf: test_xsk: Don't exit immediately when xsk_attach fails Bastien Curutchet (eBPF Foundation)
2025-03-13 10:48 ` [PATCH 06/13] selftests/bpf: test_xsk: Don't exit immediately when gettimeofday fails Bastien Curutchet (eBPF Foundation)
2025-03-13 10:48 ` [PATCH 07/13] selftests/bpf: test_xsk: Don't exit immediately when workers fail Bastien Curutchet (eBPF Foundation)
2025-03-13 10:48 ` [PATCH 08/13] selftests/bpf: test_xsk: Don't exit immediately if validate_traffic fails Bastien Curutchet (eBPF Foundation)
2025-03-13 10:48 ` [PATCH 09/13] selftests/bpf: test_xsk: Don't exit immediately on allocation failures Bastien Curutchet (eBPF Foundation)
2025-03-13 10:48 ` [PATCH 10/13] selftests/bpf: test_xsk: Split xskxceiver Bastien Curutchet (eBPF Foundation)
2025-03-18 13:16 ` Maciej Fijalkowski
2025-03-18 15:10 ` Bastien Curutchet
2025-03-13 10:48 ` [PATCH 11/13] selftests/bpf: test_xsk: Make kselftest dependency optional Bastien Curutchet (eBPF Foundation)
2025-03-13 10:48 ` [PATCH 12/13] selftests/bpf: test_xsk: Isolate flaky tests Bastien Curutchet (eBPF Foundation)
2025-03-13 10:48 ` [PATCH 13/13] selftests/bpf: test_xsk: Integrate test_xsk.c to test_progs framework Bastien Curutchet (eBPF Foundation)
2025-03-13 10:50 ` [PATCH 00/13] selftests/bpf: " Bastien Curutchet
2025-03-14 15:45 ` Maciej Fijalkowski
2025-03-14 16:08 ` Bastien Curutchet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8c7e353-2e5f-4cdc-99fb-0937b8121b38@bootlin.com \
--to=bastien.curutchet@bootlin.com \
--cc=alexis.lothore@bootlin.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=jonathan.lemon@gmail.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).