From: Reinette Chatre <reinette.chatre@intel.com>
To: "Chen, Zide" <zide.chen@intel.com>, <shuah@kernel.org>,
<Dave.Martin@arm.com>, <james.morse@arm.com>,
<tony.luck@intel.com>, <peternewman@google.com>,
<babu.moger@amd.com>, <ilpo.jarvinen@linux.intel.com>
Cc: <dapeng1.mi@linux.intel.com>, <fenghuay@nvidia.com>,
<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<patches@lists.linux.dev>
Subject: Re: [PATCH 2/8] selftests/resctrl: Prepare for parsing multiple events per iMC
Date: Wed, 11 Feb 2026 19:52:36 -0800 [thread overview]
Message-ID: <a9e625c5-880d-4d0e-95b9-85c7616b8f43@intel.com> (raw)
In-Reply-To: <ae46c7fb-dbc4-4f62-89b9-0cb003e65547@intel.com>
Hi Zide,
On 2/11/26 3:37 PM, Chen, Zide wrote:
> On 2/10/2026 8:50 AM, Reinette Chatre wrote:
>> The events needed to read memory bandwidth are discovered by iterating
>> over every memory controller (iMC) within /sys/bus/event_source/devices.
>> Each iMC's PMU is assumed to have one event to measure read memory
>> bandwidth that is represented by the sysfs cas_count_read file. The event's
>> configuration is read from "cas_count_read" and stored as an element of
>> imc_counters_config[] by read_from_imc_dir() that receives the
>> index of the array where to store the configuration as argument.
>>
>> It is possible that an iMC's PMU may have more than one event that should
>> be used to measure memory bandwidth.
>>
>> Change semantics to not provide the index of the array to
>> read_from_imc_dir() but instead a pointer to the index. This enables
>> read_from_imc_dir() to store configurations for more than one event by
>> incrementing the index to imc_counters_config[] itself.
>>
>> Ensure that the same type is consistently used for the index as it is
>> passed around during counter configuration.
>>
>> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
>
> Reviewed-by: Zide Chen <zide.chen@intel.com>
Thank you very much.
Reinette
next prev parent reply other threads:[~2026-02-12 3:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 16:50 [PATCH 0/8] selftests/resctrl: Fixes and improvements focused on recent Intel platforms Reinette Chatre
2026-02-10 16:50 ` [PATCH 1/8] selftests/resctrl: Do not store iMC counter value in counter config structure Reinette Chatre
2026-02-10 16:50 ` [PATCH 2/8] selftests/resctrl: Prepare for parsing multiple events per iMC Reinette Chatre
2026-02-11 23:37 ` Chen, Zide
2026-02-12 3:52 ` Reinette Chatre [this message]
2026-02-10 16:50 ` [PATCH 3/8] selftests/resctrl: Support multiple events associated with iMC Reinette Chatre
2026-02-11 23:37 ` Chen, Zide
2026-02-12 3:54 ` Reinette Chatre
2026-02-10 16:50 ` [PATCH 4/8] selftests/resctrl: Increase size of buffer used in MBM and MBA tests Reinette Chatre
2026-02-10 16:50 ` [PATCH 5/8] selftests/resctrl: Raise threshold at which MBM and PMU values are compared Reinette Chatre
2026-02-10 16:50 ` [PATCH 6/8] selftests/resctrl: Remove requirement on cache miss rate Reinette Chatre
2026-02-10 16:50 ` [PATCH 7/8] selftests/resctrl: Simplify perf usage in CAT test Reinette Chatre
2026-02-10 16:50 ` [PATCH 8/8] selftests/resctrl: Reduce L2 impact on " Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9e625c5-880d-4d0e-95b9-85c7616b8f43@intel.com \
--to=reinette.chatre@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=fenghuay@nvidia.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=peternewman@google.com \
--cc=shuah@kernel.org \
--cc=tony.luck@intel.com \
--cc=zide.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox