From: Jiri Olsa <olsajiri@gmail.com>
To: KaFai Wan <mannkafai@gmail.com>
Cc: martin.lau@linux.dev, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, eddyz87@gmail.com, song@kernel.org,
yonghong.song@linux.dev, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, mykolal@fb.com,
shuah@kernel.org, memxor@gmail.com, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kafai.wan@hotmail.com, leon.hwang@linux.dev
Subject: Re: [PATCH bpf-next v3 0/2] bpf: Allow access to const void pointer arguments in tracing programs
Date: Tue, 22 Apr 2025 12:08:34 +0200 [thread overview]
Message-ID: <aAdqorjuW68ld6ps@krava> (raw)
In-Reply-To: <20250417151548.1276279-1-kafai.wan@hotmail.com>
On Thu, Apr 17, 2025 at 11:15:46PM +0800, KaFai Wan wrote:
> If we try to access argument which is pointer to const void, it's an
> UNKNOWN type, verifier will fail to load.
>
> Use is_void_or_int_ptr to check if type is void or int pointer.
> Add a selftest to check it.
>
> ---
> KaFai Wan (2):
> bpf: Allow access to const void pointer arguments in tracing programs
> selftests/bpf: Add test to access const void pointer argument in
> tracing program
>
> kernel/bpf/btf.c | 13 +++----------
> net/bpf/test_run.c | 8 +++++++-
> .../selftests/bpf/progs/verifier_btf_ctx_access.c | 12 ++++++++++++
> 3 files changed, 22 insertions(+), 11 deletions(-)
>
> Changelog:
> v2->v3: Addressed comments from jirka
> - remove duplicate checks for void pointer
> Details in here:
> https://lore.kernel.org/bpf/20250416161756.1079178-1-kafai.wan@hotmail.com/
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
>
> v1->v2: Addressed comments from jirka
> - use btf_type_is_void to check if type is void
> - merge is_void_ptr and is_int_ptr to is_void_or_int_ptr
> - fix selftests
> Details in here:
> https://lore.kernel.org/all/20250412170626.3638516-1-kafai.wan@hotmail.com/
>
> --
> 2.43.0
>
prev parent reply other threads:[~2025-04-22 10:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 15:15 [PATCH bpf-next v3 0/2] bpf: Allow access to const void pointer arguments in tracing programs KaFai Wan
2025-04-17 15:15 ` [PATCH bpf-next v3 1/2] " KaFai Wan
2025-04-22 20:03 ` Alexei Starovoitov
2025-04-17 15:15 ` [PATCH bpf-next v3 2/2] selftests/bpf: Add test to access const void pointer argument in tracing program KaFai Wan
2025-04-22 10:08 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAdqorjuW68ld6ps@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai.wan@hotmail.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=leon.hwang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mannkafai@gmail.com \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=mykolal@fb.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox