From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42B09380 for ; Thu, 24 Apr 2025 00:06:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745453170; cv=none; b=DVFjVUVw9mKIEcogdqi/38VFB6muh2PcL2QGgNJHcdVjJgG9CygFGhqM5GMxcUio2upTHsveOu++kXi7r7isKb72Y3G8hWZEHcFrW7Bxsi8wvPVwwa53uDSxTrbEt4y1fzTGRj/iW257vj31L3FBO7SXFWxDgDk0XwVhzBzjvp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745453170; c=relaxed/simple; bh=mVT9IY0iZtItMWBqylUMmJqk8EaUvrBNBHLL55g1PgA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aC/Q7H8koNDCu0rmQpqjg7wj7rsbFYL3poa4NKK7W115fiPAWIQCo79jE5Lg5LxOSUUQEeD2Yw2Yoisferfl1rLDKQ8uX1KqxrMBnMG3u5HaktMqkVIVSQyqCoYsFro/7/nmc4LfIYOqwyWr4jCgwBv1fW7ZaEOSXAyDhl1qGFA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=Csvn8Oix; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="Csvn8Oix" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2264aefc45dso6321915ad.0 for ; Wed, 23 Apr 2025 17:06:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1745453168; x=1746057968; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=A13DmWW4IFyC+2QEpgeShC0monFDWua+5RM+sHVw7DQ=; b=Csvn8Oix9SuglDdRamLqqkrPAT+UpkUjKCnbm69tqfbx7QwYZzm9w8ZUH2Wm2lWWrb orCaK6Jwi0OIr9NZ/JuPflnM+NsYryiEGrPp8/d3qe801VRlMIZr861Pt3uRsNJBd+RX UprO46LrB3CFIrao2EaZrKqJNOSTntikxpZUs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745453168; x=1746057968; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A13DmWW4IFyC+2QEpgeShC0monFDWua+5RM+sHVw7DQ=; b=czQFjIvoNn0JVcx7puebOEs5vfhNH9knXdVMG01yrXKzKvwLkEVpaphsL91TMyiKPK QGl4dYzVdzGMUMxI2nR61jOfPix0FYX8RRKYHJ2IAbx62/rNbMbBiWOHlPPfT5oTHSeF WrMPpX/a48+pAvmbThcgvUZR+C9hX64STVG8fvKKJ7ngR4Y/cx0j5i/uuHz69mrXo1hm hBTOAhnqvqlvbwmfK/1d8RBXbRFQf0tfvLDdqNiARdnlm13fYDxOxv3bexB/9FzMWDxE 2HNjL45lQTm1BWQCz852vvhb+HAprPdJDQkwy70HJGoMUY+HjBQvTigdBXgoc7cro0mZ 49FA== X-Forwarded-Encrypted: i=1; AJvYcCXJFdgG8Es51EzW9FtUcHvDHfFR7uk3qUyOBWlVlU8EcB6zKmq04B4Bjya0tYj79ZyCifqPnxXv93QDbp95E10=@vger.kernel.org X-Gm-Message-State: AOJu0Yy26mjx72tHqb9ZpsGj6MIQItYL0Q/8TMEzAjFA3hN8oRIkrpZl Vpa86S59No78vUL8re26/8Ltx3dyBMBk+WaZFfeK1OBistZ6nUN3Rrl79SmxGoc= X-Gm-Gg: ASbGncvQD0mk+aqE3ecR+5YPGNhYX6SbC+emz4VjdJBzjum4i7NO+cmUlJpZ8puExd+ ahZH2Q+ZfBWg5hHiozy3wtnYFbmBSoeUS4UOeSLInqmzsAzHkv6Ubg6hHhKob+OiIpYTfLeT6j7 JClw3alXZe/wol86cwBoV81wfhq5lLuFmqacUIfedyXA8zdWAoHM6QDmRRbkVLi6tF6mLsgBiEH iFieD2L+Gb+SiUjUUIQpHfoEDPW5szZM+NFWWwZH7/V4I0F79IyluG8sEVdk2B4MM9HXxm0T5bo eOvTFcRy7YVITlfCOBzW+95jLE8n6Wf6G/RTvusw7qfyUhZ99P0LunBkOF0cMfpd370FQj62u1W e6WdZwJRMub0M X-Google-Smtp-Source: AGHT+IFQXaLcPiac68cSLV4WsHdVRb67rogM0b27Rpkqgk1ad4c1qTHP8Vc1O703UVRXxD05dGwmzg== X-Received: by 2002:a17:903:1a28:b0:224:13a4:d61e with SMTP id d9443c01a7336-22db3dfbcb8mr6113335ad.51.1745453168527; Wed, 23 Apr 2025 17:06:08 -0700 (PDT) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db50e7a1dsm534375ad.140.2025.04.23.17.06.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 17:06:08 -0700 (PDT) Date: Wed, 23 Apr 2025 17:06:05 -0700 From: Joe Damato To: Jakub Kicinski Cc: netdev@vger.kernel.org, pabeni@redhat.com, shaw.leon@gmail.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , open list , "open list:KERNEL SELFTEST FRAMEWORK" , "open list:XDP (eXpress Data Path):Keyword:(?:b|_)xdp(?:b|_)" Subject: Re: [PATCH net-next v3 3/3] selftests: drv-net: Test that NAPI ID is non-zero Message-ID: Mail-Followup-To: Joe Damato , Jakub Kicinski , netdev@vger.kernel.org, pabeni@redhat.com, shaw.leon@gmail.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , open list , "open list:KERNEL SELFTEST FRAMEWORK" , "open list:XDP (eXpress Data Path):Keyword:(?:b|_)xdp(?:b|_)" References: <20250418013719.12094-1-jdamato@fastly.com> <20250418013719.12094-4-jdamato@fastly.com> <20250423161612.3dc2923e@kernel.org> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250423161612.3dc2923e@kernel.org> On Wed, Apr 23, 2025 at 04:16:12PM -0700, Jakub Kicinski wrote: > On Fri, 18 Apr 2025 01:37:05 +0000 Joe Damato wrote: > > + bin_remote = cfg.remote.deploy(cfg.test_dir / "napi_id_helper") > > + listen_cmd = f"{bin_remote} {cfg.addr_v['4']} {port}" > > + > > + with bkg(listen_cmd, ksft_wait=3) as server: > > Sorry, not sure how I misread v2 but you are running the helper locally. > So you don't have to deploy it to the remote machine :( OK I can remove that and fix the macro guard for the v4. > BTW does removing the ksft_wait() from the binary work? Or does it > cause trouble? Don't think we need to wait for anything in this case. > With the XSK test we had to wait for the test to do the inspection > before we unbound. Here once we get the connection we can just exit, no? I agree that we can just exit, but removing the wait breaks ksft utils: # Exception| Traceback (most recent call last): # Exception| File "/home/jdamato/code/net-next/tools/testing/selftests/net/lib/py/ksft.py", line 223, in ksft_run # Exception| case(*args) # Exception| File "/home/jdamato/code/net-next/./tools/testing/selftests/drivers/net/napi_id.py", line 13, in test_napi_id # Exception| with bkg(listen_cmd, ksft_wait=3) as server: # Exception| File "/home/jdamato/code/net-next/tools/testing/selftests/net/lib/py/utils.py", line 130, in __exit__ # Exception| return self.process(terminate=self.terminate, fail=self.check_fail) # Exception| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ # Exception| File "/home/jdamato/code/net-next/tools/testing/selftests/net/lib/py/utils.py", line 78, in process # Exception| os.write(self.ksft_term_fd, b"1") # Exception| BrokenPipeError: [Errno 32] Broken pipe LMK how you'd like me to proceed ? I'm thinking: - Leave ksft_wait() - macro guard - don't deploy helper to remote machine