From: Stanislav Fomichev <stfomichev@gmail.com>
To: Cosmin Ratiu <cratiu@nvidia.com>
Cc: netdev@vger.kernel.org, Stanislav Fomichev <sdf@fomichev.me>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"jiri @ resnulli . us" <jiri@resnulli.us>,
Saeed Mahameed <saeedm@nvidia.com>,
Dragos Tatulea <dtatulea@nvidia.com>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] net: Lock lower level devices when updating features
Date: Tue, 6 May 2025 10:12:23 -0700 [thread overview]
Message-ID: <aBpC9_SgUaAA2P0f@mini-arch> (raw)
In-Reply-To: <20250506142117.1883598-1-cratiu@nvidia.com>
On 05/06, Cosmin Ratiu wrote:
> __netdev_update_features() expects the netdevice to be ops-locked, but
> it gets called recursively on the lower level netdevices to sync their
> features, and nothing locks those.
>
> This commit fixes that, with the assumption that it shouldn't be possible
> for both higher-level and lover-level netdevices to require the instance
> lock, because that would lead to lock dependency warnings.
>
> Without this, playing with higher level (e.g. vxlan) netdevices on top
> of netdevices with instance locking enabled can run into issues:
Mentioning vxlan is a bit confusing here; it shouldn't let you flip lro (I
think). Which upper are you testing against?
Trying to understand if we can cover this case in the selftests.
netdevsim also doesn't expose F_LRO feature... (yet?)
next prev parent reply other threads:[~2025-05-06 17:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 14:21 [PATCH net] net: Lock lower level devices when updating features Cosmin Ratiu
2025-05-06 17:12 ` Stanislav Fomichev [this message]
2025-05-06 17:40 ` Stanislav Fomichev
2025-05-06 17:47 ` Cosmin Ratiu
2025-05-06 18:13 ` Stanislav Fomichev
2025-05-07 14:35 ` Cosmin Ratiu
2025-05-07 15:13 ` Cosmin Ratiu
2025-05-07 20:29 ` Cosmin Ratiu
2025-05-07 21:20 ` Stanislav Fomichev
2025-05-08 10:33 ` Cosmin Ratiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBpC9_SgUaAA2P0f@mini-arch \
--to=stfomichev@gmail.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).