From: Tzung-Bi Shih <tzungbi@kernel.org>
To: David Gow <davidgow@google.com>
Cc: brendan.higgins@linux.dev, rmoar@google.com,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com
Subject: Re: [PATCH] kunit: Fix wrong parameter to kunit_deactivate_static_stub()
Date: Thu, 22 May 2025 05:54:02 +0000 [thread overview]
Message-ID: <aC67-mvJFxwn2sNo@google.com> (raw)
In-Reply-To: <CABVgOSkuXoa_bad-Djm+5s0ivZ5XogB2SUJ-9t_GC5xzh=iKVA@mail.gmail.com>
On Wed, May 21, 2025 at 03:44:04PM +0800, David Gow wrote:
> On Tue, 20 May 2025 at 16:21, Tzung-Bi Shih <tzungbi@kernel.org> wrote:
> >
> > kunit_deactivate_static_stub() accepts real_fn_addr instead of
> > replacement_addr. In the case, it always passes NULL to
> > kunit_deactivate_static_stub().
> >
> > Fix it.
> >
> > Fixes: e047c5eaa763 ("kunit: Expose 'static stub' API to redirect functions")
> > Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
> > ---
>
> Nice catch! I guess no-one's ever tried to pass NULL to deactivate the stub!
>
> (Maybe we should add a test for this somewhere?)
Added a test for this,
https://lore.kernel.org/linux-kselftest/20250522054912.2948008-1-tzungbi@kernel.org/T/#u
prev parent reply other threads:[~2025-05-22 5:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 8:20 [PATCH] kunit: Fix wrong parameter to kunit_deactivate_static_stub() Tzung-Bi Shih
2025-05-21 7:44 ` David Gow
2025-05-22 5:54 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aC67-mvJFxwn2sNo@google.com \
--to=tzungbi@kernel.org \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=rmoar@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).