From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13AE11F4C90 for ; Tue, 26 Aug 2025 14:05:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217117; cv=none; b=bZlalfHOeOpQkHUWOy0kdG+outD8GIt7iDNyUmrWHWQKNMplrFkVL27rfb5lbIpVf/UYsHA/1HkbYF8q5E9+V6AQPGY/Nc6u47jQZQbNAxxn0Z70JMFE52L4FewptBJTkvZiQf7SwKYZunLwH6QksGU5iax1V59z0ucnhobHUIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217117; c=relaxed/simple; bh=E47bQJ0fSKLMTa4+BbXXtJ7X4w0mQUaOEOsTXbSBPvs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=nN9dl5EQNuTh1PidYIOXuyX+/H/MOzolfaK0N/2z8DEcnQpXepcv9iUGKe7GBqoS9fPRmqi60TNaCHCRuj2CJR4zJ+myt5mJB0WNAY3lYL3wTWFPCNEunLJH1va+FBRe4kYxM+BRpAVhxKZRRLYtLvFAh+igj5cTXgpsn8/PsBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Tdsfn3ZI; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Tdsfn3ZI" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-3259ff53c2eso3277394a91.1 for ; Tue, 26 Aug 2025 07:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1756217115; x=1756821915; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=M8sjcZwofKG6BnJQmAymrI3Jle93znSmRx0EtubpPtg=; b=Tdsfn3ZILUtiBA0AQQ6P1e1sIjHJYzUeNBEm/wf838nYk2Ng3p/onkIu/vSx7DcRr8 F2s8I6lJlMQuK6TnMRogZgpqr2ffnB8Mc2v36qjmk6lCEM4mfP7RfoxVfFxfaRYx8FDZ r9a8Os9nhuad8+HZX2n8DfPrQlKSueh0s0owNwgAPO5CDwmLvBN0SIA/IbZBuvtzVSwK M1hlpwC6ul9h2oiyP+HUf7MjKucb0zoVnLLhYpHFOlbSxBZrahssld5wG8W4Js/rHLbs 4blIQAVFEhHz8g5X3eNY5/WzfP5GddN/pvDNk52y3Sa5T91VLUQD60VZtcmMMPn1XI2B kZDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756217115; x=1756821915; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M8sjcZwofKG6BnJQmAymrI3Jle93znSmRx0EtubpPtg=; b=LLYLodtNr1SkDY0qChFJiG66Z1U36jU3tD7Ir+2gzILHCYjZCiFzN9epZWh9yW3bYw vTCaFPCAzPHWxTJSSgFlifyAGJcJF+75hszy4VFp34YGGHIbaehiYqJ8cAWaRu/g2lII slPnqTTy8m5RKJyU8lyRnOZauRRypn+YwYlOCBRMP1Ss97beRJa7LWG5YHzKim4WrYn9 AIBq24tVvs0GhH94UTNszFT2MTXVMO91mcN0drFoE5062sXkoMPSJmva6QxZp7seQkQE cMMRYxI+Jh5rvsNHK//7pvYKv0ley9xP1Kp+pWRG0Jf1A8TyJSGyzx+60zYmf2SkwMkZ PlZg== X-Forwarded-Encrypted: i=1; AJvYcCV6ZrYvS6oDzm+Itrv2kel1rKbM6DrseysHYLqIK5e6OdTny1OGDPvxJc1+ECJrMCrwbjiAB7z+c8d5eFxr/7w=@vger.kernel.org X-Gm-Message-State: AOJu0YzIXXwHNVSQGn/tJN0u7ljzoN7EC8h19dK79HfxCmucMZ2hpp/b y8AgTwTJZls/wdsAcvLtC30f5jrJdVlwvO8WvgOFSGg9XBzlhP8YMERUPeJ2eNnD0dNH8TiA4kb UVwDo0A== X-Google-Smtp-Source: AGHT+IGb7UTw93XDTXoLc3UC3K1e508fQEqN/Z8f7EWKzjedshJnEFb0jKrFZrSKXsmYFuidjgvX5MOYCtw= X-Received: from pjzz12.prod.google.com ([2002:a17:90b:58ec:b0:324:eb0d:70e8]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:3d0c:b0:240:9f9:46b1 with SMTP id d9443c01a7336-2462ef3e955mr197406155ad.37.1756217115314; Tue, 26 Aug 2025 07:05:15 -0700 (PDT) Date: Tue, 26 Aug 2025 07:05:12 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250821042915.3712925-1-sagis@google.com> <20250821042915.3712925-4-sagis@google.com> Message-ID: Subject: Re: [PATCH v9 03/19] KVM: selftests: Expose functions to get default sregs values From: Sean Christopherson To: Binbin Wu Cc: Sagi Shahar , linux-kselftest@vger.kernel.org, Paolo Bonzini , Shuah Khan , Ackerley Tng , Ryan Afranji , Andrew Jones , Isaku Yamahata , Erdem Aktas , Rick Edgecombe , Roger Wang , Oliver Upton , "Pratik R. Sampat" , Reinette Chatre , Ira Weiny , Chao Gao , Chenyi Qiang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Tue, Aug 26, 2025, Binbin Wu wrote: > On 8/21/2025 12:28 PM, Sagi Shahar wrote: > > TDX can't set sregs values directly using KVM_SET_SREGS. Expose the > > default values of certain sregs used by TDX VMs so they can be set > > manually. > > > > Signed-off-by: Sagi Shahar > > --- > > .../selftests/kvm/include/x86/processor.h | 6 +++ > > .../testing/selftests/kvm/lib/x86/processor.c | 41 +++++++++++++++---- > > 2 files changed, 40 insertions(+), 7 deletions(-) > > > > diff --git a/tools/testing/selftests/kvm/include/x86/processor.h b/tools/testing/selftests/kvm/include/x86/processor.h > > index 2efb05c2f2fb..5c16507f9b2d 100644 > > --- a/tools/testing/selftests/kvm/include/x86/processor.h > > +++ b/tools/testing/selftests/kvm/include/x86/processor.h > > @@ -1026,6 +1026,12 @@ static inline struct kvm_cpuid2 *allocate_kvm_cpuid2(int nr_entries) > > void vcpu_init_cpuid(struct kvm_vcpu *vcpu, const struct kvm_cpuid2 *cpuid); > > +uint16_t kvm_get_default_idt_limit(void); > > +uint16_t kvm_get_default_gdt_limit(void); > > +uint64_t kvm_get_default_cr0(void); > > +uint64_t kvm_get_default_cr4(void); > > +uint64_t kvm_get_default_efer(void); > Can these be defined in the header file as static inline? Yes please. Performance isn't a concern, but as a developer, it's nice to not have to bounce to a definition to find such simple information.