From: Jiri Olsa <olsajiri@gmail.com>
To: Menglong Dong <menglong.dong@linux.dev>
Cc: Menglong Dong <menglong8.dong@gmail.com>,
Jiri Olsa <olsajiri@gmail.com>,
andrii@kernel.org, eddyz87@gmail.com, mykolal@fb.com,
ast@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev,
song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me,
haoluo@google.com, shuah@kernel.org, yikai.lin@vivo.com,
memxor@gmail.com, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 3/3] selftests/bpf: add benchmark testing for kprobe-multi-all
Date: Fri, 29 Aug 2025 15:43:30 +0200 [thread overview]
Message-ID: <aLGugoKpnZbVPYtC@krava> (raw)
In-Reply-To: <3664215.iIbC2pHGDl@7940hx>
On Fri, Aug 29, 2025 at 03:01:41PM +0800, Menglong Dong wrote:
> On 2025/8/27 02:48 Jiri Olsa <olsajiri@gmail.com> write:
> > On Tue, Aug 26, 2025 at 04:04:30PM +0800, Menglong Dong wrote:
> > > For now, the benchmark for kprobe-multi is single, which means there is
> > > only 1 function is hooked during testing. Add the testing
> > > "kprobe-multi-all", which will hook all the kernel functions during
> > > the benchmark. And the "kretprobe-multi-all" is added too.
> >
> > hi,
> > fyi this bench causes panic on my setup.. very silent, so not sure
> > yet which function we should blacklist next, attaching my .config
>
> According to my testing, the panic is due to the task hang.
> With so many debug config enabled(KASAN, LOCKDEP, etc),
> the system will become quite slow. What's wrose, there are
> many debug function is called during fprobe_entry(), which
> makes the BPF much slower. If you wait long enough, the
> testing can still run.
>
> Add more symbol to the blacklist can mitigate this problem,
> but we need to maintain many symbols for this purpose. So
> I suggest that we only run this testing in product kernel.
>
> What do you think?
yes I see the same.. I think we can keep it and perhaps make
some comment about that
jirka
prev parent reply other threads:[~2025-08-29 13:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 8:04 [PATCH bpf-next v2 0/3] selftests/bpf: benchmark all symbols for kprobe-multi Menglong Dong
2025-08-26 8:04 ` [PATCH bpf-next v2 1/3] selftests/bpf: move get_ksyms and get_addrs to trace_helpers.c Menglong Dong
2025-08-26 8:04 ` [PATCH bpf-next v2 2/3] selftests/bpf: skip recursive functions for kprobe_multi Menglong Dong
2025-10-02 16:18 ` ChaosEsque Team
2025-08-26 8:04 ` [PATCH bpf-next v2 3/3] selftests/bpf: add benchmark testing for kprobe-multi-all Menglong Dong
2025-08-26 18:48 ` Jiri Olsa
2025-08-27 6:54 ` Menglong Dong
2025-08-29 7:01 ` Menglong Dong
2025-08-29 13:43 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLGugoKpnZbVPYtC@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=menglong.dong@linux.dev \
--cc=menglong8.dong@gmail.com \
--cc=mykolal@fb.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yikai.lin@vivo.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox