From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 115072E7198 for ; Mon, 27 Oct 2025 08:14:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761552857; cv=none; b=tams5DPGgW6NPMpeu5+0oWVu9Xut0SlOkcLUMlVp559CIvMNNVdhITyrYl2FrFFj9nbcXrj3UBYDiiG3lrYc3djNRDDVpErSWm7khVL3Vnxzqjbj/vEsutNMBIw4n0cr1P8ywndgsgNB+gyD5yD7QjCBvQ0424qlGTWx97HM1Tc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761552857; c=relaxed/simple; bh=etqLAq7gFst0cSiu6SvH9Ue38STXBB7ceWx2V9z48vY=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JmlWqd4kv1ib3fvJntC2ByPWI8waPXPoZopRKDBjalr79458KYbQkjezhwEK2tKg4XahyXXuEZfsCtUuiQlj1migyfs8apJwRci6St6cvQu6TGfQ79zZL52ACpsphwpbU41JFHPs05B9ottlz3Ni1ec+VsC361NUlDBUn2mniTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZjY2ucJk; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZjY2ucJk" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-4298b865f84so2320313f8f.3 for ; Mon, 27 Oct 2025 01:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761552852; x=1762157652; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=LSHu/ivuk7OTgOMQRpfxc8sNj6kHssvRHTUG1SNhELU=; b=ZjY2ucJknPEr5TZb0i7UYyZcYgeYNPXQGodRT4eu7TGRopOFA0AWlOi8AVTlsaTB4o V2RiziNFJwmQOHqu1DwDye9JY9Jukubo2DeawpB5RC7yMIFvTk9SUiK47mkLMCn9/Bn7 aSyybIFMzED2MSXcW6DjGc2M8cm0cOgh7bJGKFQ9vRUMjvXHbEKjsfgFNAAXLhlPbFBy FBd5+zsZEIVyWGdOm9L4ArbqSSK7BXt/AXIY9vurTR+CxEZGXJWkK1RgxYhlOInayRe0 B9lrUw+NEMnqy431MnKpYrJVoU6Ezg7Tywuhq10ai6iTTmip3Ce4JKcFiqMSqgR8yvhS pgug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761552852; x=1762157652; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LSHu/ivuk7OTgOMQRpfxc8sNj6kHssvRHTUG1SNhELU=; b=QmG9ksKbGWaZuy6DuYcZiIgrW4ebRl6pRo6dDhHAMY/U6j8FgjmHb6q3W2BbV0ZycO ZHjARPGGTIp8qSRyC4Xk1V/ubS+eKB7K2A7ZZZSwolkpilVx+7J/FlpJVdsT+NuvA0tG iiEfm2ZeAw898ngzkiY+vb6BVQ5PICPGJct9yhhXH3HipsNtR9Ote2hGlGcHEIU+Z+JB JvLAtMCbAMI+8b41RojrpQg1qwBDEmob8aLbxRUIUNbKyT+eLmhT3kBQCRxrMkKyOjmq 6SGLNFPCtkt9aedxf68IZ2F0X7xbaPKF052NajVSW2aXWqSElB9dCDxFP54arKjty8oH /lsg== X-Forwarded-Encrypted: i=1; AJvYcCUSnsVXpxaBaM/kBMK8+Nuoj3tvIXHVPxXvQ9AOXDn8aK8GfStvxtgKJqlf7WQzakRGMzi7kFUPF57I7gYCGSI=@vger.kernel.org X-Gm-Message-State: AOJu0YykI/YzuBg6ahjikQBWWdV8G70EbFdWPYcA+YervyH49PQrazm6 OU/os9nCPX/sJmQmstWdbROMUAwp5ZLHuxVCT/kxHhe/Q65MFNN8uGNX X-Gm-Gg: ASbGncvTAfL8tElxw/YJEPM4CPIDyPn1l2XnLdRes+y9/24UHy0Dr6q3tlrPWc38FCl 1T+A2OwEn5OcabJMdsj1ykMYEIBqwtYTRC/H/yJ+z/ZPN7eHx6t5ym+m9mW8gd/hU7aRdpr+U58 7RUyP77KbN5Jq6/F4/K6GkqYNJYUf+ogwU2cN1SU1Uwg3evZJo0M+0//LnTZczU1RimZiVK9dAh tF+6Z4VpECibrg1ER9F3775+LmGCyOXSYzu3jI4O9YERy9eFFVc2Y63Sz99te9yrJIjNkxM4b0+ EBnhajuhjw+ejdnLAAFz/cPOinQG9QeqyeRlVNe1QLQVog2GV4LC+gu88briovOrNaZLjNWI4JI /+jdEQHWPZvfrkvx49yXkhCOBb7egkw+sxe6fgz9fJNrFFk2Lfxi1BvOZXq3YdjFDnMXsyMs= X-Google-Smtp-Source: AGHT+IFFKQfLGx2QdYO29wjJqWg+dPw9x5/f0UKf4PSXFO3HYbVj3gV1HeTpZudQpFAVTpuMJ53ygg== X-Received: by 2002:a05:6000:4a09:b0:427:62b:7f3 with SMTP id ffacd0b85a97d-427062b07f9mr28406369f8f.33.1761552852032; Mon, 27 Oct 2025 01:14:12 -0700 (PDT) Received: from krava ([2a02:8308:a00c:e200::b44f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952d5768sm13058047f8f.24.2025.10.27.01.14.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 01:14:11 -0700 (PDT) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Mon, 27 Oct 2025 09:14:09 +0100 To: Nirbhay Sharma Cc: Kees Cook , Shuah Khan , Andy Lutomirski , Will Drewry , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, llvm@lists.linux.dev, khalid@kernel.org, david.hunter.linux@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org, Jiri Olsa , sam@gentoo.org Subject: Re: [PATCH v2] selftests/seccomp: fix pointer type mismatch in UPROBE test Message-ID: References: <20251026091232.166638-2-nirbhay.lkd@gmail.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251026091232.166638-2-nirbhay.lkd@gmail.com> On Sun, Oct 26, 2025 at 02:42:33PM +0530, Nirbhay Sharma wrote: > Fix compilation error in UPROBE_setup caused by pointer type mismatch > in the ternary expression when compiled with -fcf-protection. The > probed_uprobe function pointer has the __attribute__((nocf_check)) > attribute, which causes the conditional operator to fail when combined > with the regular probed_uretprobe function pointer: > > seccomp_bpf.c:5175:74: error: pointer type mismatch in conditional > expression [-Wincompatible-pointer-types] > > Cast both function pointers to 'const void *' to match the expected > parameter type of get_uprobe_offset(), resolving the type mismatch > while preserving the function selection logic. > > This error appears with compilers that enable Control Flow Integrity > (CFI) protection via -fcf-protection, such as Clang 19.1.2 (default > on Fedora). > > Signed-off-by: Nirbhay Sharma Reviwed-by: Jiri Olsa thanks, jirka > --- > tools/testing/selftests/seccomp/seccomp_bpf.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c > index 874f17763536..e13ffe18ef95 100644 > --- a/tools/testing/selftests/seccomp/seccomp_bpf.c > +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c > @@ -5172,7 +5172,8 @@ FIXTURE_SETUP(UPROBE) > ASSERT_GE(bit, 0); > } > > - offset = get_uprobe_offset(variant->uretprobe ? probed_uretprobe : probed_uprobe); > + offset = get_uprobe_offset(variant->uretprobe ? > + (const void *)probed_uretprobe : (const void *)probed_uprobe); > ASSERT_GE(offset, 0); > > if (variant->uretprobe) > -- > 2.48.1 >