From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D8911B0413 for ; Mon, 10 Nov 2025 23:02:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762815759; cv=none; b=Ls4nbFEAfcN0FVu4FtC3do1Vyb3aicmW5Y4ENiHyT4aQU7JyUGqmDh5rfvO8jb5gzxVP8DeAjjT8ItE6zJvYYjKmJpOauEJ8xiWbRsc/KxO5T2g9hj2wByDNI0gzGx8avWnsrLBqfo2belfyYt+QHsciu7npwbx0KDEH2BvNDvc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762815759; c=relaxed/simple; bh=6TNXJq+rMH9dVRYVDgjIiVOlEcVoFw99/BJYAESuZUs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JBaVWFWqUgqqIdIavDsESX+vyaImo/WUMj8GSj4ATAIoIBrOPXem7vZD+tdFFmOSL7fs6852nXEJok94nGZnuPS41U8RvJovhg/xZTacQ+FsgBVr1fz1e9siF9eC8m2k/2aIxIIXIz3jwcVgExHOxbW7F5fJAskVJ6hi3DxLHXA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hnFkdTkv; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hnFkdTkv" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-b6cf07258e3so1896088a12.0 for ; Mon, 10 Nov 2025 15:02:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1762815757; x=1763420557; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2oZbUXm17MlJJYs7nTRrwTniBYsG7HY04j7c8fnXzJ4=; b=hnFkdTkvMaN57K7ORUi3hT7ZDpAL5GOlbZezkvxGvKafYoDxqHe8SxYo2drgtwvplM soL4d9nV4nCfJIdv/patpxjbZZTyQVLsHuR0ogMGRJGVJsFlhb3GuyGYQerpeaX114+t NKYdqB3FgtdqL+TRlj4QY98izv38oSfKwUZiWbjS3cJ5HQ2xLCi5Eoja3ZToflzYLAgc 2M/BsrPC+/opdV+72JzFctLFOPDIndU/lFnHIZo/Sv1ZHLcydOYeT5S4+Bs3DP726vAT t7vORiTQHeK25mTkkQ5G8PCVZH+C/J8wsn+Hlj8DkqymwJACag1ckbQRtgXmthwHX8Zn bKYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762815757; x=1763420557; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2oZbUXm17MlJJYs7nTRrwTniBYsG7HY04j7c8fnXzJ4=; b=Uzyy77VGLqJy7s4NE3iaXZqf6jzCx9+EhrkSoIhSq0GtcT4L8aBs2ewwIc4S+kXKB5 raXsH102sp0U5575ypu9F7V/hZd8Nm7S4SHh90DkP2b6nL1REi/RgFCaZmhXJEb2fQTt i0SOn1Xm4DXUxQIrdzGvCIvP4cBq7y48o+9byMQHuNgFcaW9E0CSROOomAR8mZOfo9UB HP3XfA5nH+JLyfy4QMmFBXqzWGwPppCJElpHNqjpv93GbKExU0b5SthrVOyvdJSeHOgR voFw3+0SmARCi4psGiTysxzHyYFaoW3Kfpiw0CGpBj7yigP4mfYIPBft+zLeP1mS3aL3 UrlQ== X-Forwarded-Encrypted: i=1; AJvYcCXJ23ZvuxHAY3TmOGPF6ksErzIEgRWJRygAcrbNZTnkSWts2sp89ok45Q2WevW1V3FkRmYg3OYuvR56Fvw6Dgw=@vger.kernel.org X-Gm-Message-State: AOJu0YzhpTTPWlXh92Ga6GPbyPJ/+a8tEsMFMNWUShQepwHh9aXiVu42 ccZi31pwgkqWXC8kUJgbR8DXmGoGX/OYvc/FQJ/9r41hoHSCHhhUBHSbDWuJJj3wTw== X-Gm-Gg: ASbGncvOsOvwPBR+fSoE3HW9a/5XBsifrOWpLf4HpefONtTIT/99ZlzOAnoXt9oMgKl eVmMb+mky+3dDUsAjxOlcc0fZG7BVhLbJwvfNQOzoGbWtc19r/SpVDzZTrUODHwBr4bHSHMkOuZ W2T4Tf8q+/x6szIurC1rZB6XpNHp3Ez+zEtJnKT2AVwzWClyQsbSt1BI2+b79d/bB1WSyNlrgml xu2A6ewsfpbfNwJImrjA8pPVpuo3Vz+NNfsduztJdHGGNYoxmqX3GuviqDpYnE4KA4Bo+BLa3ct D6ADyIhiwq06MODNzoJIM0quxC7VRAljF3PncbkYP8dDSgZ7Se86jzjMGwUMQdg3ATFrlBDIcSR kkbNQ5Xivhgl8Mi9GgrY10am8Ah3R+ajTCx88zsf9tAS/0bSZZkOSgvh77sx3NdkjGOuC/jxveh tHBeHQr+4swzhQerzb3PhYHjYjExF06p8lYwdbh+STiii/bH83PfXzPF+5xeF3bMc= X-Google-Smtp-Source: AGHT+IHoKo9/+Pwh3K40r/l8V5QU5Uk2a1RS5slNOQYfptjWO4tqmkHSZfI1hg8lgbKPM7wXJRriYg== X-Received: by 2002:a17:902:d485:b0:295:7454:34fd with SMTP id d9443c01a7336-297e56adac0mr148711535ad.39.1762815757123; Mon, 10 Nov 2025 15:02:37 -0800 (PST) Received: from google.com (132.200.185.35.bc.googleusercontent.com. [35.185.200.132]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29651c9c310sm159853455ad.87.2025.11.10.15.02.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 15:02:36 -0800 (PST) Date: Mon, 10 Nov 2025 23:02:32 +0000 From: David Matlack To: Alex Mastro Cc: Alex Williamson , Shuah Khan , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH 1/4] vfio: selftests: add iova range query helpers Message-ID: References: <20251110-iova-ranges-v1-0-4d441cf5bf6d@fb.com> <20251110-iova-ranges-v1-1-4d441cf5bf6d@fb.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 2025-11-10 02:32 PM, Alex Mastro wrote: > On Mon, Nov 10, 2025 at 10:03:54PM +0000, David Matlack wrote: > > On 2025-11-10 01:10 PM, Alex Mastro wrote: > > > + > > > + hdr = vfio_iommu_info_cap_hdr(buf, VFIO_IOMMU_TYPE1_INFO_CAP_IOVA_RANGE); > > > + if (!hdr) > > > + goto free_buf; > > > > Is this to account for running on old versions of VFIO? Or are there > > some scenarios when VFIO can't report the list of IOVA ranges? > > I wanted to avoid being overly assertive in this low-level helper function, > mostly out of ignorance about where/in which system states this capability may > not be reported. Makes sense, but IIUC a failure here will eventually turn into an assertion failure in all callers that exist today. So there's currently no reason to plumb it up the stack. For situations like this, I think we should err on asserting at the lower level helpers, and only propagating errors up as needed. That keeps all the happy-path callers simple, and those should be the majority of callers (if not all callers).