From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E1A379DA; Thu, 27 Nov 2025 10:36:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764239789; cv=none; b=pU4QfYT8O2Rgz5zd2M89nvPqAbOsnBjhtsw0NFOUzWqDtbDxZf2GBhfvmfW6rn6AkbAUzAPVAB4WKA0HfMCv+s9bOiTLSvKskpWjAOMJi0PgIQUxjteAbGKDaall+g1i8PZO00a8JkiaaC5AiU2c2C+q2qRUw9w56DzkszVYvBI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764239789; c=relaxed/simple; bh=EW7fa0YR0eAojjarOFkeA2S1shqTF3govz1KNpd+VNk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R2eVS1rPGCAdGIlZUwzIzDpNGxplIkU+1nR4xXrDF1VTt+Ax0baUzoDdRBmJSj9nC0Ug4KsSTjp14CtpK5j13ULd0j8mjaltJ+C86J0NZDkiusByBkGkspd9nAonmU4J0sYelyNrsMzLrJ538LNACc6RYzF2k9Zdy42JEb4j0Qk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Hf1NMK2q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Hf1NMK2q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8E3EC113D0; Thu, 27 Nov 2025 10:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764239789; bh=EW7fa0YR0eAojjarOFkeA2S1shqTF3govz1KNpd+VNk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hf1NMK2qId4G69jvB9K1jaDpSSbHc9z7L7hEiWYkXA+owEUB5rhk+3dXMbQSrEm2e jTbTzwS/D1rlaSUmsddYIY/nEbhUMvcF54rbGLh7n1gRgiU8ILVbSgj1y1ehcf9VGH qjBQGzgdBbS7Vc2FfR0TFqfMRW24fVG25hOXyZHffhid2u0bPGbZoZljVSsCbOn+Sl glfuRo11li8xf9HdqBwO/vOolcd8estetolotsVKfGGiP0HQ74MWLEgaQWzyz2gbS5 3HlD+GwWe7UUm7kOJIqKAC2BV0tU/ddVj5mS7ilS1V4HF9VITB5LacR3Ck+7s2TQSH LNK7x+xRw2xpg== Date: Thu, 27 Nov 2025 12:36:19 +0200 From: Mike Rapoport To: Nikita Kalyazin Cc: linux-mm@kvack.org, Andrea Arcangeli , Andrew Morton , Axel Rasmussen , Baolin Wang , David Hildenbrand , Hugh Dickins , James Houghton , "Liam R. Howlett" , Lorenzo Stoakes , Michal Hocko , Paolo Bonzini , Peter Xu , Sean Christopherson , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 4/5] guest_memfd: add support for userfaultfd minor mode Message-ID: References: <20251125183840.2368510-1-rppt@kernel.org> <20251125183840.2368510-5-rppt@kernel.org> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Nov 26, 2025 at 04:49:31PM +0000, Nikita Kalyazin wrote: > On 25/11/2025 18:38, Mike Rapoport wrote: > > From: "Mike Rapoport (Microsoft)" > > > > +#ifdef CONFIG_USERFAULTFD > > +static struct folio *kvm_gmem_get_folio(struct inode *inode, pgoff_t pgoff) > > We have to name it differently, otherwise it clashes with the existing one > in this file. It's all David's fault! ;-P How about kvm_gmem_get_prepared_folio() ? -- Sincerely yours, Mike.