From: Jason Gunthorpe <jgg@ziepe.ca>
To: Kathara Sasikumar <katharasasikumar007@gmail.com>
Cc: kevin.tian@intel.com, shuah@kernel.org, iommu@lists.linux.dev,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.l.liu@intel.com, nicolinc@nvidia.com,
alex.williamson@redhat.com, katharaasasikumar007@gmail.com
Subject: Re: [PATCH] selftests: iommu: fix Warray-bounds in get_hw_info test
Date: Fri, 12 Dec 2025 02:31:02 -0400 [thread overview]
Message-ID: <aTu2pgId9mRPPIRj@ziepe.ca> (raw)
In-Reply-To: <20251210211342.989850-1-katharasasikumar007@gmail.com>
On Wed, Dec 10, 2025 at 09:13:42PM +0000, Kathara Sasikumar wrote:
> The get_hw_info uses a smaller user buffer on purpose to check how
> the kernel updates only the fields that fit in the buffer. The test
> created a custom smaller struct for this, but the helper function later
> treats the buffer as struct iommu_test_hw_info. This makes the compiler
> warn about a possible out-of-bounds access (-Warray-bounds).
>
> This keeps the test behavior the same and removes the warning.
>
> Signed-off-by: Kathara Sasikumar <katharasasikumar007@gmail.com>
> ---
> tools/testing/selftests/iommu/iommufd.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
This breaks the test, I already posted a fix, it should be in linux-next.
Jason
prev parent reply other threads:[~2025-12-12 6:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 21:13 [PATCH] selftests: iommu: fix Warray-bounds in get_hw_info test Kathara Sasikumar
2025-12-12 6:31 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTu2pgId9mRPPIRj@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=alex.williamson@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=katharaasasikumar007@gmail.com \
--cc=katharasasikumar007@gmail.com \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=shuah@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).