From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Linus Walleij <linusw@kernel.org>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Jason Gunthorpe <jgg@nvidia.com>, Johan Hovold <johan@kernel.org>,
"Paul E . McKenney" <paulmck@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
chrome-platform@lists.linux.dev, linux-gpio@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 03/11] gpio: sysfs: Remove redundant check for struct gpio_chip
Date: Mon, 23 Feb 2026 14:17:58 +0800 [thread overview]
Message-ID: <aZvxFqTLaGa-gHmA@tzungbi-laptop> (raw)
In-Reply-To: <CAD++jLn6XxLp7hdBOHbvAJ2bxY4dnfiWDV_UVT+EAyaKmV3Naw@mail.gmail.com>
On Fri, Feb 20, 2026 at 08:51:29AM +0100, Linus Walleij wrote:
> On Fri, Feb 13, 2026 at 10:31 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
> > -void gpiochip_sysfs_unregister(struct gpio_device *gdev)
> > +void gpiochip_sysfs_unregister(struct gpio_chip *chip)
>
> Here it is chip
>
> > -static inline void gpiochip_sysfs_unregister(struct gpio_device *gdev)
> > +static inline void gpiochip_sysfs_unregister(struct gpio_chip *chip)
>
> And here.
>
> > @@ -1286,7 +1286,7 @@ void gpiochip_remove(struct gpio_chip *gc)
> > struct gpio_device *gdev = gc->gpiodev;
>
> But you can see that we call it "gc" (gpiochip).
>
> Chip is more ambiguous I think, can you use "gc" everywhere?
Ack, will fix in v4.
next prev parent reply other threads:[~2026-02-23 6:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 9:29 [PATCH v3 00/11] gpio: Adopt revocable mechanism for UAF prevention Tzung-Bi Shih
2026-02-13 9:29 ` [PATCH v3 01/11] gpio: Access `gpio_bus_type` in gpiochip_setup_dev() Tzung-Bi Shih
2026-02-20 7:46 ` Linus Walleij
2026-02-13 9:29 ` [PATCH v3 02/11] gpio: Remove redundant check for struct gpio_chip Tzung-Bi Shih
2026-02-20 7:48 ` Linus Walleij
2026-02-13 9:29 ` [PATCH v3 03/11] gpio: sysfs: " Tzung-Bi Shih
2026-02-20 7:51 ` Linus Walleij
2026-02-23 6:17 ` Tzung-Bi Shih [this message]
2026-02-13 9:29 ` [PATCH v3 04/11] gpio: Ensure struct gpio_chip for gpiochip_setup_dev() Tzung-Bi Shih
2026-02-18 10:24 ` Bartosz Golaszewski
2026-02-13 9:29 ` [PATCH v3 05/11] gpio: cdev: Don't check struct gpio_chip in gpio_chrdev_open() Tzung-Bi Shih
2026-02-20 7:51 ` Linus Walleij
2026-02-13 9:29 ` [PATCH v3 06/11] selftests: gpio: Add gpio-cdev-uaf tests Tzung-Bi Shih
2026-02-20 7:52 ` Linus Walleij
2026-02-13 9:29 ` [PATCH v3 07/11] gpio: Add revocable provider handle for struct gpio_chip Tzung-Bi Shih
2026-02-18 10:28 ` Bartosz Golaszewski
2026-02-13 9:29 ` [PATCH v3 08/11] gpio: cdev: Leverage revocable for accessing " Tzung-Bi Shih
2026-02-13 9:29 ` [PATCH v3 09/11] gpio: Remove gpio_chip_guard by using revocable Tzung-Bi Shih
2026-02-13 9:29 ` [PATCH v3 10/11] gpio: Leverage revocable for accessing struct gpio_chip Tzung-Bi Shih
2026-02-13 9:29 ` [PATCH v3 11/11] gpio: Remove unused `chip` and `srcu` in struct gpio_device Tzung-Bi Shih
2026-02-18 10:26 ` [PATCH v3 00/11] gpio: Adopt revocable mechanism for UAF prevention Bartosz Golaszewski
2026-02-23 6:21 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZvxFqTLaGa-gHmA@tzungbi-laptop \
--to=tzungbi@kernel.org \
--cc=brgl@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@nvidia.com \
--cc=johan@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rafael@kernel.org \
--cc=shuah@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox