Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Erik Hollensbe <erik@hollensbe.org>, linux-kselftest@vger.kernel.org
Cc: shuah@kernel.org, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] Correct leftover directories from make kselftest
Date: Mon, 8 Feb 2021 17:17:05 -0700	[thread overview]
Message-ID: <aadb7d9c-6042-0b4e-9d2a-764432ccf0ef@linuxfoundation.org> (raw)
In-Reply-To: <20210128033743.77040-2-erik@hollensbe.org>

On 1/27/21 8:37 PM, Erik Hollensbe wrote:
> Here are some directories that are created/filled as a part of the make
> kselftest process, but not ignored.
> 
> Signed-off-by: Erik Hollensbe <erik@hollensbe.org>
> ---
>   tools/testing/selftests/gpio/.gitignore   | 1 +
>   tools/testing/selftests/timens/.gitignore | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/gpio/.gitignore b/tools/testing/selftests/gpio/.gitignore
> index 4c69408f3e84..640b5cb4ed4e 100644
> --- a/tools/testing/selftests/gpio/.gitignore
> +++ b/tools/testing/selftests/gpio/.gitignore
> @@ -1,2 +1,3 @@
>   # SPDX-License-Identifier: GPL-2.0-only
>   gpio-mockup-chardev
> +tools-gpio
> diff --git a/tools/testing/selftests/timens/.gitignore b/tools/testing/selftests/timens/.gitignore
> index 2e43851b47c1..95e97d7bc336 100644
> --- a/tools/testing/selftests/timens/.gitignore
> +++ b/tools/testing/selftests/timens/.gitignore
> @@ -7,3 +7,4 @@ procfs
>   timens
>   timer
>   timerfd
> +futex
> 

Thank you for the patch.

Can you split these into two patches? make separate patches for gpio
and timens.

Gives you more practice. :)

thanks,
-- Shuah

  reply	other threads:[~2021-02-09  0:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28  3:37 Correct .gitignore in several places for kselftest outputs Erik Hollensbe
2021-01-28  3:37 ` [PATCH] Correct leftover directories from make kselftest Erik Hollensbe
2021-02-09  0:17   ` Shuah Khan [this message]
2021-02-09  0:28     ` Shuah Khan
2021-02-09 10:09     ` [PATCH] selftests/gpio: Adjust .gitignore to ignore tools-gpio build dir Erik Hollensbe
2021-02-09 10:36     ` [PATCH] Correct leftover directories from make kselftest Erik Hollensbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aadb7d9c-6042-0b4e-9d2a-764432ccf0ef@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=erik@hollensbe.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox