From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-235.mta0.migadu.com [91.218.175.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DE60286D4D for ; Fri, 21 Aug 2026 03:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.235 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787282266; cv=none; b=ISjJJ1kR0K00hE0rNSCAD5ovofg+MdGhmJhpIObW50k6km4/s8teGQSe1bHh8dSQf2gHb6xSaSnMBklOdlHdzDaydd1CJo17Q1mUxGE0qogeGZuUgk9Ai7ZxjTZfsKbiis5U+S9y8A5BrY8sZr+nLRUiF074YTkKu20IQuosQr0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787282266; c=relaxed/simple; bh=YzsViyV7hREnhdjE4oNJsni3zuIximevjl7gdibbQeg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EeIw0l5tCT0dVpnEX5oF3fDMoNyYfxDoyTslhhohtIBBz/vCBm6dqfgQ81E/zH9v0bczILirDOJV6TlWaJiAKMRGCt/O9Px9eAGQDOgOb0q2L0sKwCVQVRVkWWTvZUDloMlM9P4qWVKbRY5UFfsBQV+2JscgSSyt2tJM37WRNA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=oTkBQyQF; arc=none smtp.client-ip=91.218.175.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="oTkBQyQF" X-Envelope-To: linux-kselftest@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=YzsViyV7hREnhdjE4oNJsni3zuIximevjl7gdibbQeg=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787282259; v=1; x=1787887059; b=oTkBQyQFt2MpJ7ujdkTYYSezyTBJQ2Tst5gB6e9VC4QJvNd/wxscuWU041T+5lO8KeT09Jvy a+DkXCJn5VhKHh5ErkH8QavDgMnAdY2+rSYQlKBjjxfpfkai7mCeA3xMdxmfj7G95wlQ5libdx7 QxNBr1VwhC6YzH+G3ofE3Odw= X-Envelope-To: linux-kselftest@vger.kernel.org Received: from [192.168.109.140] (223.70.159.239) by smtp.migadu.com with ESMTPS id da191edad99e2e12; Fri, 21 Aug 2026 03:17:39 +0000 X-Mizu-Trace-ID: da191edad99e2e12 X-Migadu-Flow: FLOW_OUT Message-ID: Date: Fri, 21 Aug 2026 11:17:32 +0800 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/17] cgroup/cpuset: Fix partition CPU ownership and isolation accounting To: Ridong Chen , longman@redhat.com, cgroups@vger.kernel.org Cc: tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Guopeng Zhang References: <20260820124202.517160-1-guopeng.zhang@linux.dev> <5a16ddf0-2b22-449d-84e8-1605c195ea41@linux.dev> Content-Language: en-US From: Guopeng Zhang In-Reply-To: <5a16ddf0-2b22-449d-84e8-1605c195ea41@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 在 2026/8/21 10:48, Ridong Chen 写道: > > > On 8/20/2026 8:41 PM, Guopeng Zhang wrote: >> From: Guopeng Zhang >> >> update_prstate() uses effective_xcpus for isolation accounting and >> housekeeping checks when switching a partition between root and >> isolated. The mask also includes CPUs granted to valid child partitions. >> Such a type change can alter isolation accounting for child-owned CPUs >> or fail a housekeeping check because of a CPU the parent does not own. >> >> A rejected type change can leave CPUs assigned to the invalidated >> partition instead of returning them to the partition that owns the >> invalidated subtree. When cpuset.cpus changes, child validation can use >> the old parent mask, and a remote update can observe stale cpus_allowed >> when it revisits a cpuset. Direct and propagated invalidation can leave >> isolated_cpus reflecting the released partition's type instead of the >> type of the partition receiving its CPUs. Releasing an isolated >> partition can clear boot-isolated CPUs from isolated_cpus. >> >> Limit type-change checks and accounting to CPUs owned directly by the >> partition. Preserve boot-isolated CPUs when a partition is released, >> return CPUs after rejected type changes, validate children against the >> new parent mask, and publish cpus_allowed before a partition update can >> revisit the cpuset. Fix isolation accounting during direct and >> propagated invalidation. >> >> Patch 1 removes an invalid selftest comparison that makes >> test_cpuset_prs.sh fail when boot-time domain isolation is configured. >> Each kernel fix is followed by a focused selftest update. >> >> Guopeng Zhang (17): >>    selftests/cgroup: Drop invalid boot isolation comparison >>    cgroup/cpuset: Preserve boot-isolated CPUs on partition release >>    selftests/cgroup: Test boot-isolated CPU partition release >>    cgroup/cpuset: Limit type-change accounting to owned CPUs >>    selftests/cgroup: Test isolated CPU accounting on type changes >>    cgroup/cpuset: Validate type changes against owned CPUs >>    selftests/cgroup: Test type-change validation with child-owned CPUs >>    cgroup/cpuset: Release CPUs when a type change is rejected >>    selftests/cgroup: Test rejected partition type changes >>    cgroup/cpuset: Fix isolated accounting on direct child invalidation >>    selftests/cgroup: Test isolation accounting on direct child >>      invalidation >>    cgroup/cpuset: Invalidate children outside the new CPU mask >>    selftests/cgroup: Test child invalidation after shrinking cpuset.cpus >>    cgroup/cpuset: Publish cpus_allowed before partition updates >>    selftests/cgroup: Test shrinking cpuset.cpus in a remote partition >>    cgroup/cpuset: Fix isolated accounting on propagated invalidation >>    selftests/cgroup: Test isolation accounting on propagated invalidation >> >>   kernel/cgroup/cpuset.c                        | 162 ++++++++++-- >>   .../selftests/cgroup/test_cpuset_prs.sh       | 231 +++++++++++++++++- >>   2 files changed, 361 insertions(+), 32 deletions(-) >> >> >> base-commit: 6a746cd265aed59107ebdaa9ce039bb832922969 > > Hi Guopeng, > > This is a fairly large series, which may make the review process challenging. I would suggest splitting it into smaller, more focused patches. It would also be very helpful if you could provide a reproducer for each bug you are trying to fix, so that we can verify the issue and the fix more effectively. > Hi Ridong, Thanks for the suggestion. The current series is indeed fairly large, which makes the individual issues harder to review. I initially kept these patches in one series because some of the later fixes depend on changes introduced by earlier patches. However, while preserving the necessary dependencies, I can group the fixes by issue, split them into several smaller, more focused series, and submit them separately. I will also add a reproducer to the changelog of each relevant patch, together with the actual behavior before the fix and the expected behavior. Sashiko has raised a few additional points that I am still reviewing. I will go through those first, and then reorganize and split the series for the next submission. Thanks, Guopeng