From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE9423D8110; Wed, 11 Mar 2026 15:42:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773243748; cv=none; b=Oc7bnNvdWXNF+o+nB9b223OmZHIeNsx5d9bGUxIzRFZCBLgmvpo2Rzt/NAgeArzjOqXd6Pu93mzlhv76xIzAvMhOVr/wHhK8gzn+g0gkpSq8/X6jzkqvqQUEOrhy4V3WxAEQxbqij03V0qY/XuHurRZ62A+kjnjVxkLT9tTrS3U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773243748; c=relaxed/simple; bh=BWwErrS9z3BJ/Kf4uE5Zd2qqwPcMU/ykSnOIsPweWGY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TjCxeHB8kKkIn3Ylxnnu6cxlT0H4Z8whniutt99pZxTwPF6+Qv0gMcK/bctxD/00D2EWNkLpLmROvNmYHpY3nqn0/CxiRBziskh2tO5xhGTIsFMwybF1Us0ezxlspveBaEnvTx5CvEqVplUv18qQQEaLmtpaIzgXsGMcnSwr5IY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=sAiEzUAi; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="sAiEzUAi" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 6D0951A2D72; Wed, 11 Mar 2026 15:42:24 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 37B5F60004; Wed, 11 Mar 2026 15:42:24 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 96C9C103699BF; Wed, 11 Mar 2026 16:42:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1773243742; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=uIKCV1V8/cnfFfPiktVd5Fy2Yl3h50pFoP+or1v13xc=; b=sAiEzUAiTmRR6CNXDs9+rbXTrv/zagyZqZ+qM8EdeRs9jIeiaIpCqzEeiOJVth/2Qd8+XL P+NlPm53q2AhOEF1XeyjjGmP52YSTa9xFF1oi+IdLipGRL5YCcMO2w5rMhWI2fcxaN83lY 3nF69Mx2vS/2Vsaizy4KMqpJ8uteXLvaTyjTmQ9ANbZyMGjuMTD1wYnTYdSdK4x9OykHmD ksdWwI2P+fLjccAadnAqfzilYEHFGVb+21/K77jAtxgIKvSdPcWad6Bzp41nEP4N0pIiE4 3NEIbDXRI0J9ndPPlr+meAe+iRDncoACW/y91W0SGSLezKl7i78jS6Vl7VsqgA== Message-ID: Date: Wed, 11 Mar 2026 16:42:16 +0100 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 02/11] ethtool: Add loopback netlink UAPI definitions To: Andrew Lunn , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Cc: netdev@vger.kernel.org, "David S. Miller" , Andrew Lunn , Donald Hunter , Eric Dumazet , Jakub Kicinski , Naveen Mamindlapalli , Paolo Abeni , Simon Horman , Danielle Ratson , Hariprasad Kelam , Ido Schimmel , Kory Maincent , Leon Romanovsky , Michael Chan , Oleksij Rempel , Pavan Chebbi , Piergiorgio Beruto , Russell King , Saeed Mahameed , Shuah Khan , Tariq Toukan , Willem de Bruijn , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org References: <20260310104743.907818-1-bjorn@kernel.org> <20260310104743.907818-3-bjorn@kernel.org> <580debbb-8f6c-4b60-95ef-22c68480ded1@bootlin.com> <87tsum3b1o.fsf@all.your.base.are.belong.to.us> From: Maxime Chevallier Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 11/03/2026 16:30, Andrew Lunn wrote: >> I like this. The nice thing is that since "name" is a string, we're not >> locked into an enum -- drivers report what they have using 802.3 >> vocabulary, and we document the recommended names (pcs, pma, pmd, mii) >> with references? That way it's unambiguous, but not too constrained. > > It is both good and bad. I expect some vendors will just ignore the > text and use what their data sheet says, because they don't know > better. An enum forces more consistency. > > https://gist.github.com/mjball/9cd028ac793ae8b351df1379f1e721f9 > > enum gets you around level 9. string around level 3. > > Andrew Oh didn't know that manifesto. Givent the current discussions I'm indeed starting to think an enum value will be enough to cover a good portion of the usecases, so I'm OK with it :) Maxime