From: Hangbin Liu <liuhangbin@gmail.com>
To: Qingfang Deng <qingfang.deng@linux.dev>
Cc: Brendan Jackman <jackmanb@google.com>,
Mark Brown <broonie@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCHv3] selftests: Use ktap helpers for runner.sh
Date: Fri, 17 Apr 2026 07:43:16 +0000 [thread overview]
Message-ID: <aeHklHWA6YpY98RN@fedora> (raw)
In-Reply-To: <861b722f-6d5e-4f47-9d17-00a98fceb8cc@linux.dev>
On Thu, Apr 16, 2026 at 04:07:08PM +0800, Qingfang Deng wrote:
> Hi, Hangbin
>
> This patch broke selftests run with `make -C tools/testing/selftests` as
> make uses /bin/sh by default:
>
> /bin/sh: 5: /home/qf/linux-next/tools/testing/selftests/kselftest/runner.sh:
> Bad substitution
>
> Add `SHELL := /bin/bash` to the start of lib.mk to fix this.
Hi Qingfang,
Thanks for the report. I saw Mark helped fix this issue.
Sorry for the inconvenient.
hangbin
next prev parent reply other threads:[~2026-04-17 7:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 8:07 [PATCHv3] selftests: Use ktap helpers for runner.sh Qingfang Deng
2026-04-17 7:43 ` Hangbin Liu [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-02-25 1:08 Hangbin Liu
2026-02-25 13:06 ` Brendan Jackman
2026-03-05 1:56 ` Hangbin Liu
2026-03-11 2:17 ` Hangbin Liu
2026-03-31 20:51 ` Shuah Khan
2026-04-01 1:05 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeHklHWA6YpY98RN@fedora \
--to=liuhangbin@gmail.com \
--cc=broonie@kernel.org \
--cc=jackmanb@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qingfang.deng@linux.dev \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox