From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A752C5B57D for ; Wed, 3 Jul 2019 01:18:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7F392064A for ; Wed, 3 Jul 2019 01:18:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562116699; bh=jgEb1b30euRG5UhMxm9wUOKRlQBuytXTtWrKG046N4M=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=OPe95VG3Mq5zd4jjOsZbxtHLsMNs4kETgNcPkwgb6AKuDdJDY/n1DcDEnOausQxDO mBhVe3hCfACSmBs3yj/1sDAerF8Bcly+Ww5gwbM7xNT2T2kt8l7YltHyb2W69XvJK0 t7S8slMnjlrEeeIlgPuXrRP9PdlTycNW5qGjDsqY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727190AbfGCBSO (ORCPT ); Tue, 2 Jul 2019 21:18:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:59110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727398AbfGCBSG (ORCPT ); Tue, 2 Jul 2019 21:18:06 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A97D02190F; Tue, 2 Jul 2019 22:48:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562107688; bh=jgEb1b30euRG5UhMxm9wUOKRlQBuytXTtWrKG046N4M=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=swV5j0FD7SXKbbH9o0nqIzNjH0j2QMqF1OQL1ZJj89P4Z3qK9Esni6llI366SN5Se SNoV4p4FkH94Bxa5I2sAVxJagoytmnzCie5kUcmQzIIRh/SfoajFtaFticWSdWZKln lI7X3t6Lydi4eU9yJeQnJ8R9UIyiWeyyFlHFiasY= Subject: Re: [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL" To: Colin Ian King , Andy Lutomirski Cc: Kees Cook , Thomas Gleixner , "open list:KERNEL SELFTEST FRAMEWORK" , kernel-janitors@vger.kernel.org, LKML , shuah References: <20190701130431.13391-1-colin.king@canonical.com> <6e5a9bed-4f7f-4851-0421-2b440ff1f584@kernel.org> <9ba791d5-0d67-9834-90e9-e1dca307d386@kernel.org> <0031e09b-e309-3976-09b1-dc8d10365aee@canonical.com> From: shuah Message-ID: Date: Tue, 2 Jul 2019 16:48:06 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <0031e09b-e309-3976-09b1-dc8d10365aee@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 7/2/19 4:42 PM, Colin Ian King wrote: > On 02/07/2019 20:25, shuah wrote: >> On 7/2/19 8:22 AM, shuah wrote: >>> On 7/1/19 11:48 AM, Andy Lutomirski wrote: >>>> On Mon, Jul 1, 2019 at 6:04 AM Colin King >>>> wrote: >>>>> >>>>> From: Colin Ian King >>>>> >>>>> There is an spelling mistake in an a test error message. Fix it. >>>>> >>>>> Signed-off-by: Colin Ian King >>>>> --- >>>>>   tools/testing/selftests/x86/test_vsyscall.c | 2 +- >>>>>   1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/tools/testing/selftests/x86/test_vsyscall.c >>>>> b/tools/testing/selftests/x86/test_vsyscall.c >>>>> index 4602326b8f5b..a4f4d4cf22c3 100644 >>>>> --- a/tools/testing/selftests/x86/test_vsyscall.c >>>>> +++ b/tools/testing/selftests/x86/test_vsyscall.c >>>>> @@ -451,7 +451,7 @@ static int test_vsys_x(void) >>>>>                  printf("[OK]\tExecuting the vsyscall page failed: >>>>> #PF(0x%lx)\n", >>>>>                         segv_err); >>>>>          } else { >>>>> -               printf("[FAILT]\tExecution failed with the wrong >>>>> error: #PF(0x%lx)\n", >>>>> +               printf("[FAIL]\tExecution failed with the wrong >>>>> error: #PF(0x%lx)\n", >>>>>                         segv_err); >>>>>                  return 1; >>>>>          } >>>>> -- >>>>> 2.20.1 >>>>> >>>> >>>> Acked-by: Andy Lutomirski >>>> >>> >>> Thanks Andy! >>> >>> I will queue this up for 5.3 >>> >>> -- Shuah >>> >> >> Hi Colin, >> >> Checkpatch warning on this. Probably failed on the original patch. >> Could you please fix the checkpatch warn, and send v2. > > If I split the line, I get another checkpatch warning: > > "WARNING: quoted string split across lines" > > Either way checkpatch emits a warning. The convention is to not break > literal strings, and the line is only a few chars over the 80 char > boundary, so the V1 of the patch is the way it should be IMHO. > As such this existed before your patch. I will apply v1. thanks, -- Shuah