Re: [PATCH v2 03/53] selftests/mm: migration: don't assume hupe page is TWOMEG

Mike Rapoport
2026-04-25T09:20:07Z

On Fri, Apr 24, 2026 at 01:14:44PM -0400, Luiz Capitulino wrote:
> On 2026-04-18 06:54, Mike Rapoport wrote:
> > From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
> >
> > migration tests presume that both THP and HugeTLB huge pages are 2MB.
> >
> > Add dynamic detection of huge page size with read_pmd_pagesize() for THP
> > and with default_huge_page_size() for HugeTLB.
> >
> > Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> > Reviewed by: Donet Tom <donettom@linux.ibm.com>
> > ---
> > tools/testing/selftests/mm/migration.c | 44 +++++++++++++++++++-------
> > 1 file changed, 32 insertions(+), 12 deletions(-)
> >
> > diff --git a/tools/testing/selftests/mm/migration.c b/tools/testing/selftests/mm/migration.c
> > index 60e78bbfc0e3..e3c2f831e15a 100644
> > --- a/tools/testing/selftests/mm/migration.c
> > +++ b/tools/testing/selftests/mm/migration.c
> > @@ -184,22 +184,27 @@ TEST_F_TIMEOUT(migration, shared_anon, 2*RUNTIME)
> > */
> > TEST_F_TIMEOUT(migration, private_anon_thp, 2*RUNTIME)
> > {
> > + unsigned long pmdsize;
> > uint64_t *ptr;
> > int i;
> > if (!thp_is_enabled())
> > SKIP(return, "Transparent Hugepages not available");
> > + pmdsize = read_pmd_pagesize();
>
> This is really minor, but I'd match read_pmd_pagesize()'s uint64_t
> return type.

Ack.

--
Sincerely yours,
Mike.