From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFCE43594A for ; Fri, 1 May 2026 01:07:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777597657; cv=none; b=QxQ3BndpGNLzWod1yQwI4uMfZIguobOATpWXeURUBiWrXQ+fIyJlwjPo2P/T04Jkk/V1jRvfwHD/USj5evB7c+k10HMPliwzELSnxMHkiKhlqzC6tS1TLVcmEYgA2EUqPrUdt1QTti3iMQOuI0ZahgXoAJYC+BteKBm3AYoM2U8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777597657; c=relaxed/simple; bh=bzjWLrIg2CCN3/hGH9Hbm2IFgPMgmGCzp/tnDAxT9M8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cr/b9gn7727imzX8EudIkyceh0djZZRAEhxN4kFOEb+ZETCJWTzqcG4nC+MUlAhqJjxveFaJ3LeYJ/wwTmlZP6tcbIcqpEJHHLmdLrvG/+h02QBxyszty66VJ0FoBNT8HS9cKyMXB/2jVOrpgf6xp1chvkmOyJ6/vNIN2ObAKIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MJOX65wu; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MJOX65wu" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-8eae9229110so242436285a.1 for ; Thu, 30 Apr 2026 18:07:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777597655; x=1778202455; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=luFHJPJpmJJ6ifj+D224jn0aiIzHHo2nBsB+na/dGdA=; b=MJOX65wufmDQeqKx+vwHw03RyQT9lsJPsjLW7k/6ZLPq7CxaUZ7dTyBDlybRSduKLt dFq1nfTiOJgS9d1B7nARYKb0jiG4jV38iFuIwRB7CGF+f25SuuUGfbEVBAvyuHokZUsU iONNlx8TjiehBmGif707jRp0OG3Ty5PjBQI9A8zvsUzVleaBlXNGgUdi/8xS5e52RVsQ zIcREcDAbNqGZr2LFax8rYh0SK+CyFwQzavB//8J+pEvYkkRKpdW0ARUFubew0zHL6K9 Cp7RvW9yO+Mzz/qLvFRktTAPrzBGY+X6tFN7yj743axJJ5szrzSkaNkOLQvoIDIppYcj xxHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777597655; x=1778202455; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=luFHJPJpmJJ6ifj+D224jn0aiIzHHo2nBsB+na/dGdA=; b=lNEoXfFxh0WC6+8F32A4SqYNCBnSwNE3p+mDy0U2B4Q8F2J+xbgilzDB4VlBccjaz2 enblyAQIEieBI8x/UfpHKfiei4tVPeIV0nkPSzqc0aigGGvfWRCXGCqx7T45JgVwSwd0 wvxLRoxxTuBDHZIoWQYi7XMzykVUfPAoJDJLEjwTJhlvCr1/qhc6BXsrcI+uWVWcSGKf csfzavOGgJjkUIJda3nMFwxKNi3Wau0pF1Z0DBjqTxUQnCvr8kZ3C7XsR6ZJ3eeriG5W OGZJ+sHIMTr27vCT1fiUXBk0PBPlwBQosXjNvDR0i7aTInyT1wWR0RCTfISlqduRl02E LEDg== X-Forwarded-Encrypted: i=1; AFNElJ9XknS8qfs6CBqbeGclVRR+FjEzaEo725PcwGyKd08Hopmv9+hVj3CDHzg+9ZBsznlP90/t4sy+EDHjodXAZFQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyqaeQKOZQSXvKTio5lDyEu1tEkwIFV+At2s2RVbLNAoaUVEWgJ d/2th8zYil0hytPzhztsvlN4Q6/UMyJ5fxyFfGPy0+qOaRL/5492k+TI X-Gm-Gg: AeBDieu5tghkOUE0xCitJCCSz7TMakD/Qzwnug4J9TmqBI1a3dDbujpUkmIT/2N5d0P +KIu5cLOb8ozL37MhWlRvi43ccwLIJmZ+szNCVFdtjqXlPjB9KBcolzOIjyA9kw3cFp7VWoKg+i WhHHH4x8r4SPuHLqgSDrBA6Qfld4KckjQLi3CuVogg3+yeocH6L2E6tN17qV6sJpKPOy5aj2MI8 7BcXOrbBGeyZ1jW0WndBzR6t02Jw3DVaE3F9yymwFvP/uLCWadnBOvq351P1PGbk82HTJswDf7y Lx897NHA2UdHn5dYRN26gV+oyuT3AxXo2I8kSCCRFDvAjciVhuonJhyPOfMXz/Kmq7vfcQRRI5O JU4ZjW4QYrHLidddWAWeruoPj0Ismw0fbL1DDxoBKSmF+nQwytV7gfNbHJSjY226BcmI5mr+rDM nSHkN+SrdSsKDkg80dAUjLu9qV9eGQdFeyFE+Hfg5lgb8cly9T2kwSfperWqss4321fUXP X-Received: by 2002:a05:620a:469f:b0:8ee:e011:a77a with SMTP id af79cd13be357-8fa863df021mr885936585a.13.1777597654699; Thu, 30 Apr 2026 18:07:34 -0700 (PDT) Received: from devvm29614.prn0.facebook.com ([2a03:2880:f814:17::]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8fc2c253264sm18485785a.22.2026.04.30.18.07.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 18:07:34 -0700 (PDT) Date: Thu, 30 Apr 2026 18:07:28 -0700 From: Bobby Eshleman To: Jakub Kicinski Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Alex Shi , Yanteng Si , Dongliang Mu , Michael Chan , Pavan Chebbi , Joshua Washington , Harshitha Ramamurthy , Saeed Mahameed , Tariq Toukan , Mark Bloch , Leon Romanovsky , Alexander Duyck , kernel-team@meta.com, Daniel Borkmann , Nikolay Aleksandrov , Shuah Khan , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Stanislav Fomichev , Mina Almasry , Bobby Eshleman Subject: Re: [PATCH net-next 07/11] net: devmem: support TX over NETMEM_TX_NO_DMA devices Message-ID: References: <20260428-tcp-dm-netkit-v1-0-719280eba4d2@meta.com> <20260428-tcp-dm-netkit-v1-7-719280eba4d2@meta.com> <20260430175724.0c134a0d@kernel.org> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260430175724.0c134a0d@kernel.org> On Thu, Apr 30, 2026 at 05:57:24PM -0700, Jakub Kicinski wrote: > On Tue, 28 Apr 2026 15:42:04 -0700 Bobby Eshleman wrote: > > shinfo = skb_shinfo(skb); > > + if (shinfo->nr_frags == 0) > > + goto out; > > Feels tempting to cover the NETMEM_TX_NO_DMA / NETMEM_TX_NONE > cases here before we even look at the frags? That sounds good to me (had considered it, but opted out cause I felt it might look odd with the switch-case that follows). And I'll address the bug(s) the model called out here/elsewhere too. Thanks, Bobby > > > - if (shinfo->nr_frags > 0) { > > - niov = netmem_to_net_iov(skb_frag_netmem(&shinfo->frags[0])); > > - if (net_is_devmem_iov(niov) && > > - READ_ONCE(net_devmem_iov_binding(niov)->dev) != dev) > > + niov = netmem_to_net_iov(skb_frag_netmem(&shinfo->frags[0])); > > + if (!net_is_devmem_iov(niov)) > > + goto out; > > + > > + binding = net_devmem_iov_binding(niov); > > + > > + switch (dev->netmem_tx) { > > + case NETMEM_TX_DMA: > > + if (READ_ONCE(binding->dev) != dev) > > goto out_free; > > + break; > > + case NETMEM_TX_NO_DMA: > > + break; > > + default: /* NETMEM_TX_NONE */ > > + goto out_free; > > }