From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99B6C1624C5 for ; Fri, 1 May 2026 01:04:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777597467; cv=none; b=t7i1f3oPx8fmgJx7dOIW340VWL2tBdeOsqOHH1Bp0I0B2YtUcJXj1rBe2z0WtKYT9x8BVddaB+Ntv69QoQ/DqgNoZ3NkvWbFZLTw9SsnBMHR+v5a4vMz5TD4bAQlNGvkSBdy+Qh22DE5syUSbPvbX5XOAHCMUjSeoDRjjbUttMU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777597467; c=relaxed/simple; bh=/DJ7wZtMAXQCMxmN4svRwnpE9acNFiZmKF0ZopAdBT0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hL9fEVfjZ+RBFLjKwOV4xcpavuIQvXCaEogJUE1EFKCFO1sR5XOet0x8Yt9D5aOhf2xL9y3+6GVICmkaR7yGGJsoZWPXUTEOPnt1+nOnVyM9JPnlLdecP/ykTN2TO3nVzrmebruULIuu5nUKq9aZl0sSPjEY9lF93HG6TZOnT5A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gdLJnB/9; arc=none smtp.client-ip=209.85.219.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gdLJnB/9" Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-8b038a00370so14156816d6.1 for ; Thu, 30 Apr 2026 18:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777597464; x=1778202264; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YgTjr8+nRWTJvq9pIAhCak7v+aRK5KkPsWEHGXUHTRE=; b=gdLJnB/90EiZQUrzVqnOJC0c+QuyxddLjlh8k7F1508n1zygl8hVdqtrShrPIQIQ8b gLqpZzB+9epM4kJE/vKuE/0633/enY7Z7wEwYE3eV1Xgps5aC3e0NO6RlKV0v85n2Dyx 2oNNNgjc06o8vZCzvFeFvZ/Nu3gfFSvDqsCZU4bIv4k0n7p+H/OucOVw6lXQhL1wbgAY gGyBdHfQjpcOV7zBiG4Hc8bJY23bQulj2jNReUlvMBxY0ro/XWViglGMrDBVGzNXe6ph V2/TqJ5AXddlJEoYTEsUXNHc22vKL0XlaRGOSy6RccIrlU8tStcC1JfbQPjlHQm2oXZ8 0K3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777597464; x=1778202264; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YgTjr8+nRWTJvq9pIAhCak7v+aRK5KkPsWEHGXUHTRE=; b=ZLx6mOO6+dfLIIoLl2P2wTw9LM+l4bq6/X2MUg0VG/ShFuQ+B0se5UGwmEZuIo8mJe HXRIazwvmdnyqyXyQLEarmfCVb/p9zz/ugTj5DtjCbzOFZDzDZPlMmcBt8qTkOTwBqi+ SH0il8OECZPNXwv3aNSGp6ci0k327ekPnKe1MXe6wa0g8CQVJTWpx04nGasvNPnF/7xe DC+VQnnVZhibmKKWw/J9fmyhg2vcK4cs7AQgtw9DknKSbZEXH5uQeMDIqzOZ9Tv7eTP4 ut04akQQ+OPciHYHJqjPls4P6u9io2YUEE/t4uCFDzD5FwAtbx+/d2YhigG37a67MqiL DnOw== X-Forwarded-Encrypted: i=1; AFNElJ99PSnAO9zXb0GK0NDrVgWO2Pw5Kdr5P6lLD3vXtp24zEscR/0v9jqEtAbwvUayawPhTLCaRzaHPpSyGHJtFOs=@vger.kernel.org X-Gm-Message-State: AOJu0YxLcqWvIdc4aHtbLRQD9cyuDTDAaY2rzRMxzZPd6hnrZIv3Urlh NUfozpOWEmS45+5rHvWv6IykzCHAVyYDywepVVmjX1LC9vWee/TDI32J X-Gm-Gg: AeBDiet7OgYiGYZA5IK8cbABoA84Q1962ZWJuYNaTLfE6ix0z7ltMC2RbXC11IjgHrP ZgiBOHbiojbbVul9teZ3Aj+DznIVY6kvdQA+AXtN7p+h4mhjmtaUij5vXDh+GA2rGAj/ONXvMTo pCetuSJWoNvAKE9w4ziSJdSXJ+hpSa5/wMqWnJiAUVEHWjlwD8m/WQI//WvykT5EsQhfVJidGPY 6ER8qsPoWFLhUlPdw3UBC3oOa3Q/+dTHIWUf1IMJkzBfcJJJFIULfeAMpHUnK7UxQSZJ+BDrSgk jmNFYGkXrY+6hX9+nXhR9aEppKuHGQ6q0UrTIR8f5jUcZlB0F6lR2CLKbrXO5q8KgZQRgCVceIn 255y4pfnYE9fRnADdVQCVJ2Dmy6wrbSz+tvk28F1aoda2+Ndr69+vP+dYwlkKu+hT6fl/I39yKT i0adcQ752VDmz9nTw5IjwLXGyvtww36spmZQ6x7P5Srj4vQU5JuEbcezfXBQ== X-Received: by 2002:a05:6214:4710:b0:8b0:2dc3:319f with SMTP id 6a1803df08f44-8b544de5bdcmr13924316d6.2.1777597464476; Thu, 30 Apr 2026 18:04:24 -0700 (PDT) Received: from devvm29614.prn0.facebook.com ([2a03:2880:f814:31::]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b53d6442d0sm7643106d6.46.2026.04.30.18.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 18:04:24 -0700 (PDT) Date: Thu, 30 Apr 2026 18:04:15 -0700 From: Bobby Eshleman To: Jakub Kicinski Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Alex Shi , Yanteng Si , Dongliang Mu , Michael Chan , Pavan Chebbi , Joshua Washington , Harshitha Ramamurthy , Saeed Mahameed , Tariq Toukan , Mark Bloch , Leon Romanovsky , Alexander Duyck , kernel-team@meta.com, Daniel Borkmann , Nikolay Aleksandrov , Shuah Khan , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Stanislav Fomichev , Mina Almasry , Bobby Eshleman Subject: Re: [PATCH net-next 00/11] net: devmem: support devmem with netkit devices Message-ID: References: <20260428-tcp-dm-netkit-v1-0-719280eba4d2@meta.com> <20260430175945.476734ca@kernel.org> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260430175945.476734ca@kernel.org> On Thu, Apr 30, 2026 at 05:59:45PM -0700, Jakub Kicinski wrote: > On Tue, 28 Apr 2026 15:41:57 -0700 Bobby Eshleman wrote: > > net: add netmem_tx modes that indicate dma capability > > net: bnxt: convert netmem_tx from bool to NETMEM_TX_DMA enum > > gve: convert netmem_tx from bool to NETMEM_TX_DMA enum > > net/mlx5e: convert netmem_tx from bool to NETMEM_TX_DMA enum > > eth: fbnic: convert netmem_tx from bool to NETMEM_TX_DMA enum > > netkit: set NETMEM_TX_NO_DMA for unreadable skb passthrough > > net: devmem: support TX over NETMEM_TX_NO_DMA devices > > I think it looks reasonable over all, but the assumption that rx lease > implies tx queue does not seem great. Sounds like Daniel has that part > covered tho :) Indeed, with TX leasing this becomes much nicer. > > When you post v2 - you can squash the driver patches into patch 1. Will do! Best, Bobby