From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02982C47096 for ; Sun, 6 Jun 2021 17:19:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7164613D4 for ; Sun, 6 Jun 2021 17:19:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229721AbhFFRUu (ORCPT ); Sun, 6 Jun 2021 13:20:50 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:57324 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229474AbhFFRUt (ORCPT ); Sun, 6 Jun 2021 13:20:49 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: tonyk) with ESMTPSA id B92351F42052 Subject: Re: [PATCH] lib: Convert UUID runtime test to KUnit To: David Gow Cc: Christoph Hellwig , Andy Shevchenko , Linux Kernel Mailing List , Brendan Higgins , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Shuah Khan , ~lkcamp/patches@lists.sr.ht, nfraprado@collabora.com, leandro.ribeiro@collabora.com, Vitor Massaru Iha , lucmaga@gmail.com References: <20210605215215.171165-1-andrealmeid@collabora.com> From: =?UTF-8?Q?Andr=c3=a9_Almeida?= Message-ID: Date: Sun, 6 Jun 2021 14:18:48 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Às 21:54 de 05/06/21, David Gow escreveu: > On Sun, Jun 6, 2021 at 5:52 AM André Almeida wrote: >> >> Remove custom functions for testing and use KUnit framework. Test cases >> and test data remains the same. >> >> Signed-off-by: André Almeida >> --- > > Thanks! It's always exciting to see more tests using KUnit. > > Note that the names here (filename, suite name, and Kconfig entry > name) don't match what we usually recommend for KUnit tests: > https://www.kernel.org/doc/html/latest/dev-tools/kunit/style.html > > Given that this is an existing test, it is definitely okay to keep the > old names if you think it'd break something, but if there's no issue > it may be worth renaming them. The test suite name (which is new > anyway) ideally shouldn't end in "-test": just "uuid" is best. > > I know there are quite a few existing tests which don't adhere to > these perfectly yet, but ideally new ones will if it's convenient. > > Otherwise, this looks great. I've run it here, and it worked well and > picked up on any deliberate errors I introduced. > > So this is > Tested-by: David Gow Thank you for the feedback :) I'll submit a v2 applying your suggestions. > > Cheers, > -- David >