From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CADBB1EB5FD for ; Wed, 13 May 2026 15:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778687764; cv=none; b=RLpD4oJukkQmrZ3aggR54jmg9u6UCWe+AZ0MoLACqabMn6U0TjGWRoBi6oBP1Wqn3BkAbGrMCCWDG1pZA2GU7KQOrt4J1Q7R9yd8g3bBnajEBUJh6NL0FhuhwJCSviWC0HKX83c40ixesRz5q/+SKx0rmVveFMpgLmYkXiqEuqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778687764; c=relaxed/simple; bh=n7Ws94gxeaCRFtf3TF8uVIiRZHvc/e1UvuieOeTg8/g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZeZVRBJ5T0Y5J7WnkIxLTxsnN2KSi2O+v4gf2jJYyAw+MPZgIWXqDOpn1I8zbDTe7VFw+gXnMQ27/q4J0Ejz4m0o6Dbc+DFMMpNvuFVrWWPB+65xe5gYB4fwWmPEo/UhSUMvbQUfv2d/2TNLVyn5UcS0y5ez2ed+AJMv1vEw/xs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Y878hePz; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y878hePz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778687761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DfaTsBVptCeA0QuBzTDUKxyGUiuTsN+d73fyP8TMEMg=; b=Y878hePzfJ/rjbt2Nx7JNDmJ7c561mK92u7Td8pbgj0YV9S0airKdVNZC2eyk4oj1/3cPA QEKNgzu7R88O7h6vwToPyLzYIHkM3+eqBd6mfHN2hUuCsklBdDB+nPM9MfxF/glq2vMJY1 VuLPRxhM9OknyloXWzo8qizwiZ0j/P0= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-546-VDKQFgU_MDuDVSxLGFMDEw-1; Wed, 13 May 2026 11:55:58 -0400 X-MC-Unique: VDKQFgU_MDuDVSxLGFMDEw-1 X-Mimecast-MFC-AGG-ID: VDKQFgU_MDuDVSxLGFMDEw_1778687756 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4A549195605F; Wed, 13 May 2026 15:55:56 +0000 (UTC) Received: from thinkpad (headnet01.pony-001.prod.iad2.dc.redhat.com [10.2.32.101]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D1A831953947; Wed, 13 May 2026 15:55:52 +0000 (UTC) Date: Wed, 13 May 2026 17:55:49 +0200 From: Felix Maurer To: Qingfang Deng Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , Sebastian Andrzej Siewior , Petr Machata , linux-kernel@vger.kernel.org, linux-ppp@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net-next] selftests: net: add tests for PPPoL2TP Message-ID: References: <20260508032158.67887-1-qingfang.deng@linux.dev> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On Sat, May 09, 2026 at 09:13:58AM +0800, Qingfang Deng wrote: > On 2026/5/9 1:26, Felix Maurer wrote: > > Is there a particular reason to create the test setup with a netkit pair > > instead of the more standard veth pairs? > > L2TP does not need an outer ethernet header so I choose netkit instead of > veth. I see, thanks. In my opinion, sticking to the same environment setup for as many selftests as possible, i.e., using veth pairs everywhere, has more benefits in terms of maintenance of the test than leaving out the ethernet header has. Also, while I understand that selftests are only supported on systems that run with the respective selftest kernel config, I still think it's good to stick to veth as it is probably available in more kernel builds (think resource constrained envrionments, older kernel versions, etc.). But in the end, it's up to you and the maintainers. However, if you stick with netkit, please name the interfaces explicitly and don't rely on the current auto-assigned name of the peer interface. Thanks, Felix