Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Shuah Khan <shuah@kernel.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	Matt Turner <mattst88@gmail.com>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-alpha@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Subject: Re: [PATCH v2] tools/nolibc: add support for Alpha
Date: Sat, 1 Aug 2026 21:20:35 +0200	[thread overview]
Message-ID: <am5HA7UbmUEEChZc@1wt.eu> (raw)
In-Reply-To: <20260722-nolibc-alpha-v2-1-4970e48eb7bf@weissschuh.net>

Hi Thomas,

On Wed, Jul 22, 2026 at 12:07:05AM +0200, Thomas Weißschuh wrote:
> A straightforward new architecture.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Only tested on QEMU so far.
> Testing on real hardware would be very welcome.

I'd love to, but last year I could fix my serial port (replaced the chip
on the motherboard) and the new one died a few minutes later :-(  I'm
starting to seriously suspect a flaky PSU that doesn't regulate its 12V
output well and that is progressively killing the mobo.

(...)
> diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
> index 996e8d13508e..66accf99f560 100644
> --- a/tools/testing/selftests/nolibc/nolibc-test.c
> +++ b/tools/testing/selftests/nolibc/nolibc-test.c
> @@ -756,6 +756,10 @@ int run_startup(int min, int max)
>  	/* checking NULL for argv/argv0, environ and _auxv is not enough, let's compare with sbrk(0) or &end */
>  	extern char end;
>  	char *brk = sbrk(0) != (void *)-1 ? sbrk(0) : &end;
> +#if defined(__alpha__)
> +	/* the ordering above does not work on an alpha kernel due to STACK_TOP != TASK_SIZEi */
                                                                                   ^^^^^^^^^^
I suspect this trailing "i" is a leftover from an attempt to switch vi to
insertion mode :-)

Otherwise, while I'm not competent on the alpha side, it looks clean from
the nolibc perspective, thank you!

Acked-by: Willy Tarreau <w@1wt.eu>

Willy

  reply	other threads:[~2026-08-01 19:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21 22:07 [PATCH v2] tools/nolibc: add support for Alpha Thomas Weißschuh
2026-08-01 19:20 ` Willy Tarreau [this message]
2026-08-01 20:14   ` John Paul Adrian Glaubitz
2026-08-01 20:40     ` Michael Cree
2026-08-02  7:06 ` Magnus Lindholm
2026-08-02  7:35   ` Thomas Weißschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=am5HA7UbmUEEChZc@1wt.eu \
    --to=w@1wt.eu \
    --cc=arnd@arndb.de \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=mattst88@gmail.com \
    --cc=richard.henderson@linaro.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox