From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD321258EFF for ; Fri, 31 Jul 2026 00:18:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785457083; cv=none; b=WMrYsmZ8joSJNdp/fJudTJMrAdNNCyDRfutQ8Je+Gj0CIDHbmlc23+zh7Ak8IMTKusgUlER6j97Bcb2NaHcEJwf/dpu7yHcM/LRNwStUTS4d4LoVljRZkDixYC/01KtedXp9JIXerauj/KQRAOcEBG0cii7sgeu7giHinpPMNVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785457083; c=relaxed/simple; bh=szGFnTCsakcmVQdQfLLQUpOJjjCAEkdLGZEZAc2bHME=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=vGnLZq5n1G2am26lFxXwKZMj/hrvaeG30zhLLiKXqhg7wSHUOC0PieR1Qd5WJcotZUIyhY7F5UvqIeplQW+9lMM2KSUCR4HmmcajH9KmdjOHYTM/F99c1jhw/OASoqWhwz0DGtJ+qLB7C2TAiOGaJj8IMTSI/icXD4GjrKJdYPk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wv6zoMeH; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wv6zoMeH" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2cad8076b01so4005735ad.2 for ; Thu, 30 Jul 2026 17:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785457079; x=1786061879; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=LBitaL1RUUQqXSfqSECtyVEDWdgVsoCHsw/mJvM7Qu8=; b=Wv6zoMeHF+IhWXRw8nHC9HMzFWrtIHGy/ISdE7yIGDPSRfEUQrXXTmmb3b+n/Zr7RX IC56t6eFGPlBdh2maiUx1VESxsvy0a9EFzzgvfBnRwfz3OgaUVVwU4SE63RTD1KtSjnx 8J9Dnip4cmvzMDTVa0dbrmPFzcaoy+HB8btQdyic0uTGjcLcOd6cf/8HyeQtyJBWZ9Em x/Lxzx4pq3BvBqignqnUbo25NKyDMi8o2Xu1SVAzFgDtkYb1KW9enJFh+h9hEwsjIjy5 IrzKoO/ETSWai9oCAwVv9fgZWIFfQCaFqmMcvk2OhSo/SFLYTZRroLHiEUga86Rot5Na VfIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785457079; x=1786061879; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LBitaL1RUUQqXSfqSECtyVEDWdgVsoCHsw/mJvM7Qu8=; b=itls52Sa+Uugqnsc5NtQYJF4NqiW9g7RPKogmwxSNbyXr01hyMZnwgVaSyQ0c7X8nD qrKOI5Ke0JfC3aA5Fianzk42jo4Q6nBBZCZjfSn8cwoAy/zRq3ZNSlDaDy2MF0YC4eil CG3wNl334TSu0nlQ1ftyEyB2UzvW3qhsxBf3yp7THkabcTheheWNNXhMRiFOGEGtGX2S jfSX8DX7T1ncMC6nUx3liYsMaGLZ0meD5Yuzq+1ge7qqpYeJA1D7ZiR9o4Ruz/PzKPOm MAlrXvEoqL9LKfWNgg6XcGmJexF7Bm4p0sHsbRNm6qfjXSNUCM6Ywb6VPPmPTnVmKY7K g+bQ== X-Forwarded-Encrypted: i=1; AHgh+Rrr2z6Js64HySlumS9JRHvsNq2JMED5WMgd17t9zSCTvvr0SutRU6PCNaVqR38fCr4ZdpX+EbsumH2GWqHDQ0g=@vger.kernel.org X-Gm-Message-State: AOJu0Yyk90MJyCdZ+C4Z7AEvVyL71cfUwwtdD4kiS2ijuuvErNsun3rF ZG8lX+JQkwww67np8ECUeG380v2MElkOdpUMsxGKjCdSFuljwTVUxvE6 X-Gm-Gg: AR+sD12Wx3XRjqzJrd3Vp2wQdfOOYu2r0vHO68GqFmTEnx0rXMaWZw+aMR67PYcEhZ9 zwqg8WawtjIZat6fWDJc8+wQuW3/2kyrfwZeOlSyyQukGa2TeodP1nB2tEMHx9309IDV143OV1j vzSWQdaLiD1IVRMveIg3KBAMAitXVz/R6ByI7NxMp0Kr5XGlwmgy3eq95/mEkGtteBBEhdIqcex mMeMp5CZCJPOmHqwt2CpepYK6FG5hAoCMeqT6YfmU8s1yem3ebwvcWSSBArd+s4YvU4L2h1jkt3 qO1sWnhhky4+GFmIITLB5wu0EVQ0yVtap8vXzpwIq8R+3fzgLnfei1XM2gOADSnkj8Yp5jVuZb/ nN93QhzPOQL6y6xOdr8r+tlElwws0G+jTy+5CbqFpGvG9QE4fg4KgJwcA3cS0rMCb9+kvcjd88l a4e0689Yl08viUOmGGFgUA2m7dX9rGApTlDozRsD6h1h5rEBGED14p9vlA6aHkI1ImkoflxOleH NYlMXMqibw= X-Received: by 2002:a17:903:4585:b0:2cf:bfbb:61e2 with SMTP id d9443c01a7336-2d046eadd5emr478805ad.39.1785457079096; Thu, 30 Jul 2026 17:17:59 -0700 (PDT) Received: from devvm29614.prn0.facebook.com ([2a03:2880:ff:70::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022c8b9aasm32885005ad.50.2026.07.30.17.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 17:17:57 -0700 (PDT) Date: Thu, 30 Jul 2026 17:17:55 -0700 From: Bobby Eshleman To: Jakub Kicinski Cc: Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Andrew Lunn , Gerd Hoffmann , Vivek Kasireddy , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , Shuah Khan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, linux-kselftest@vger.kernel.org, sdf@fomichev.me, razor@blackwall.org, daniel@iogearbox.net, almasrymina@google.com, matttbe@kernel.org, skhawaja@google.com, dw@davidwei.uk, Joe Damato , Bobby Eshleman Subject: Re: [PATCH net-next v6 3/3] selftests/net: devmem.py: add check_rx_large_niov Message-ID: References: <20260724-tcpdm-large-niovs-v6-0-7975f62cdfbb@meta.com> <20260724-tcpdm-large-niovs-v6-3-7975f62cdfbb@meta.com> <20260729191649.55ab7942@kernel.org> <20260730151433.6f71258e@kernel.org> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260730151433.6f71258e@kernel.org> On Thu, Jul 30, 2026 at 03:14:33PM -0700, Jakub Kicinski wrote: > On Thu, 30 Jul 2026 14:39:37 -0700 Bobby Eshleman wrote: > > Poking around, it looks like 231.1.167.0 and above should support > > everything, so fw should be okay AFAICT. > > > > Looks like the config is missing CONFIG_NET_DEVMEM and CONFIG_UDMABUF? > > Ah, damn, you're right. I grepped for DEVMEM and didn't look closely on > a hit. Turns out there's a non-NET DEVMEM, too. Ha yeah, I kind of did the same at first too, had to grep for CONFIG.*DEVMEM in net/ to convince myself. > > Could you send a patch to add the missing config options to > tools/testing/selftests/drivers/net/hw/config ? > > Can be separate or part of this series, doesn't matter. SGTM. > > > Sorry, took me a while... was certain it was a bug in my code. > > > > Not the failure here, but wondering if this was on ARM led to seeing > > that 16K hardcoded rx_page_size in run_rx_large_niov() may fail on ARM > > with 64K pages because it will fail the IS_ALIGN(16K, 64K) check... > > Ah, good thought. We've been meaning to get an ARM64 server for NIPA > (our current server supplier is out). If it's not too hard could be nice > to guard against that. But also not a huge deal for HW tests if they > fail instead of skipping. Sounds good, I'll throw in a skip into require_devmem() if rx_page_size is passed in and doesn't pass the alignment check. Best, Bobby