From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E531345749 for ; Thu, 13 Aug 2026 18:04:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786644243; cv=none; b=RQQeHrg5PFJR9AnwRKtN0dHPLWnVaCoAmUlRTD0vhQ/yQx89RMGooV1wuGHUGrSW6gLQ4cK5hlEIM7XZAXDaaiAgXLR1iwlvmH81WWM3jqnbFe7z5kheQNPO8lvMvBZ76L+L03C0JhS/Ve4H0CMEs7iJKyy3P7h1w4K9q+oNCzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786644243; c=relaxed/simple; bh=NtvaBNSVoK7oKWXFv49lETLnLBGunHM+uU1K7pNhXYI=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hLEZXsHdhvRfvvwtyQeMqswqnICdE+dBNN0euyN6kS3zEVtZroxnPqqFberqeO/ENNPYuGFx5P+oZ5ZnrH1E4Azn2DrcVhNctZa1neLCWJkBY4OjNXjSaKfGqYAAMWgO1jaykQqODF7u4Crje3XsuQPmCnRDddaG1q29MAnMV5U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SXyskpls; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SXyskpls" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-47de008b020so40610f8f.1 for ; Thu, 13 Aug 2026 11:04:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786644240; x=1787249040; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:date :from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=zr5I5FYVqXv9F6tHOsf6hEzeaNxXhC/qXHtmdMQmKGg=; b=SXyskpls04g62dMGJtIB7/xhakVUQiN9nB9D7eqYhwWy4lFK/77gjw7B+vXL8poQVT EviYGYlOOhP2nB9KvC+kRDxVFhUnGf4dHqtLMKyELd9bWRuvgzQ67CGdpgb4iJHOM/Ln 1yka1frWsL6JAbGdi9xSEcs8A1tHcO8c4jG40AhAtr8mEkn4VhO+Y0lEKo0C+AHBIRvU V7lAlRdZBJh2RdN8N8p0rhR6NiqKhUTh9vSiEBlI2E7vvmFSCe2yRS0j6BN6LnIiT3Ne twXCQS9mvJtTRNlvTpQrzr5n7k5yE1yun4JW88NAv8B97wvsi1szsOab0ZeUJC11KGZx hBdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786644240; x=1787249040; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:date :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=zr5I5FYVqXv9F6tHOsf6hEzeaNxXhC/qXHtmdMQmKGg=; b=NjGctTDplGmQrJ/rtpE4ZcB37JxpbaGTVCZJZfVhE/5gFDHN5l/6NAXq//9ieb1PHb r9ZjaTwYfjaR3KxLNsujZDgSvwOFTqJbkMsuTH2K6uYXF97YX9CHYsWbvFRAY76m4x/R RNj7Ie5LWkXl0mZO1YoabBQQNqw8EPwN/OexEsexPXbSHjD8L9pRqobRx0AdnnUPfwYT slOWtA7igvA3ZbpYDOzGTbSl5B7Dw01RzcyiFGJ5Ykr69+p5Mit5DYZzY7SEUbOPbcMY N3vTMX7sXYl+vyBbAB/MImsGn2SiUBjgGmU4x7/nJxEvnknd6atAgmZzJXB4JdXMEOl/ IZbw== X-Forwarded-Encrypted: i=1; AHgh+RohfXG5V8XN5hzLFCvfSagL2nLZAmWvjoGbygqD/7NnxX9Ie01oWzq+pcf5d5VlnTupropwthaKsCOkZ/ZFm2I=@vger.kernel.org X-Gm-Message-State: AOJu0Yzx0PTS+z3d8mKY71Gdy644JA/vcIcEd4cYO7nmvvkYmOiEmyLu O+GGWMmoVe9berE1f8QKdmKUIYq3sasg1xpvwRhzKk+Q7WGj+CU9nuq1 X-Gm-Gg: AR+sD10hsIEI1a7Hc6yA/iO0AlbbpTdbyQOzfGEo5IzW06K6ySOV6fJh7TACJ9huLZa urnSPpqYxBLOXtRzZPjj1VfhWWhauKJGgtgJK7P+JRaO4zqJKYX85RVooPrDRWoiujcRH1OO4v/ kV9UFoeGDu1GFhq+hJnOBQnoWOhvMbvJuzo5/YgpMe24BS9zymkJAYUIFZlppCZ/GRAVhX+l0wt 7wTQgR47wsIrJigepWxbuErx/C8/wQ34jWf+7K7NeadCwiIIKQ5f7MZKxQFwcV4RCBEEPwbvZsU R9E1iBk5TebB15+5M02gmIGIRgUOyyWeqsWQJJKI2+OHOCYdTWv3eR++i1Ak8BcFPQBMhzh8IxQ biIhlAexUbyXBflLUvBcdbkc+uMnyW168IQfUXMIm4ufOMvfyB1JyGkHRG/u5GLQ/R8pa8kZFM7 OGv6x7uC34hORhfLLx82+YJir3SrZ/Wxb6S2wQ8yFQLI7+Ss8= X-Received: by 2002:a05:6000:61d:b0:481:5a46:dbef with SMTP id ffacd0b85a97d-4815a4e72admr11372177f8f.5.1786644240265; Thu, 13 Aug 2026 11:04:00 -0700 (PDT) Received: from krava ([176.74.159.170]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2cc811sm1004573f8f.33.2026.08.13.11.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 11:03:59 -0700 (PDT) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Thu, 13 Aug 2026 20:03:57 +0200 To: Andrii Nakryiko Cc: Leon Hwang , bpf@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Emil Tsalapatis , Ihor Solodrai , Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH bpf-next] selftests/bpf: Move tracing_multi_bench_attach to bench Message-ID: References: <20260804154813.90795-1-leon.hwang@linux.dev> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Aug 04, 2026 at 03:40:30PM -0700, Andrii Nakryiko wrote: > On Tue, Aug 4, 2026 at 8:48 AM Leon Hwang wrote: > > > > In CI, the tracing_multi_bench_attach test could cost >10s, which should > > be avoided in daily CI running. > > > > ./test_progs -t tracing_multi_bench_attach -v > > WATCHDOG: test case tracing_multi_bench_attach executes for 10 seconds... > > serial_test_tracing_multi_bench_attach: found 40163 functions > > serial_test_tracing_multi_bench_attach: attached in 9.367s > > serial_test_tracing_multi_bench_attach: detached in 1.798s > > #546 tracing_multi_bench_attach:OK > > > > Since it is for benchmark attachment of tracing_multi link, move it to > > the generic bench framework. > > > > ./bench tracing-multi-attach > > Setting up benchmark 'tracing-multi-attach'... > > tracing-multi-attach: found 40166 functions > > tracing-multi-attach: attached in 9.278s > > tracing-multi-attach: detached in 1.836s > > > > Assisted-by: Codex:gpt-5.6-sol > > Signed-off-by: Leon Hwang > > --- > > tools/testing/selftests/bpf/Makefile | 2 + > > tools/testing/selftests/bpf/bench.c | 2 + > > .../bpf/benchs/bench_tracing_multi_attach.c | 177 ++++++++++++++++++ > > .../selftests/bpf/prog_tests/tracing_multi.c | 125 ------------- > > 4 files changed, 181 insertions(+), 125 deletions(-) > > create mode 100644 tools/testing/selftests/bpf/benchs/bench_tracing_multi_attach.c > > > > Jiri, are you ok with not exercising this logic regularly? > > but also hm, is 10 seconds expected? sorry for late reply, I overlooked this one the 'commited result' is around 1.2s.. will check serial_test_tracing_multi_bench_attach: found 51186 functions serial_test_tracing_multi_bench_attach: attached in 1.295s serial_test_tracing_multi_bench_attach: detached in 0.243s thanks, jirka