From: Martin Kaiser <martin@kaiser.cx>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, oe-lkp@lists.linux.dev,
lkp@intel.com, kernel test robot <oliver.sang@intel.com>
Subject: Re: [PATCH] selftests/ftrace: allow relative paths in eprobe test
Date: Tue, 4 Aug 2026 21:51:01 +0200 [thread overview]
Message-ID: <anJCpUP4sGnggyOY@akranes.kaiser.cx> (raw)
In-Reply-To: <20260723092654.12f7be2910e3e16259c61125@kernel.org>
Thus wrote Masami Hiramatsu (mhiramat@kernel.org):
> On Tue, 21 Jul 2026 22:05:59 +0200
> Martin Kaiser <martin@kaiser.cx> wrote:
> > The add/remove eprobe test installs an eprobe for the openat syscall,
> > runs ls and checks the filenames that were opened.
> > Commit 206b25c09080 ("tracing: eprobe: read the complete FILTER_PTR_STRING
> > pointer") fixed access to some string fields in eprobes. This allows for
> > dereferencing more filenames. In some cases, the log now shows a file
> > with a relative path instead of "(fault)". A relative path makes the
> > test fail.
> > Relax the filename checks to fix the test. Allow shared libraries and
> > locale configs that use a relative path.
> Hmm, should we check this "nocontent" ? This change seems a bit fragile.
> I think we should use another syscall to make sure getting filename
> correctly. At least this point, removing nocontent check will be better.
I've just sent another patch that uses chdir instead of openat. For chdir, we
know which filename we'll see in the logs and we can use a simpler filter.
Best regards,
Martin
next prev parent reply other threads:[~2026-08-04 19:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 20:05 [PATCH] selftests/ftrace: allow relative paths in eprobe test Martin Kaiser
2026-07-23 0:26 ` Masami Hiramatsu
2026-08-04 19:51 ` Martin Kaiser [this message]
2026-08-04 23:08 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anJCpUP4sGnggyOY@akranes.kaiser.cx \
--to=martin@kaiser.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mhiramat@kernel.org \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox