From: Gregory Price <gourry@gourry.net>
To: Christian Loehle <christian.loehle@arm.com>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org,
Rama Krishna Katta <ramakrishna.katta@arm.com>,
Thomas Gleixner <tglx@kernel.org>,
Gregory Price <gourry.memverge@gmail.com>,
Kees Cook <kees@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>,
Gabriel Krisman Bertazi <krisman@collabora.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] selftests/syscall_user_dispatch: Skip tests if SUD is unsupported
Date: Wed, 26 Aug 2026 18:00:49 -0400 [thread overview]
Message-ID: <ao9hq0iaN2leGrpf@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <65c35ccbc7db2de2cb600439874e585775362580.1786965107.git.christian.loehle@arm.com>
On Mon, Aug 17, 2026 at 12:16:10PM +0100, Christian Loehle wrote:
> Syscall User Dispatch is unavailable on architectures without generic
> syscall entry. Such architectures return -EINVAL for otherwise valid SUD
> prctl requests, causing sud_test to report failures.
>
> This also prevents bad_prctl_param from providing useful coverage. The
> unsupported stub returns EINVAL before argument validation, so valid
> operations fail and requests expected to fail with EFAULT return EINVAL.
>
> Probe SUD with a valid disabled configuration at the start of each test
> and skip when the kernel returns EINVAL. Preserve failures for unexpected
> errors and continue to run the full test on supported kernels.
>
I suppose we should at least be testing for the EINVAL when not
supported, so this makes sense vs skipping the entire suite.
> Fixes: 179ef035992e ("selftests: Add kselftest for syscall user dispatch")
> Signed-off-by: Christian Loehle <christian.loehle@arm.com>
Reviewed-by: Gregory Price (Meta) <gourry@gourry.net>
next prev parent reply other threads:[~2026-08-26 22:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 11:16 [PATCH 0/3] selftests: Skip SUD tests when unsupported Christian Loehle
2026-08-17 11:16 ` [PATCH 1/3] selftests/ptrace: Skip get_set_sud if SUD is unsupported Christian Loehle
2026-08-26 21:58 ` Gregory Price
2026-08-17 11:16 ` [PATCH 2/3] selftests/syscall_user_dispatch: Skip tests " Christian Loehle
2026-08-26 22:00 ` Gregory Price [this message]
2026-08-17 11:16 ` [PATCH 3/3] selftests/syscall_user_dispatch: Skip benchmark " Christian Loehle
2026-08-26 22:01 ` Gregory Price
2026-08-26 14:56 ` [PATCH 0/3] selftests: Skip SUD tests when unsupported Christian Loehle
2026-09-04 16:45 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao9hq0iaN2leGrpf@gourry-fedora-PF4VCD3F \
--to=gourry@gourry.net \
--cc=christian.loehle@arm.com \
--cc=gourry.memverge@gmail.com \
--cc=kees@kernel.org \
--cc=krisman@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=ramakrishna.katta@arm.com \
--cc=shuah@kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox