From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-85.mta0.migadu.com [91.218.175.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF6E02BE621 for ; Fri, 21 Aug 2026 06:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.85 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787294753; cv=none; b=m3FzE7QMvO3uXNOh52DYBDU4/PWT1NnNBKoPoXJ7FlOxAabBusXC7QWJ/N9Vr8JD8WqhN/ZkZRP7Ktp6nwJlaT0WCBNJqGtpXfcIfvNs9aqCecoTLvykKBAw53pxm7Tl1+nYEJqlMM07RucBgRsRqEDzAPqTIXLVB8tq41RSJKk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787294753; c=relaxed/simple; bh=oh7TKbdjsLGFrOGUzkUpcfYdM4crWdMPv2+Mpe2CB0I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H2/aSKgCdE3Oj0JmlgbwNradZkkQOuXQ8AZTygSo6n9ld2v6TLU9Nv8tZn4dU0xTjmxW6byAaSAn0H/ROunML2NPlZQjKnuNPsKVdxfU+kONR3AwyrrO+Z8xkIrMJGgv5nW2Cz48hRRjK3woTDG4SKyEZUB8OjLYAKTegUxHFFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=TBAUlwWl; arc=none smtp.client-ip=91.218.175.85 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="TBAUlwWl" X-Envelope-To: linux-kselftest@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=oh7TKbdjsLGFrOGUzkUpcfYdM4crWdMPv2+Mpe2CB0I=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787294748; v=1; x=1787899548; b=TBAUlwWlj+Usm+jBHCDXjojIGK8dYCA7OtLhKfeQYEuK9vvMwTpGQz4cvwU+pT1tNf8KnKT3 aUKCucxu6xbqONXpbWrt8dRGkcM5+pprQlI0wvEiOg5OwznAKJs5HQINIshm29cMC7w2upteDZC czfz8nolYDAOXDV0ffQtgMD4= X-Envelope-To: linux-kselftest@vger.kernel.org Received: from fedora (203.175.12.240) by smtp.migadu.com with ESMTPS id c12d4a8015f16231; Fri, 21 Aug 2026 06:45:48 +0000 X-Mizu-Trace-ID: c12d4a8015f16231 X-Migadu-Flow: FLOW_OUT Date: Fri, 21 Aug 2026 14:45:40 +0800 From: Hangbin Liu To: Qingshuang Fu Cc: Andy Whitcroft , Joe Perches , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , SeongJae Park , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Qingshuang Fu Subject: Re: [PATCH net v2 0/2] selftests/net: fixes for fin_ack_lat Message-ID: References: <20260821030922.1123754-1-fffsqian@163.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260821030922.1123754-1-fffsqian@163.com> On Fri, Aug 21, 2026 at 11:09:20AM +0800, Qingshuang Fu wrote: > From: Qingshuang Fu > > This series fixes two bugs in the fin_ack_lat self-test. > > Patch 1 fixes the swapped kill() arguments in sig_handler(), so the > server actually forwards SIGTERM to the client. It also makes the > wrapper script's cleanup tolerant of ESRCH, since the client may now > exit before the kill command reaches its PID. > > Patch 2 adds a missing fork() error check: on failure the code falls > into server()'s infinite accept loop, producing empty output that the > wrapper script treats as a passing test. > > Qingshuang Fu (2): > selftests/net: fix kill() argument order and wrapper cleanup in fin_ack_lat > selftests/net: check fork() return value in fin_ack_lat > > tools/testing/selftests/net/fin_ack_lat.c | 5 +++- > tools/testing/selftests/net/fin_ack_lat.sh | 2 +- > 2 files changed, 5 insertions(+), 2 deletions(-) > --- > v1: https://lore.kernel.org/all/20260817091017.281104-1-fffsqian@163.com/ > > v2: > - Split into two patches > - Add shell cleanup tolerance for ESRCH per Sashiko-AI review > - Add missing fork() error check per Sashiko-AI review > -- > 2.25.1 > LGTM, for the series Reviewed-by: Hangbin Liu