From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f0.google.com (mail-pj2-f0.google.com [74.125.227.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 375DC4F3923 for ; Tue, 29 Sep 2026 23:34:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.128 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790724849; cv=none; b=BhTbxG0PsT3D6PAqrYl9lGoirLrab9ZCjZgDKBrJulunLPoxBmQXrOp8SZGe6V89d6pv5IeTHaHrbqqYL5cBAG9dBmLuTyci8IoLY/2m3v7yNyw5jjeYm+JVkl+h6GWtMoUHLPBp1RkwJxzEYFvpURMp6SQt02CJy6cacMTRBEg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790724849; c=relaxed/simple; bh=62yKmzlB48V/zDch+coTOsu7NKNMzjyVyqGeD4YT6bk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DQedlq6jYuE5NDOt5tbuB/063w1mAT9rbguzpzyRS/8RM8AaUcyoJeZ5n7dXwAMhogspUvyWClF2Xi+LiqRey4P3i8pLxu5WU0kgJ7Nw6I6a/FHDZ/wsVy+zIvlYDvVBiskPTWW0zVM8eWGT8V2LN+9WBDB1sfS3FQfKOF5+Sv0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MbxY+7Uy; arc=none smtp.client-ip=74.125.227.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MbxY+7Uy" Received: by mail-pj2-f0.google.com with SMTP id 98e67ed59e1d1-3a476ee8669so749874a91.0 for ; Tue, 29 Sep 2026 16:34:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790724847; x=1791329647; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=OLCTeGtvRgnZW2htU8ZCF1G66Q5YNndHNz4a4qiAYDs=; b=MbxY+7UywbjixXwuxgYlzxpYowIkZZUO+vUmzy8Pu9ocGm6RN8It7CyKlRaQFh3Bts xhym4/VPl8hxrKMRCgrbiAEJ0T7i5oX/Z2nfU8ay8Qk3JOl2JOLjguS5749gYNmO8yjk gZQXRua9hdwFncx08ExwjQ+NqukrTFoNcvjnMMxA+SWR8apXbePOPRr1bqPmW9v7NPgh ZMvbI3fWJf+HKz22TyN9q3pEjFmSHQV7MhLOWOrZwYavSupue6ojFhjRGFGKDQXi8msP C0JSRPYFRZuhDDBPpB0LpLT5RBCe5DP9xyUkexLLt5Jmc9ehuJuGusVMG3BCfyWljqfl 8TLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790724847; x=1791329647; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OLCTeGtvRgnZW2htU8ZCF1G66Q5YNndHNz4a4qiAYDs=; b=phvvRmar1K+f5J5CiSLgs+4ulKXy6JHvZqfLmMkla9qhvcvqUn++CA0F/l1S11co+S 5goXugZpvP8HJQ4VQ4XmCtzk4xG+6SmCMcR8SozrhIsttzlzemXWAotvWjaJN2WPR1+0 xRFDUikePW4Wgg0Yu0W8CRtmC8rEUOv2dfcOW/dgFj/4wv7t/XHlBvtDjCipYFOIv6lo 4pGTEPX2T9MDrHrWY9Ezh+zXSkh+Y+xfe9Rvgl8ilulGeMsbfYFbu63XebQOGrgZgUPC 8qVsYm3edH6A26k155rUBbKhDOktyrhpw9+Np9oyghFwKUyRUjv2bpWFivHYvrbgwVz4 vJtw== X-Forwarded-Encrypted: i=1; AKwUvBz7xpZskgBqvfO/yckDEpsn1ImWo10LP69EkBOg/uQHA8AjAUInT7AIHFEmFANJCXuXBxpWUgS8/R+ICBk9a9s=@vger.kernel.org X-Gm-Message-State: AFq9FYJOkgZi9+prcJmyW+5zY7on0S/BXoqR4aZ/knPrwO1tvvEaI3yM qmRY+/VUbB75NyU7In9JwUJnanNb/K0k8JSJDHHyX5I2nQ9cgwJ8dRyW X-Gm-Gg: AYBFou26uszk9/8TeTZgTubbcGOJFkK1jjt+am6E19phLwvDthq3FZY0r/F08t7Eha6 ow6SJ9MF6klq0E8zyVt8F2AwJ4ZFSH1J6yRbIAcZY/iftVZgMDbOo1eWtVDf9+txuNYQVY16AIE rOMCePIITAgoXXVjSIliJM5+NxgD9fr1hq/kvDapu4sDrSlQWNmLNIy4D2xUgihDGM0+NDYJW11 2oWosnpoU95UoL0nVa4pVBZV8D7bMJNLjosfZYIzMYMbRYpyUpTY2zupJF+vXVC+WwU7UKfKdsP ZTax0ENxPVl5aE0w+of3NWWWt7RRAKHRD0TyXHinsWRW5tGYNki9g8Y6vzb07aoMCIJ63iB504M BC3EDjNidrlXWpkgdA44NkX5SnudJtv149GdQ02xo61Sf8kn9PNZ2FaItLh7Fs6ig4GvfYpZ9dj lB8leB5lMVoPhb38ysMxVTwhIDkIIs+fxBtc1NUBoXQLanKmgO6g1NUVlCAxGWIMWl X-Received: by 2002:a17:90b:1d4f:b0:398:9c39:520f with SMTP id 98e67ed59e1d1-3a4bfda445cmr691375a91.15.1790724847432; Tue, 29 Sep 2026 16:34:07 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:4a::]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a4ca448969sm195564a91.12.2026.09.29.16.34.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2026 16:34:06 -0700 (PDT) Date: Tue, 29 Sep 2026 16:32:46 -0700 From: Stanislav Fomichev To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, jv@jvosburgh.net, hawk@kernel.org, sdf@fomichev.me, emil@etsalapatis.com, liuhangbin@gmail.com, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, willemdebruijn.kernel@gmail.com, aleksander.lobakin@intel.com Subject: Re: [PATCH net-next 3/5] selftests: drv-net: check tcp-data-split against an already attached XDP Message-ID: References: <20260928223648.2739371-1-kuba@kernel.org> <20260928223648.2739371-4-kuba@kernel.org> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260928223648.2739371-4-kuba@kernel.org> On 09/28, Jakub Kicinski wrote: > hds.py only ever tested one direction of the rule: with header-data > split on, installing a single-buffer XDP program must fail. The other > direction was not covered at all, and that is the one which was broken > for a program an upper device pushed down - the device was running XDP > but nothing in the core knew, so enabling tcp-data-split underneath it > succeeded. > > xdp_set_hds() covers the direct case, xdp_bond_set_hds() the propagated > one. The latter fails without the preceding fix. > > The bond case is disruptive, it takes the device down to enslave it, and > skips on devices bonding will not take as an XDP slave. > > Signed-off-by: Jakub Kicinski Acked-by: Stanislav Fomichev