Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Sasha Levin <sashal@kernel.org>
Cc: "Shuah Khan" <shuah@kernel.org>, "Will Deacon" <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	"Mark Brown" <broonie@kernel.org>,
	"Ricardo B. Marlière" <rbm@suse.com>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] kselftest/arm64: keep building and installing after a subdirectory fails
Date: Thu, 15 Oct 2026 18:46:05 +0100	[thread overview]
Message-ID: <atERXTfz9xsIuv-7@arm.com> (raw)
In-Reply-To: <20261014200115.1363363-5-sashal@kernel.org>

On Wed, Oct 14, 2026 at 04:01:12PM -0400, Sasha Levin wrote:
> The arm64 suite builds and installs its subdirectories in shell loops
> whose status is that of the last subdirectory. A failure in an earlier
> subdirectory is therefore lost unless FORCE_TARGETS is set, while a
> failure in the last one fails "make all" and, through "install: all",
> drops the installation of every other arm64 test as well.
> 
> Make each loop fail only when no subdirectory succeeds, which matches
> how the top-level selftests Makefile treats its targets, and keep
> stopping at the first failure when FORCE_TARGETS is set. When a build
> report is requested, record each subdirectory as arm64/<subdir> so that
> a partially built suite is visible even though make succeeds.
> 
> Invoke the subdirectories with $(MAKE) rather than make. The command
> line variables already reach them through MAKEFLAGS either way, but
> $(MAKE) lets them use the parent's jobserver and makes -n, -t and -q
> apply to them.
> 
> Fixes: 313a4db7f338 ("kselftest: arm64: extend toplevel skeleton Makefile")
> Signed-off-by: Sasha Levin <sashal@kernel.org>

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

Sashiko had a comment about breakage ARM64_SUBTARGETS is empty. I think
it's a false positive but I didn't check.

  reply	other threads:[~2026-10-15 17:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14 20:01 [PATCH 0/7] selftests: report per-suite build results without failing the build Sasha Levin
2026-10-14 20:01 ` [PATCH 1/7] selftests: keep the build status from wrapping to success Sasha Levin
2026-10-15 18:00   ` Mark Brown
2026-10-15 19:21     ` Shuah Khan
2026-10-14 20:01 ` [PATCH 2/7] selftests: optionally record per-suite build and install results Sasha Levin
2026-10-15 19:22   ` Shuah Khan
2026-10-14 20:01 ` [PATCH 3/7] selftests/futex: report failures of the functional subdirectory Sasha Levin
2026-10-14 20:01 ` [PATCH 4/7] kselftest/arm64: keep building and installing after a subdirectory fails Sasha Levin
2026-10-15 17:46   ` Catalin Marinas [this message]
2026-10-15 18:16   ` Mark Brown
2026-10-14 20:01 ` [PATCH 5/7] selftests/riscv: " Sasha Levin
2026-10-14 20:01 ` [PATCH 6/7] selftests/powerpc: report the outcome of each subdirectory Sasha Levin
2026-10-14 20:01 ` [PATCH 7/7] selftests/sparc64: report failures of the drivers subdirectory Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atERXTfz9xsIuv-7@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=rbm@suse.com \
    --cc=sashal@kernel.org \
    --cc=shuah@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox