From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.138 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792725333; b=AbayQRtXV/I/w7RDnKR2yDf7rq2mBMsPrqb+PZLZ0ICIkxxE8IEJhfXeXmq7BX/YGQgu PKZlokASnJrUOSUSECgUWKDFc6TD9qCXYQLy4ZJkLgd7mqMAtiVYI6B+LR6I0q2V3L7Pf 74Z9rol6W6KvrHboceDLDKCCokkVdGBjWFYQAN49dB1fROt/LLh4Mnhtb9QJYhETnRVKN 4i3becev1k03mwzAaT+IIdDGsVqgYG7Uu+UecvrMZOTPX+nUgM8Fdb7DLoNXqAjtee9AM vfMK5oKTWf20T/TCfalFSkCnSNK0TqxaKS7A/kvG87rH/L1i1iQkY+9WPQlIiSiqzSQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792725333; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=zVAKIg7XqiPBVNuocH1Hoh+zfouG9OOWB6QRApYQMW8=; b=GBmGmLHJwPyGtVoGzT5w9Lq/UBs+94KShRFVsja0+RQujGOOd393OtEjCtQ2Qeau7kMM stpOgvLCKZAcIdKzyukUuC4YYNDhryzEc/GUjqX+3m/cjmmVlyjHTlF5it08dGlDrm5EP Qz/ZRQc6qkMCeCoJbZ8CVJ3+pj2cELv5mVhML3p5yYhQDO74t7MfRkevbSjdYvtswtl+J 5QDhkO5F9NbJM6zW2K5TDHUGPxJgnONCE6P5+yfdS6iy8VxL0G5gITHwqyG788XEjalex POMUMLcC/MX5aqdWiks6YMZycJ1sn1TQKtBNDdisV4sM2UDY8Pyn1ma8gKvziS5VI8w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=R2NEnJGS; arc=none smtp.remote-ip=91.218.175.138 Received: from mta0.migadu.com (out-138.mta0.migadu.com [91.218.175.138]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1A5E606A31D for ; Fri, 23 Oct 2026 03:15:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E1A5E606A31D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=R2NEnJGS X-Envelope-To: linux-kselftest@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=/Zq1baKOLuThcBsVDU3+UzpzigXWioU0C5AmZNp+Tio=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1792725331; v=1; x=1793330131; b=R2NEnJGShOdOls3InG6FOO0Dcu2OlU3tWm1gORf70l/vvdNfiOpR5So+V/QCQof31KmGXHH9 BYL9aDOjnGE7mwQM+mh1r45jwmtu1YjbznMnHJiJKan5YJrt/PnKFMovQy827lC3koLFhbg9S7H M5ZEzOr6OHhdZNg5q0LOBwGo= X-Envelope-To: linux-kselftest@vger.kernel.org Received: by mta11.migadu.com with ESMTPS id 2050942c7c50d671; Fri, 23 Oct 2026 03:15:26 +0000 X-Mizu-Trace-ID: 2050942c7c50d671 X-Migadu-Flow: FLOW_OUT Date: Fri, 23 Oct 2026 11:15:15 +0800 From: Hangbin Liu To: Xia Yan Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org, horms@kernel.org, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, pabeni@redhat.com, shuah@kernel.org Subject: Re: [PATCH net v3 2/2] selftests: net: check veth carrier after changing channel counts Message-ID: References: <20261022085842.2527-1-yana06070@163.com> <20261022085842.2527-2-yana06070@163.com> <20261023023350.7225-1-yana06070@163.com> X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261023023350.7225-1-yana06070@163.com> On Fri, Oct 23, 2026 at 10:33:50AM +0800, Xia Yan wrote: > Hi Hangbin, > > Thanks for reproducing the issue and reviewing the driver fix. > > > Why do you do gro setting in rx/tx set ups? > > I included GRO off/on to cover both queue reconfiguration paths. > No XDP program is attached in these cases. With GRO on, > veth_enable_range_safe() and veth_disable_range_safe() set up or tear > down per-RX-queue NAPI instances as the RX queue count changes. With > GRO off, those helpers do not need to reconfigure NAPI. > > The carrier bug reproduces in both configurations, so the test checks > the same carrier state with and without the NAPI resource changes. I mean this doesn't seem related to the carrier on/off (LOWER_UP) issue. Or did I miss something? Thanks Hangbin