From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.214.197 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794641594; b=EsLvM1MeRBmGYFmMR3JGy7IWmizH8TKTw4QSS11cAaHVpqzyjJlPcXb6J2FqjzB5m/wU QFUnn3cBXXr1Uee+skHBV4rsMNwf+9UerUj3vszFWuV9o3pFqTpkk1BdwTvDss1UXHNHL u6vVQTT3SKTeN1Z7i5dD/uhUpiOSfMCC4RskFhoYFJNUtOAuTwRBqShMIJyljsOmB2DRy nyU+WUBNfmsxPnp7X+6fvoCJPe0VNICMdWdkT262ewDHjPv5GwRQ4ZuFJwPwWBAWu8pD7 jlAHTRr6v9ytnoCYFOTIbYu1FhcGsWeowOdLhJm3kQ2WcLkqhPCKEfhD1xbZLcyVJRw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794641594; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:Message-ID:Subject:From:To:Cc:Content-Type; bh=mIqG4gDjs7qWgNSrfHEZi4r8CEaK0H3ibIoVTKmXC9M=; b=uWbR/SsgSIMPTWiYAz/o8eagDhit8ewtVU7a6nzXeFTlRV4saI+FSNawP3fYKTcz5rvW UOhZfqiRSPKFEF2Ucq9nTquV8RcCaWKfRjRYkPjEA8qreIrMpvnFlMeMxX76cit0mLU5e 4ww0bQ2gxLPMYDg5OG61rimnGa3GzuTpuWhVAW+ZY6lqgpPwa9RbOL/JoY9ATg1o9qGBa D5z6dpmXV4o/GzEppAqBjbl24FbIT/QQUV6kiuLOtk5RHPA3/u8/A3OVT7wiR4J2gvTb6 dZnOlZCmLZl0XGORd/Qi34xP1qnE7EX59GnpBnag/g/2zYKtcGZgYswN3fK6AX6N/Qg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--kuniyu.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b="VjnO8/qN"; arc=none smtp.remote-ip=209.85.214.197 Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ADEC606A323 for ; Sat, 14 Nov 2026 07:33:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 1ADEC606A323 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--kuniyu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=VjnO8/qN Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2e9995cea88so13955315ad.0 for ; Fri, 13 Nov 2026 23:33:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1794641593; x=1795246393; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mIqG4gDjs7qWgNSrfHEZi4r8CEaK0H3ibIoVTKmXC9M=; b=VjnO8/qN9HKKidM9JOEQtM25OmpQbG9qTz6MeThIgpFMuFrsLGP5A2Ope4XO8oexDk 3DTLgeaGoIyBAFfTct7K/xq6oBMghIIf3kA6wc2ekKMvnxtP8OtAHEctJN8Ca3Njo8q6 wWdirrbEtPSSIH3IQ0ZDBTRqZr4lkbhYqTNhlOZsEUK10dAASj0RTp5Kb0HlJNf3cN97 SddPzafva9uw3iJPrfMzoprpWtzVrf3YzGqPpsvB1MrWIDRrM+xtmmQ2K7V1iLwRbsoX s1yqn5QaTTfR/RXTvolCbveFU/tgSiDDHHoMPVwypBEPIfzqbdpqReapPTMntsSuxaHH wh1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794641593; x=1795246393; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mIqG4gDjs7qWgNSrfHEZi4r8CEaK0H3ibIoVTKmXC9M=; b=pckYG/hDJvBmdYXgbWm8ZbIjDrWqQ6KVC30ZXmQb/jjIoSWka4pf6DN0gtFkl4UwFz YGWwsQovXqJ+pWYkDNVYdJS6nLhGsNn27AateCVJdFC5jhHcEcHCNQlKm4beZzlpWIcg 2XOWEmhDgm/DbFvgGswCjaIDlL291TSrGYPJ77wN8DYU9YWWf0srdG1Zx2RuU8Z7virT BJVdisTpGbpYe0N5a6fZV9mbBcBpC8YAHQNvThtvE1T5885QukIlMd/vKUjuzjR+JQ4F NhCtjOZG+5E5/3mojwLA6B0BDJhnO53TTBqzx3UDgtrK/gq4k/U51IaZah/T9B/w0GBb YM7g== X-Forwarded-Encrypted: i=1; AL+hErERDiFrw4FHbI5zTRExHDW/twNgiE63KzjeVoHJlGC6KOjjSmfqdiYAdojdGLppC6aw1HEB38qfAYKULk8r9rw=@vger.kernel.org X-Gm-Message-State: APuU4Z8GJARyexkzH1er1+OwCExBUK3wiGlXgFCUYVINb+pTMd5gDSjL GeB2urOlQjaQMF40ZjIlmGHncsrYT1T6IkYHbiaY0kOUNaQsJX/LZfIc/WaAYcQg8Or2vpxTtds nUuXbxQ== X-Received: from plbl7.prod.google.com ([2002:a17:902:eb07:b0:2eb:2db:b93d]) (user=kuniyu job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:d54e:b0:2e9:6790:212c with SMTP id d9443c01a7336-2ee0dee857emr53512405ad.30.1794641593150; Fri, 13 Nov 2026 23:33:13 -0800 (PST) Date: Sat, 14 Nov 2026 07:33:12 +0000 In-Reply-To: <20261111225148.88506-2-sidchintamaneni@gmail.com> X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261111225148.88506-1-sidchintamaneni@gmail.com> <20261111225148.88506-2-sidchintamaneni@gmail.com> Message-ID: Subject: Re: [PATCH net v2 1/2] af_unix: Fix scm_stat.nr_fds leak in unix_dgram_disconnected(). From: Kuniyuki Iwashima To: Siddharth Chintamaneni Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , Kirill Tkhai , apais@microsoft.com, hargar@linux.microsoft.com, rlmenge@gmail.com, egoriluk@gmail.com, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Wed, 11 Nov 2026 22:51:47 +0000, Siddharth Chintamaneni wrote: > When a connected SOCK_DGRAM socket disconnects (e.g. via connect() with > AF_UNSPEC), reconnects to a different peer, or observes a dead peer in > unix_dgram_sendmsg(), unix_dgram_disconnected() purges all unread > datagrams from sk->sk_receive_queue via skb_queue_purge_reason(). > > Because skb_queue_purge_reason() frees each skb without calling > scm_stat_del(sk, skb), any SCM_RIGHTS file descriptors attached to the > purged skbs remain permanently accounted in u->scm_stat.nr_fds (reported > as scm_fds in /proc//fdinfo/) for the remaining lifetime of the > socket. > > Move scm_stat_add() and scm_stat_del() above unix_dgram_disconnected(), > splice sk->sk_receive_queue onto a local list under the queue lock, and > call scm_stat_del() before kfree_skb_reason() on each purged skb. > > Fixes: 3c32da19a858 ("unix: Show number of pending scm files of receive queue in fdinfo") > Signed-off-by: Siddharth Chintamaneni Reviewed-by: Kuniyuki Iwashima