From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794833919; b=pwmkIcSZSb1OG05Bpfh4GyLjnjcKhQ8CicuaL2JgWhmod3uJ+dQWJRx284DtE4l5Q/KH E7wC5z48SDJRkeVFH+wWDhte1kzj+9u9i5z4lT0sX2hppxi/TPSDaYTH3ofdoX8h51VDR 1dknhdhX5LqJwYu1C+fR9QPBlGmE7kGMF3s0m8QmFr0a+1EN+PZlHGtXwpE2EgBZr50GO /W694TpI25aiikXNY0XLUuqrpHkKDcRFqCIqcsFPBAkmjLSER686sVOihu58W1Y4Z0NZO 5fwr8u+40zOPTlU4Ff9aHoTjpuNWnaNuE3/5STxhSt9j3N8S2MfzR6tUsB+I1ExUJxg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794833919; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:Received:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:X-Scanned-By; bh=a0eXnU4zCIUpfEz3KZfBfjFrCwZNqPOxDyZIHHOmlwY=; b=NBWXpceiY0qCJC0uADjjMCaeBMKxU+nfjFV2oYxHYS66hTYRdlTZ8UXjIMzWuj1rgbwJ iJrZpeew6O0V3uAV+jqk/8z9giL6viXfJE9IDRoXg8vxVVOpuuOCAO0muOGO3Yg00HSej SGiMJlFbdutRw6WOMR1OJRdTxAxH/26tUM9cISuQzMxJW2fTGG8hRlhJnIJ249vsXHhIH Vx7RSjWTfkI/x29UrX9V4S9tFeHQ/+SVxJQCHwxo+uBnGuwxGWiv5iBVSateszIEqBNVZ 1gRQkYZOL3wBJo02JY/rr3J06Ew8Oq9es2hYpoMLERvma5yykZ4+8CTMwpvSDYRhd4g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JA4RNrPx; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3F4B606A329 for ; Mon, 16 Nov 2026 12:58:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B3F4B606A329 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=JA4RNrPx DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794833916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a0eXnU4zCIUpfEz3KZfBfjFrCwZNqPOxDyZIHHOmlwY=; b=JA4RNrPxgaTAOdowDIzUqWKkRKRyEHTjY+/xzqhTQLuzQb7d3LyKNyn1aK3KgNpgpVj0f/ mudoJtQPPdqb3jQc+95TskdwTJlwHRddKYPQWcpne7Drc7YH8eDFxGuPl4zu0WR7X+lIIN wy1c2x9bIVTjeWlk6e2aVJz5FXIQHic= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-BnUPYpnYOaOOHgxB5EYAVA-1; Mon, 16 Nov 2026 07:58:25 -0500 X-MC-Unique: BnUPYpnYOaOOHgxB5EYAVA-1 X-Mimecast-MFC-AGG-ID: BnUPYpnYOaOOHgxB5EYAVA_1794833894 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1AADD180049D; Mon, 16 Nov 2026 12:58:13 +0000 (UTC) Received: from onestero-thinkpadp1gen7.tpbc.csb (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 93DC8195B3C0; Mon, 16 Nov 2026 12:58:08 +0000 (UTC) Received: by onestero-thinkpadp1gen7.tpbc.csb (nbSMTP-1.00) for uid 13628 oleg@redhat.com; Mon, 16 Nov 2026 13:58:12 +0100 (CET) Date: Mon, 16 Nov 2026 13:58:07 +0100 From: Oleg Nesterov To: Renzo Davoli Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Dmitry V . Levin" , Alexey Gladkov , Eugene Syromyatnikov , Charlie Jenkins , Bradley Morgan , Shuah Khan , strace-devel@lists.strace.io, linux-api@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 1/2] ptrace: reject out of range error values in PTRACE_SET_SYSCALL_INFO Message-ID: References: <20261115152703.416254-1-renzo@cs.unibo.it> <20261115152703.416254-2-renzo@cs.unibo.it> X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261115152703.416254-2-renzo@cs.unibo.it> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On 11/15, Renzo Davoli wrote: > > With is_error set, PTRACE_SET_SYSCALL_INFO passes info.exit.rval to > syscall_set_return_value() as an "int" error without checking it: a > positive value, or on 64-bit one outside the "int" range, turns the > error into a success or is truncated. > > Reject with -ERANGE any error value outside [-MAX_ERRNO, -1]. > > Fixes: 26bb32768fe6 ("ptrace: introduce PTRACE_SET_SYSCALL_INFO request") > Reviewed-by: Dmitry V. Levin > Reviewed-by: Bradley Morgan > Signed-off-by: Renzo Davoli > --- > kernel/ptrace.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/kernel/ptrace.c b/kernel/ptrace.c > index 3f2fe68ccb14..1ffacfcef8d4 100644 > --- a/kernel/ptrace.c > +++ b/kernel/ptrace.c > @@ -1111,6 +1111,10 @@ ptrace_set_syscall_info_exit(struct task_struct *child, struct pt_regs *regs, > if (rval != info->exit.rval) > return -ERANGE; > > + /* An error must be a negative errno value. */ > + if (info->exit.is_error && (rval < -MAX_ERRNO || rval >= 0)) > + return -ERANGE; > + if (info->exit.is_error && !IS_ERR_VALUE(rval)) ? Oleg.