From: "Liu, Yujie" <yujie.liu@intel.com>
To: "idosch@nvidia.com" <idosch@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>
Cc: "shuah@kernel.org" <shuah@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>
Subject: Re: [PATCH net-next] selftests: vxlan_mdb: Avoid duplicate test names
Date: Thu, 29 Feb 2024 08:28:47 +0000 [thread overview]
Message-ID: <b008615006418ae7bc52db9e8d54b18fcf565856.camel@intel.com> (raw)
In-Reply-To: <20240227170418.491442-1-idosch@nvidia.com>
Hi Ido,
On Tue, 2024-02-27 at 19:04 +0200, Ido Schimmel wrote:
> Rename some test cases to avoid overlapping test names which is
> problematic for the kernel test robot. No changes in the test's
> logic.
>
> Suggested-by: Yujie Liu <yujie.liu@intel.com>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> Yujie Liu, please verify this works for you.
This patch works well in the kernel test robot. Now there is no problem
of overlapping test names. Thanks.
Tested-by: Yujie Liu <yujie.liu@intel.com>
# Control path: Flush
# -------------------
# TEST: Flush all [ OK ]
# TEST: Flush by port - matching [ OK ]
# TEST: Flush by port - non-matching [ OK ]
# TEST: Flush by source VNI - matching [ OK ]
# TEST: Flush by source VNI - non-matching [ OK ]
# TEST: Flush by "permanent" state [ OK ]
# TEST: Flush by "nopermanent" state [ OK ]
# TEST: Flush by routing protocol - matching [ OK ]
# TEST: Flush by routing protocol - non-matching [ OK ]
# TEST: Flush by IPv4 destination IP - matching [ OK ]
# TEST: Flush by IPv4 destination IP - non-matching [ OK ]
# TEST: Flush by IPv6 destination IP - matching [ OK ]
# TEST: Flush by IPv6 destination IP - non-matching [ OK ]
# TEST: Flush by UDP destination port - matching [ OK ]
# TEST: Flush by UDP destination port - non-matching [ OK ]
# TEST: Flush by device's UDP destination port - matching [ OK ]
# TEST: Flush by device's UDP destination port - non-matching [ OK ]
# TEST: Flush by destination VNI - matching [ OK ]
# TEST: Flush by destination VNI - non-matching [ OK ]
# TEST: Flush by destination VNI equal to source VNI - matching [ OK ]
# TEST: Flush by destination VNI equal to source VNI - non-matching [ OK ]
# TEST: Flush by VLAN ID [ OK ]
> ---
> tools/testing/selftests/net/test_vxlan_mdb.sh | 36 +++++++++----------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/tools/testing/selftests/net/test_vxlan_mdb.sh b/tools/testing/selftests/net/test_vxlan_mdb.sh
> index 84a05a9e46d8..74ff9fb2a6f0 100755
> --- a/tools/testing/selftests/net/test_vxlan_mdb.sh
> +++ b/tools/testing/selftests/net/test_vxlan_mdb.sh
> @@ -1014,10 +1014,10 @@ flush()
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 port vx0"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010"
> - log_test $? 254 "Flush by port"
> + log_test $? 254 "Flush by port - matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 port veth0"
> - log_test $? 255 "Flush by wrong port"
> + log_test $? 255 "Flush by port - non-matching"
>
> # Check that when flushing by source VNI only entries programmed with
> # the specified source VNI are flushed and the rest are not.
> @@ -1030,9 +1030,9 @@ flush()
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 src_vni 10010"
>
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010"
> - log_test $? 254 "Flush by specified source VNI"
> + log_test $? 254 "Flush by source VNI - matching"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10011"
> - log_test $? 0 "Flush by unspecified source VNI"
> + log_test $? 0 "Flush by source VNI - non-matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
>
> @@ -1058,9 +1058,9 @@ flush()
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 proto bgp"
>
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \"proto bgp\""
> - log_test $? 1 "Flush by specified routing protocol"
> + log_test $? 1 "Flush by routing protocol - matching"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \"proto zebra\""
> - log_test $? 0 "Flush by unspecified routing protocol"
> + log_test $? 0 "Flush by routing protocol - non-matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
>
> @@ -1075,9 +1075,9 @@ flush()
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 dst 198.51.100.2"
>
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.2"
> - log_test $? 1 "Flush by specified destination IP - IPv4"
> + log_test $? 1 "Flush by IPv4 destination IP - matching"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.1"
> - log_test $? 0 "Flush by unspecified destination IP - IPv4"
> + log_test $? 0 "Flush by IPv4 destination IP - non-matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
>
> @@ -1089,9 +1089,9 @@ flush()
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 dst 2001:db8:1000::2"
>
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 2001:db8:1000::2"
> - log_test $? 1 "Flush by specified destination IP - IPv6"
> + log_test $? 1 "Flush by IPv6 destination IP - matching"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 2001:db8:1000::1"
> - log_test $? 0 "Flush by unspecified destination IP - IPv6"
> + log_test $? 0 "Flush by IPv6 destination IP - non-matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
>
> @@ -1104,9 +1104,9 @@ flush()
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 dst_port 11111"
>
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \"dst_port 11111\""
> - log_test $? 1 "Flush by specified UDP destination port"
> + log_test $? 1 "Flush by UDP destination port - matching"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \"dst_port 22222\""
> - log_test $? 0 "Flush by unspecified UDP destination port"
> + log_test $? 0 "Flush by UDP destination port - non-matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
>
> @@ -1121,9 +1121,9 @@ flush()
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 dst_port 4789"
>
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.1"
> - log_test $? 1 "Flush by device's UDP destination port"
> + log_test $? 1 "Flush by device's UDP destination port - matching"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.2"
> - log_test $? 0 "Flush by unspecified UDP destination port"
> + log_test $? 0 "Flush by device's UDP destination port - non-matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
>
> @@ -1136,9 +1136,9 @@ flush()
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 vni 20010"
>
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \" vni 20010\""
> - log_test $? 1 "Flush by specified destination VNI"
> + log_test $? 1 "Flush by destination VNI - matching"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep \" vni 20011\""
> - log_test $? 0 "Flush by unspecified destination VNI"
> + log_test $? 0 "Flush by destination VNI - non-matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
>
> @@ -1153,9 +1153,9 @@ flush()
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0 vni 10010"
>
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.1"
> - log_test $? 1 "Flush by destination VNI equal to source VNI"
> + log_test $? 1 "Flush by destination VNI equal to source VNI - matching"
> run_cmd "bridge -n $ns1_v4 -d -s mdb get dev vx0 grp 239.1.1.1 src_vni 10010 | grep 198.51.100.2"
> - log_test $? 0 "Flush by unspecified destination VNI"
> + log_test $? 0 "Flush by destination VNI equal to source VNI - non-matching"
>
> run_cmd "bridge -n $ns1_v4 mdb flush dev vx0"
>
prev parent reply other threads:[~2024-02-29 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 17:04 [PATCH net-next] selftests: vxlan_mdb: Avoid duplicate test names Ido Schimmel
2024-02-29 4:20 ` patchwork-bot+netdevbpf
2024-02-29 8:28 ` Liu, Yujie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b008615006418ae7bc52db9e8d54b18fcf565856.camel@intel.com \
--to=yujie.liu@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox