From: Shuah Khan <skhan@linuxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
Shuah Khan <shuah@kernel.org>
Cc: kernel@collabora.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 1/3] selftests: x86: test_vsyscall: reorder code to reduce #ifdef blocks
Date: Thu, 28 Mar 2024 12:39:59 -0600 [thread overview]
Message-ID: <b06db8aa-9548-4b92-af7e-61fbd8a654c2@linuxfoundation.org> (raw)
In-Reply-To: <20240327184637.3915969-1-usama.anjum@collabora.com>
On 3/27/24 12:46, Muhammad Usama Anjum wrote:
> There are multiple #ifdef blocks inside functions where they return just
> 0 if #ifdef is false. This makes number of tests counting difficult.
> Move those functions inside one #ifdef block and move all of them
> together. This is preparatory patch for next patch to convert this into
> TAP format. So in this patch, we are just moving functions around
> without any changes.
>
> With and without this patch, the output of this patch is same.
>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
Pulled all three patches in this series. In the future, please
add a cover-letter when you send patch series.
thanks,
-- Shuah
prev parent reply other threads:[~2024-03-28 18:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 18:46 [PATCH v2 1/3] selftests: x86: test_vsyscall: reorder code to reduce #ifdef blocks Muhammad Usama Anjum
2024-03-27 18:46 ` [PATCH v2 2/3] selftests: x86: test_vsyscall: conform test to TAP format output Muhammad Usama Anjum
2024-03-27 18:46 ` [PATCH v2 3/3] selftests: x86: test_mremap_vdso: " Muhammad Usama Anjum
2024-03-28 18:39 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b06db8aa-9548-4b92-af7e-61fbd8a654c2@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox