From: Shuah Khan <skhan@linuxfoundation.org>
To: Yi Lai <yi1.lai@intel.com>,
brauner@kernel.org, shuah@kernel.org, areber@redhat.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
yi1.lai@linux.intel.com
Cc: Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/clone3: Fix capability dropping by using standard libcap API
Date: Tue, 31 Mar 2026 14:10:09 -0600 [thread overview]
Message-ID: <b098d65a-bb67-4399-87e6-3fc5a2f086a1@linuxfoundation.org> (raw)
In-Reply-To: <20260310031415.151531-1-yi1.lai@intel.com>
On 3/9/26 21:14, Yi Lai wrote:
> The clone3_cap_checkpoint_restore.c selftest defined its own 'struct
> libcap' to manually cast and manipulate the internal memory layout of
> the opaque 'cap_t' type.
>
> Starting with libcap v2.60 (commit aca076443591 "Make cap_t operations
> thread safe"), a '__u8 mutex' was added to the beginning of the internal
> 'struct _cap_struct'. This structural shift breaks the selftest's custom
> struct layout assumptions, causing capability corruption and leading to
> failures during test execution.
>
> Fix this by removing the custom struct definition and use the standard
> cap_set_flag() API.
What king of failures are you seeing? Can you send the failures from
the run?
>
> Fixes: 1d27a0be16d6 ("selftests: add clone3() CAP_CHECKPOINT_RESTORE test")
> Signed-off-by: Yi Lai <yi1.lai@intel.com>
> ---
thanks,
-- Shuah
next prev parent reply other threads:[~2026-03-31 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 3:14 [PATCH] selftests/clone3: Fix capability dropping by using standard libcap API Yi Lai
2026-03-31 20:10 ` Shuah Khan [this message]
2026-04-01 1:11 ` Lai, Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b098d65a-bb67-4399-87e6-3fc5a2f086a1@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=areber@redhat.com \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=yi1.lai@intel.com \
--cc=yi1.lai@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox