Re: [PATCH net-next] selftests: forwarding: lib.sh: ignore "Address not found"

[Geliang Tang <geliang@kernel.org>]

On Tue, 2024-08-06 at 09:34 +0200, Nicolas Dichtel wrote:
> Le 06/08/2024 à 06:20, Geliang Tang a écrit :
> > From: Geliang Tang <tanggeliang@kylinos.cn>
> > 
> > So many "Address not found" messages occur at the end of forwarding
> > tests
> > when using "ip address del" command for an invalid address:
> > 
> > TEST: FDB limits interacting with FDB type local                   
> > [ OK ]
> > Error: ipv4: Address not found.
> > 
> > ... ...
> > TEST: IGMPv3 S,G port entry automatic add to a *,G port            
> > [ OK ]
> > Error: ipv4: Address not found.
> > Error: ipv6: address not found.
> > 
> > ... ...
> > TEST: Isolated port flooding                                       
> > [ OK ]
> > Error: ipv4: Address not found.
> > Error: ipv6: address not found.
> > 
> > ... ...
> > TEST: Externally learned FDB entry - ageing & roaming              
> > [ OK ]
> > Error: ipv4: Address not found.
> > Error: ipv6: address not found.
> > 
> > This patch gnores these messages and redirects them to /dev/null in
> typo: s/gnores/ignores or 'hides'

It is indeed a typo. Thanks for pointing it out. Will update this in
v2.

-Geliang

> 
> Nicolas
> 
> > __addr_add_del().
> > 
> > Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
> > ---
> >  tools/testing/selftests/net/forwarding/lib.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/testing/selftests/net/forwarding/lib.sh
> > b/tools/testing/selftests/net/forwarding/lib.sh
> > index ff96bb7535ff..8670b6053cde 100644
> > --- a/tools/testing/selftests/net/forwarding/lib.sh
> > +++ b/tools/testing/selftests/net/forwarding/lib.sh
> > @@ -839,7 +839,7 @@ __addr_add_del()
> >  	array=("${@}")
> >  
> >  	for addrstr in "${array[@]}"; do
> > -		ip address $add_del $addrstr dev $if_name
> > +		ip address $add_del $addrstr dev $if_name &>
> > /dev/null
> >  	done
> >  }
> >