From: Shuah Khan <skhan@linuxfoundation.org>
To: Anjali Kulkarni <anjali.k.kulkarni@oracle.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"lkft-triage@lists.linaro.org" <lkft-triage@lists.linaro.org>,
Netdev <netdev@vger.kernel.org>,
clang-built-linux <llvm@lists.linux.dev>,
Shuah Khan <shuah@kernel.org>,
Anders Roxell <anders.roxell@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Liam Howlett <liam.howlett@oracle.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: selftests: connector: proc_filter.c:48:20: error: invalid application of 'sizeof' to an incomplete type 'struct proc_input'
Date: Fri, 28 Jul 2023 11:34:17 -0600 [thread overview]
Message-ID: <b247219c-f988-bcc2-36f5-22659e2ced96@linuxfoundation.org> (raw)
In-Reply-To: <5844361F-E776-4C52-BA8F-7E13D6B4EDE1@oracle.com>
On 7/28/23 10:46, Anjali Kulkarni wrote:
>
>
>> On Jul 27, 2023, at 7:43 PM, Jakub Kicinski <kuba@kernel.org> wrote:
>>
>> On Fri, 28 Jul 2023 01:38:40 +0000 Anjali Kulkarni wrote:
>>> Jakub,
>>> Do I need to revert the -f runtime filter option back to compile time
>>> and commit with that disabled so the selftest compiles on a kernel on
>>> which the new options are not defined?
>>
>> I'm not 100% sure myself on what's the expectations for building
>> selftests against uAPI headers is..
>>
>> I _think_ that you're supposed to add an -I$something to
>> the CFLAGS in your Makefile. KHDR_INCLUDES maybe? So that the uAPI
>> headers from the build get used (rendered by make headers).
>>
>> Take a look at Documentation/dev-tools/kselftest.rst, I hope
>> the answer is somewhere there.
> Ok thanks, I will look into your suggestions.
> Anjali
>
I sent a 3 patch series with the fix to this problem and a couple of
others I found during testing.
thanks,
-- Shuah
next prev parent reply other threads:[~2023-07-28 17:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 13:05 selftests: connector: proc_filter.c:48:20: error: invalid application of 'sizeof' to an incomplete type 'struct proc_input' Naresh Kamboju
2023-07-25 16:48 ` Anjali Kulkarni
2023-07-27 17:34 ` Anjali Kulkarni
2023-07-28 0:43 ` Shuah Khan
2023-07-28 1:38 ` Anjali Kulkarni
2023-07-28 2:43 ` Jakub Kicinski
2023-07-28 16:46 ` Anjali Kulkarni
2023-07-28 17:34 ` Shuah Khan [this message]
2023-07-28 18:08 ` Anjali Kulkarni
2023-07-28 17:33 ` Shuah Khan
2023-07-28 18:13 ` Anjali Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b247219c-f988-bcc2-36f5-22659e2ced96@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=anders.roxell@linaro.org \
--cc=anjali.k.kulkarni@oracle.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=llvm@lists.linux.dev \
--cc=naresh.kamboju@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox