Re: [PATCH v2 3/4] riscv: ptrace: Fix BIT() compilation issues

Deepak Gupta
2026-03-10T02:58:50Z

On Mon, Mar 09, 2026 at 06:52:12PM -0700, Charlie Jenkins via B4 Relay wrote:
>From: Charlie Jenkins <thecharlesjenkins@gmail.com>
>
>BIT() is being used in ptrace.h without a definition, resulting in
>compilation errors in tools/testing/selftests/riscv/cfi/cfitests.c:
>
>cfitests.c:101:60: error: implicit declaration of function ‘BIT’ [-Wimplicit-function-declaration]
> 101 | if ((cfi_reg.cfi_status.cfi_state & CFI_ENABLE_MASK) != CFI_ENABLE_MASK)
>
>Include linux/bits.h to resolve this issue.
>
>Fixes: 2af7c9cf021c ("riscv/ptrace: expose riscv CFI status and state via ptrace and in core files")
>Signed-off-by: Charlie Jenkins <thecharlesjenkins@gmail.com>

Reviewed-by: Deepak Gupta <debug@rivosinc.com>

>---
> arch/riscv/include/uapi/asm/ptrace.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/arch/riscv/include/uapi/asm/ptrace.h b/arch/riscv/include/uapi/asm/ptrace.h
>index 18988a5f1a63..5b53cea14355 100644
>--- a/arch/riscv/include/uapi/asm/ptrace.h
>+++ b/arch/riscv/include/uapi/asm/ptrace.h
>@@ -8,6 +8,7 @@
>
> #ifndef __ASSEMBLER__
>
>+#include <linux/bits.h>
> #include <linux/types.h>
>
> #define PTRACE_GETFDPIC 33
>
>--
>2.52.0
>
>