Re: [PATCH v2 1/4] selftests: riscv: Add definition of BIT() macro

Paul Walmsley
2026-03-21T00:48:23Z

On Tue, 10 Mar 2026, Sergey Matyukevich wrote:

> On Mon, Mar 09, 2026 at 06:52:10PM -0700, Charlie Jenkins via B4 Relay wrote:
> > From: Charlie Jenkins <thecharlesjenkins@gmail.com>
> >
> > The BIT() macros is used by the validate_v_ptrace() test case, but not
> > defined. Include linux/bits.h to pull in this definition. To ensure that
> > the header in the kernel source is used, add tools/include to the header
> > search path.
> >
> > Fixes: 30eb191c895b ("selftests: riscv: verify ptrace rejects invalid vector csr inputs")
> > Signed-off-by: Charlie Jenkins <thecharlesjenkins@gmail.com>
> > ---
> > tools/testing/selftests/riscv/vector/Makefile | 7 +++++--
> > tools/testing/selftests/riscv/vector/validate_v_ptrace.c | 1 +
> > 2 files changed, 6 insertions(+), 2 deletions(-)
>
> Reviewed-and-Tested-by: Sergey Matyukevich <geomatsi@gmail.com>

Thanks for reviewing and testing but please use "Reviewed-and-tested-by"
next time so I don't have to fix it up by hand.

- Paul

$ scripts/checkpatch.pl --strict 0001-selftests-riscv-Add-definition-of-BIT-macro.patch
WARNING: 'Reviewed-and-tested-by:' is the preferred signature form
#13:
Reviewed-and-Tested-by: Sergey Matyukevich <geomatsi@gmail.com>