From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03A512848A7 for ; Fri, 12 Sep 2025 09:28:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757669312; cv=none; b=p1gRY3GQZj/9+G1BIM1T7/NRWYYI8FyyNnNB6v5wIBxuSxhpfy6FdmnddqIEJWhVktD/++CfR5AEjM3mTNKZzmlsO7RogICYB83eTY/Rsr5kdlY5prb0yYXvG82Ge6L644W226N/ni4vYt5lOtGv/3btad3QcdcY+yywwPmNNh8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757669312; c=relaxed/simple; bh=R7wEef/jOtkapfSgO7p2ITXCATNnRJOsQw4TC0DTQ+w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Li2MJtK3dpgAa9JmP+HT4Nz7SJwu9dQQ9fOc/xwp4Q4+wm0WVHs+5sG1LSVai9JgcK48IDghSnzHXRnE2ojs4A7ggBf88qW/Bt0C4zFQJHb7cMP7naOmyDWysWBE/g5mSGWkv4WtDGmAt4jbYHlgMR+xTjKln9kVuDoxZ+4tNAo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VxaAqb25; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VxaAqb25" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757669309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=q7Uh5PTxD7ESGcT6/GtnBW9W4Q4JZO2rqf/t4H/Zr2s=; b=VxaAqb25WwZZkaI3bVBE3fJfM0QD1w/c/yt52wmbG0xgmY6m20xUCmbJhWGg2YunXbq7WV 71Ac54c4fo8ljKyG1vdjwLQlFsePc6dkV7hNgo7q+akNEiJKGM5fiJ0cbvoUqZem47X5EM u9QTpP4t18DPLmNvBdLXHJewguwrLzs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-Tt0QwMpePp2FCYHkXtWYuw-1; Fri, 12 Sep 2025 05:28:28 -0400 X-MC-Unique: Tt0QwMpePp2FCYHkXtWYuw-1 X-Mimecast-MFC-AGG-ID: Tt0QwMpePp2FCYHkXtWYuw_1757669307 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45b990eb77cso10356805e9.0 for ; Fri, 12 Sep 2025 02:28:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757669307; x=1758274107; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q7Uh5PTxD7ESGcT6/GtnBW9W4Q4JZO2rqf/t4H/Zr2s=; b=Z14w4CRftriftQuEHayLz6Cfr42u+9mnN/a76BN8KBt8+m2Hw9937FmtpEOegUHaTW XPon7mZjkIgzss9TO/WUvYBH1Fs++AIuUTtVwU3PATm2pc9KZf6PIvn6T7paSdPIJ2NF 3pQQX6A7m41PVBw0YqoKOYNFVs0hNlO0lbhSM96dt/Kbanl875n1jpp+38S88bWWcL1a E62t9eFjXpqZDetDtXhlqvw4NfW+3mHrPF0FUgFNAAw3JECVh75GPp4UaxCaV5kLTUQ3 jpG9xZ/zCDqB8TAVsMXGJ2zdKsH99wL4/7uW0nfB4zt/5UpLGWTOI2cJebDZpKjtX+0S JMqQ== X-Forwarded-Encrypted: i=1; AJvYcCW4oNyxJ9w94GBRn/NlmPBlQp1ROzlMQAI/ax2aOu3/dy5HkDfBIcdRriKkBK2YyUoEuBx6b2ffPm2Dn865RCQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwJ8vp5WUsPqA+Fke71Ic3xAl6/4Frmdi/NQYsGcCLcaOiDqWqE mIdE4k8Mjq+fRU9kAQYfy5PHMYrhG1q0SDunQHOsXEixkn5fwZFijw+vfcTjC8jaPLd9kTn5BVz JvlJ4YSG6YINIQKRftutLiGfTf/63dtZy+c3vUQ/DKxfuCjxJrO4LACDud8wJxY3b8Cx3/Q== X-Gm-Gg: ASbGncvA5lDs3oRSuo12ctk1Fs8EYiW29O2yKvHRDG5zDNiOm5vEl6lAfuFU9dW1geS X7+Pxr56TlaDFtd6bpGkpQ97Nw+Iyj9jkd+OUpXfqZoGbgZrtzE/XXf7GNDhGuG7HPpaHK6gEXv T+EDW48+ilWlBUdJQ3qLAEwIeW6nwRE0gwzfhATfiXkyFTTebW5dKhwDdreeCbqXSs4vzJzbPab 7gXUd0LGLAUZJs0Fr94ELlTZXS+qABG9VY2kucnrB+EZrdSTVNWn1Z48WoQAg+s55+XG2hsNGNh oLxiy3wUstv8+TZCIwxn38/NPMVatIJEel3457P3ou0cZd9kScao80kS7CQcGeOmU4QDh2b6REz TGhinmHZjGr7pwwVHJ3QMo7cj+wQ44JNUrtctB3oKLVr6P83dHbYINDLsk0VDUhQMM8c= X-Received: by 2002:a05:600c:c3cf:b0:45b:8b95:7119 with SMTP id 5b1f17b1804b1-45dfd5c0dc5mr36986455e9.8.1757669307377; Fri, 12 Sep 2025 02:28:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZ5nV58Kk+xJkGc6fU0GXwEXnehySepBoJWxSSaPQdthPtf0Tvw62s50h2qqfl4KIaewNpfA== X-Received: by 2002:a05:600c:c3cf:b0:45b:8b95:7119 with SMTP id 5b1f17b1804b1-45dfd5c0dc5mr36986305e9.8.1757669306984; Fri, 12 Sep 2025 02:28:26 -0700 (PDT) Received: from ?IPV6:2003:d8:2f20:da00:b70a:d502:3b51:1f2d? (p200300d82f20da00b70ad5023b511f2d.dip0.t-ipconnect.de. [2003:d8:2f20:da00:b70a:d502:3b51:1f2d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e7607870cfsm6004344f8f.19.2025.09.12.02.28.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 02:28:26 -0700 (PDT) Message-ID: Date: Fri, 12 Sep 2025 11:28:25 +0200 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: transhuge-stress: fix potential memory leak on realloc failure To: Haofeng Li <920484857@qq.com>, Andrew Morton Cc: Lorenzo Stoakes , Zi Yan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Haofeng Li <13266079573@163.com>, Haofeng Li References: From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12.09.25 10:20, Haofeng Li wrote: > From: Haofeng Li > > When realloc() fails in transhuge-stress test, the original code > exits immediately without freeing the previously allocated memory, > causing a memory leak. What do you think happens when a process exits? :) Correct! All memory ever allocated to that process gets freed, avoiding any memory leaks. -- Cheers David / dhildenb