[PATCH] selftests/eventfd: correct test name and improve messages

[PATCH] selftests/eventfd: correct test name and improve messages

[Ryan Chung]

- Rename test from  to

- Make the RDWR‐flag comment declarative:
  “The kernel automatically adds the O_RDWR flag.”
- Update semaphore‐flag failure message to:
  “eventfd semaphore flag check failed: …”

Signed-off-by: Ryan Chung <seokwoo.chung130@gmail.com>
---
 tools/testing/selftests/filesystems/eventfd/eventfd_test.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/filesystems/eventfd/eventfd_test.c b/tools/testing/selftests/filesystems/eventfd/eventfd_test.c
index 85acb4e3ef00..72d51ad0ee0e 100644
--- a/tools/testing/selftests/filesystems/eventfd/eventfd_test.c
+++ b/tools/testing/selftests/filesystems/eventfd/eventfd_test.c
@@ -50,7 +50,7 @@ TEST(eventfd_check_flag_rdwr)
 	ASSERT_GE(fd, 0);
 
 	flags = fcntl(fd, F_GETFL);
-	// since the kernel automatically added O_RDWR.
+	// The kernel automatically adds the O_RDWR flag.
 	EXPECT_EQ(flags, O_RDWR);
 
 	close(fd);
@@ -85,7 +85,7 @@ TEST(eventfd_check_flag_nonblock)
 	close(fd);
 }
 
-TEST(eventfd_chek_flag_cloexec_and_nonblock)
+TEST(eventfd_check_flag_cloexec_and_nonblock)
 {
 	int fd, flags;
 
@@ -178,8 +178,7 @@ TEST(eventfd_check_flag_semaphore)
 	// The semaphore could only be obtained from fdinfo.
 	ret = verify_fdinfo(fd, &err, "eventfd-semaphore: ", 19, "1\n");
 	if (ret != 0)
-		ksft_print_msg("eventfd-semaphore check failed, msg: %s\n",
-				err.msg);
+		ksft_print_msg("eventfd semaphore flag check failed: %s\n", err.msg);
 	EXPECT_EQ(ret, 0);
 
 	close(fd);
-- 
2.43.0

Re: [PATCH] selftests/eventfd: correct test name and improve messages

[Wen Yang]

Thanks.

Reviewed-by: Wen Yang <wen.yang@linux.dev>

--
Best wishes,
Wen


On 2025/5/13 15:44, Ryan Chung wrote:
> - Rename test from  to
> 
> - Make the RDWR‐flag comment declarative:
>    “The kernel automatically adds the O_RDWR flag.”
> - Update semaphore‐flag failure message to:
>    “eventfd semaphore flag check failed: …”
> 
> Signed-off-by: Ryan Chung <seokwoo.chung130@gmail.com>
> ---
>   tools/testing/selftests/filesystems/eventfd/eventfd_test.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/filesystems/eventfd/eventfd_test.c b/tools/testing/selftests/filesystems/eventfd/eventfd_test.c
> index 85acb4e3ef00..72d51ad0ee0e 100644
> --- a/tools/testing/selftests/filesystems/eventfd/eventfd_test.c
> +++ b/tools/testing/selftests/filesystems/eventfd/eventfd_test.c
> @@ -50,7 +50,7 @@ TEST(eventfd_check_flag_rdwr)
>   	ASSERT_GE(fd, 0);
>   
>   	flags = fcntl(fd, F_GETFL);
> -	// since the kernel automatically added O_RDWR.
> +	// The kernel automatically adds the O_RDWR flag.
>   	EXPECT_EQ(flags, O_RDWR);
>   
>   	close(fd);
> @@ -85,7 +85,7 @@ TEST(eventfd_check_flag_nonblock)
>   	close(fd);
>   }
>   
> -TEST(eventfd_chek_flag_cloexec_and_nonblock)
> +TEST(eventfd_check_flag_cloexec_and_nonblock)
>   {
>   	int fd, flags;
>   
> @@ -178,8 +178,7 @@ TEST(eventfd_check_flag_semaphore)
>   	// The semaphore could only be obtained from fdinfo.
>   	ret = verify_fdinfo(fd, &err, "eventfd-semaphore: ", 19, "1\n");
>   	if (ret != 0)
> -		ksft_print_msg("eventfd-semaphore check failed, msg: %s\n",
> -				err.msg);
> +		ksft_print_msg("eventfd semaphore flag check failed: %s\n", err.msg);
>   	EXPECT_EQ(ret, 0);
>   
>   	close(fd);

Re: [PATCH] selftests/eventfd: correct test name and improve messages

[Shuah Khan]

On 5/13/25 01:44, Ryan Chung wrote:
> - Rename test from  to
> 

?? missing description of the change. Looks like the patch
renames the test to fix spelling error in the test name?

> - Make the RDWR‐flag comment declarative:
>    “The kernel automatically adds the O_RDWR flag.”
> - Update semaphore‐flag failure message to:
>    “eventfd semaphore flag check failed: …”

There is no need to list all these changes.

Please check a few chanelogs as a reference to how to write them.

> 
> Signed-off-by: Ryan Chung <seokwoo.chung130@gmail.com>
> ---
>   tools/testing/selftests/filesystems/eventfd/eventfd_test.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/filesystems/eventfd/eventfd_test.c b/tools/testing/selftests/filesystems/eventfd/eventfd_test.c
> index 85acb4e3ef00..72d51ad0ee0e 100644
> --- a/tools/testing/selftests/filesystems/eventfd/eventfd_test.c
> +++ b/tools/testing/selftests/filesystems/eventfd/eventfd_test.c
> @@ -50,7 +50,7 @@ TEST(eventfd_check_flag_rdwr)
>   	ASSERT_GE(fd, 0);
>   
>   	flags = fcntl(fd, F_GETFL);
> -	// since the kernel automatically added O_RDWR.
> +	// The kernel automatically adds the O_RDWR flag.
>   	EXPECT_EQ(flags, O_RDWR);
>   
>   	close(fd);
> @@ -85,7 +85,7 @@ TEST(eventfd_check_flag_nonblock)
>   	close(fd);
>   }
>   
> -TEST(eventfd_chek_flag_cloexec_and_nonblock)
> +TEST(eventfd_check_flag_cloexec_and_nonblock)
>   {
>   	int fd, flags;
>   
> @@ -178,8 +178,7 @@ TEST(eventfd_check_flag_semaphore)
>   	// The semaphore could only be obtained from fdinfo.
>   	ret = verify_fdinfo(fd, &err, "eventfd-semaphore: ", 19, "1\n");
>   	if (ret != 0)
> -		ksft_print_msg("eventfd-semaphore check failed, msg: %s\n",
> -				err.msg);
> +		ksft_print_msg("eventfd semaphore flag check failed: %s\n", err.msg);

What's the reason for this change?

>   	EXPECT_EQ(ret, 0);
>   
>   	close(fd);

thanks,
-- Shuah

Re: [PATCH] selftests/eventfd: correct test name and improve messages

[Ryan Chung]

On Thu, May 22, 2025 at 03:47:27PM -0600, Shuah Khan wrote:
> On 5/13/25 01:44, Ryan Chung wrote:
> > - Rename test from  to
> > 
> 
> ?? missing description of the change. Looks like the patch
> renames the test to fix spelling error in the test name?

Sorry for the missing description. I am not entirely sure what happened
there. The correct description should have been: 

- Rename test from eventfd_chek_flag_cloexec_and_nonblock to
eventfd_check_flag_cloexec_and_nonblock.

> > - Make the RDWR‐flag comment declarative:
> >    “The kernel automatically adds the O_RDWR flag.”
> > - Update semaphore‐flag failure message to:
> >    “eventfd semaphore flag check failed: …”
> 
> There is no need to list all these changes.
> 
> Please check a few chanelogs as a reference to how to write them.
>

Thank you for your comment. I will make sure to do so next time.

> > 
> > Signed-off-by: Ryan Chung <seokwoo.chung130@gmail.com>
> > ---
> >   tools/testing/selftests/filesystems/eventfd/eventfd_test.c | 7 +++----
> >   1 file changed, 3 insertions(+), 4 deletions(-)
> > 
> > diff --git a/tools/testing/selftests/filesystems/eventfd/eventfd_test.c b/tools/testing/selftests/filesystems/eventfd/eventfd_test.c
> > index 85acb4e3ef00..72d51ad0ee0e 100644
> > --- a/tools/testing/selftests/filesystems/eventfd/eventfd_test.c
> > +++ b/tools/testing/selftests/filesystems/eventfd/eventfd_test.c
> > @@ -50,7 +50,7 @@ TEST(eventfd_check_flag_rdwr)
> >   	ASSERT_GE(fd, 0);
> >   	flags = fcntl(fd, F_GETFL);
> > -	// since the kernel automatically added O_RDWR.
> > +	// The kernel automatically adds the O_RDWR flag.
> >   	EXPECT_EQ(flags, O_RDWR);
> >   	close(fd);
> > @@ -85,7 +85,7 @@ TEST(eventfd_check_flag_nonblock)
> >   	close(fd);
> >   }
> > -TEST(eventfd_chek_flag_cloexec_and_nonblock)
> > +TEST(eventfd_check_flag_cloexec_and_nonblock)
> >   {
> >   	int fd, flags;
> > @@ -178,8 +178,7 @@ TEST(eventfd_check_flag_semaphore)
> >   	// The semaphore could only be obtained from fdinfo.
> >   	ret = verify_fdinfo(fd, &err, "eventfd-semaphore: ", 19, "1\n");
> >   	if (ret != 0)
> > -		ksft_print_msg("eventfd-semaphore check failed, msg: %s\n",
> > -				err.msg);
> > +		ksft_print_msg("eventfd semaphore flag check failed: %s\n", err.msg);
> 
> What's the reason for this change?
>

The error-print was reworded to match the project's logging style and
improve clarity for the flag. 

> >   	EXPECT_EQ(ret, 0);
> >   	close(fd);
> 
> thanks,
> -- Shuah

Thank you for your feedback. It looks like there was an issue with
sending the patch as this patch was missing descriptions. The correct
version of this patch - selftests/eventfd: correct test name and improve
messages - has been reviewd by Andrew Morton and merged into the
mm-stable branch: git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.
The filename was
selftests-eventfd-correct-test-name-and-improve-messages.patch.

Please let me know if you'd like me to prepare a v2 of this patch of it
there are any further issues to address. 

Thanks again for reviewing.

Sincerely,
Ryan Chung