From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 301D3C7EE24 for ; Fri, 2 Jun 2023 09:59:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233994AbjFBJ7R (ORCPT ); Fri, 2 Jun 2023 05:59:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235099AbjFBJ7Q (ORCPT ); Fri, 2 Jun 2023 05:59:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E34EA132 for ; Fri, 2 Jun 2023 02:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685699913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IjcMa1EzAvCm+h6bWeTWaHaKzxs/0IMxe2zdQtxTz/E=; b=A6OIPlFD1ULuD4XBT9Hco0YSPWzQO9jIFnIbF4oUzOO3Haavpg8w1eT1+eH4nAzNaBWery M17KCfVYhMTl/unRVGxe4LMuRLl+BmdumSShG8MPxZwuscg4mV7kjquzDFYZDU1kBVbqO2 7hp9jxfeRJoWT2h5bz/lUzf+TwNbafQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-BoyszmdzOymqWThuL6V5kw-1; Fri, 02 Jun 2023 05:58:31 -0400 X-MC-Unique: BoyszmdzOymqWThuL6V5kw-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-30b218c0bbbso892556f8f.3 for ; Fri, 02 Jun 2023 02:58:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685699910; x=1688291910; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IjcMa1EzAvCm+h6bWeTWaHaKzxs/0IMxe2zdQtxTz/E=; b=fzoUja6ajbthpCUOHvf1Moc06dfuQ1BX579eutzb/dv3Xf+ClCgR7yZrO0TdhIhQUr F+nKDgxkxxy0nD30g93eRDyONaZYuKlVJx66D+zwnI8N11VOmf07tbwgBMgd7NJHHvPm 5PjU6oLEl/BPhyfQzaoKbH0i3Uw+W7Ulb9bjuD8oy6aCjzwZhwUW1LoYbw0loyqdTuVa +aC9wrxG7V40H7IIs8hyIJoLUEanv5Al7d7jsLQo3Y+quEj7fB88c6ES7llTdJc50jNs +rA5+vAxjq2OaOvuCTGNireTmyV5G47veHP+jdVY52rBsXrEB4Y2VIAA8VrhfcdWQ7VE i52w== X-Gm-Message-State: AC+VfDwufIZMNW2pt0zMU+cXm/JoJOpw+r/l+oJkTfaqbbEUj+5KE3NG iZ7a0DkflGCin2FopmL2lOn/04paGn9/0CI75KeIkal8mChIhVLZKlRUfLy3+hwDdPONmEqSgce rZSZI4GV+DXtgZMlegoGHKm1Wvg7y X-Received: by 2002:a5d:53cd:0:b0:306:372d:7891 with SMTP id a13-20020a5d53cd000000b00306372d7891mr4169890wrw.59.1685699910684; Fri, 02 Jun 2023 02:58:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ631YkvzdiQwtylZVnj17BIofH3TVIc2MrP/4WsIUKRfMiZxci47Q/7IW3XCY0js5fVl6qpCQ== X-Received: by 2002:a5d:53cd:0:b0:306:372d:7891 with SMTP id a13-20020a5d53cd000000b00306372d7891mr4169878wrw.59.1685699910350; Fri, 02 Jun 2023 02:58:30 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2e:ae00:f2e3:50e0:73f7:451? (p200300d82f2eae00f2e350e073f70451.dip0.t-ipconnect.de. [2003:d8:2f2e:ae00:f2e3:50e0:73f7:451]) by smtp.gmail.com with ESMTPSA id y8-20020a056000108800b002ff2c39d072sm1154826wrw.104.2023.06.02.02.58.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jun 2023 02:58:29 -0700 (PDT) Message-ID: Date: Fri, 2 Jun 2023 11:58:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 01/12] selftests/mm: fix uffd-stress unused function warning Content-Language: en-US To: John Hubbard , Andrew Morton Cc: Peter Xu , Shuah Khan , Nathan Chancellor , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, LKML References: <20230602013358.900637-1-jhubbard@nvidia.com> <20230602013358.900637-2-jhubbard@nvidia.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230602013358.900637-2-jhubbard@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 02.06.23 03:33, John Hubbard wrote: > uffd_minor_feature() was unused. Remove it in order to fix the > associated clang build warning. > > Signed-off-by: John Hubbard > --- > tools/testing/selftests/mm/uffd-stress.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c > index f1ad9eef1c3a..995ff13e74c7 100644 > --- a/tools/testing/selftests/mm/uffd-stress.c > +++ b/tools/testing/selftests/mm/uffd-stress.c > @@ -88,16 +88,6 @@ static void uffd_stats_reset(struct uffd_args *args, unsigned long n_cpus) > } > } > > -static inline uint64_t uffd_minor_feature(void) > -{ > - if (test_type == TEST_HUGETLB && map_shared) > - return UFFD_FEATURE_MINOR_HUGETLBFS; > - else if (test_type == TEST_SHMEM) > - return UFFD_FEATURE_MINOR_SHMEM; > - else > - return 0; > -} > - > static void *locking_thread(void *arg) > { > unsigned long cpu = (unsigned long) arg; Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb