From: Shuah Khan <skhan@linuxfoundation.org>
To: John Stultz <jstultz@google.com>
Cc: zhangjiao2 <zhangjiao2@cmss.chinamobile.com>,
anna-maria@linutronix.de, frederic@kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
shuah@kernel.org, tglx@linutronix.de,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] selftests/timers: Remove unused NSEC_PER_SEC macro
Date: Fri, 6 Sep 2024 13:40:46 -0600 [thread overview]
Message-ID: <b84546c4-374a-457f-94ee-509db6fd0044@linuxfoundation.org> (raw)
In-Reply-To: <CANDhNCqZitCt2ffrbEKKJtuVJPNAw8y_BdoZ3iu_5BhH1j2b+g@mail.gmail.com>
On 9/6/24 11:02, John Stultz wrote:
> On Fri, Sep 6, 2024 at 7:29 AM Shuah Khan <skhan@linuxfoundation.org> wrote:
>> On 9/5/24 20:52, zhangjiao2 wrote:
>>> diff --git a/tools/testing/selftests/timers/skew_consistency.c b/tools/testing/selftests/timers/skew_consistency.c
>>> index c8e6bffe4e0a..83450145fe65 100644
>>> --- a/tools/testing/selftests/timers/skew_consistency.c
>>> +++ b/tools/testing/selftests/timers/skew_consistency.c
>>> @@ -36,8 +36,6 @@
>>> #include <sys/wait.h>
>>> #include "../kselftest.h"
>>>
>>> -#define NSEC_PER_SEC 1000000000LL
>>> -
>>> int main(int argc, char **argv)
>>> {
>>> struct timex tx;
>>
>> This looks good to me.
>>
>> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
>>
>> John, I can pick this up with if you are okay with this change.
>
> No objection from me, if you're ok with the commit.
> Acked-by: John Stultz <jstultz@google.com>
>
> thanks
> -john
Thank you. Applied linux-kselftest next for Linux 6.12-rc1.
thanks,
-- Shuah
prev parent reply other threads:[~2024-09-06 19:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 2:52 [PATCH v2] selftests/timers: Remove unused NSEC_PER_SEC macro zhangjiao2
2024-09-06 14:29 ` Shuah Khan
2024-09-06 17:02 ` John Stultz
2024-09-06 19:40 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b84546c4-374a-457f-94ee-509db6fd0044@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=zhangjiao2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox