From: Markus Elfring <Markus.Elfring@web.de>
To: Wander Lairson Costa <wander@redhat.com>,
kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>, Rae Moar <rmoar@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] kunit: unregister the device on error
Date: Thu, 18 Apr 2024 17:00:17 +0200 [thread overview]
Message-ID: <b96697ff-3177-4559-a410-104ca3a1110f@web.de> (raw)
In-Reply-To: <20240418131754.58217-2-wander@redhat.com>
> kunit_init_device() should unregister the device on bus register error.
* Would another imperative wording be desirable also for this change description?
* Will the tag “Fixes” become relevant here?
Regards,
Markus
next prev parent reply other threads:[~2024-04-18 15:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 13:17 [PATCH 0/2] kunit: fix minor error path mistakes Wander Lairson Costa
2024-04-18 13:17 ` [PATCH 1/2] kunit: unregister the device on error Wander Lairson Costa
2024-04-18 15:00 ` Markus Elfring [this message]
2024-04-18 15:21 ` Wander Lairson Costa
2024-04-18 13:17 ` [PATCH 2/2] kunit: avoid memory leak on device register error Wander Lairson Costa
2024-04-18 15:24 ` Markus Elfring
2024-04-18 17:18 ` Wander Lairson Costa
2024-04-18 18:08 ` [ " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b96697ff-3177-4559-a410-104ca3a1110f@web.de \
--to=markus.elfring@web.de \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rmoar@google.com \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox