From: "Huang, Kai" <kai.huang@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"Aktas, Erdem" <erdemaktas@google.com>
Cc: "corbet@lwn.net" <corbet@lwn.net>, "Du, Fan" <fan.du@intel.com>,
"shuah@kernel.org" <shuah@kernel.org>,
"Luck, Tony" <tony.luck@intel.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"brijesh.singh@amd.com" <brijesh.singh@amd.com>,
"dionnaglaze@google.com" <dionnaglaze@google.com>,
"qinkun@apache.org" <qinkun@apache.org>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"wander@redhat.com" <wander@redhat.com>,
"atishp@rivosinc.com" <atishp@rivosinc.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"chongc@google.com" <chongc@google.com>,
"bp@alien8.de" <bp@alien8.de>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"sathyanarayanan.kuppuswamy@linux.intel.com"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"dhowells@redhat.com" <dhowells@redhat.com>,
"Yu, Guorui" <guorui.yu@linux.alibaba.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v3 3/3] selftests/tdx: Test GetQuote TDX attestation feature
Date: Thu, 22 Jun 2023 23:44:54 +0000 [thread overview]
Message-ID: <b99d329e5a28a06dfb947270b8a9032cc6960f83.camel@intel.com> (raw)
In-Reply-To: <CAAYXXYzOUQC0G7yoh1i2+SW-FodCABwhD6TgArLf28iG=i65zw@mail.gmail.com>
On Thu, 2023-06-22 at 16:31 -0700, Erdem Aktas wrote:
> So while I like the suggested direction, I am not sure how much it is
> possible to come up with a common ABI even with just only for 2
> vendors (AMD and Intel) without doing spec changes which is a multi
> year effort imho.
I don't want to intervene the discussion around whether this direction is
correct or not, however I want to say request_key() may not be the right place
to fit Quote (or remote verifiable data blob in general for attestation).
> request_key(coco_quote, "description", "<uuencoded tdreport>")
Although both key and Quote are data blob in some way, Quote certainly is not a
key but have much more information. The man page of request_key() seems to
suggest it's just for key:
request_key - request a key from the kernel's key management
facility
So IMHO using request_key() to fit Quote may cause bigger confusion.
next prev parent reply other threads:[~2023-06-22 23:45 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-14 7:23 [PATCH v3 0/3] TDX Guest Quote generation support Kuppuswamy Sathyanarayanan
2023-05-14 7:23 ` [PATCH v3 1/3] x86/tdx: Add TDX Guest event notify interrupt support Kuppuswamy Sathyanarayanan
2023-06-12 12:49 ` Huang, Kai
2023-08-23 20:47 ` Thomas Gleixner
2023-05-14 7:23 ` [PATCH v3 2/3] virt: tdx-guest: Add Quote generation support Kuppuswamy Sathyanarayanan
2023-06-12 12:50 ` Huang, Kai
2023-05-14 7:23 ` [PATCH v3 3/3] selftests/tdx: Test GetQuote TDX attestation feature Kuppuswamy Sathyanarayanan
2023-06-12 19:03 ` Dan Williams
2023-06-19 5:38 ` Sathyanarayanan Kuppuswamy
2023-06-22 23:31 ` Erdem Aktas
2023-06-22 23:44 ` Huang, Kai [this message]
2023-06-23 22:31 ` Dan Williams
2023-06-23 22:27 ` Dan Williams
2023-06-26 3:05 ` Sathyanarayanan Kuppuswamy
2023-06-26 18:57 ` Dionna Amalie Glaze
2023-06-27 0:39 ` Sathyanarayanan Kuppuswamy
2023-06-28 15:41 ` Samuel Ortiz
2023-06-28 15:55 ` Sathyanarayanan Kuppuswamy
2023-06-28 0:11 ` Dan Williams
2023-06-28 1:36 ` Dionna Amalie Glaze
2023-06-28 2:16 ` Huang, Kai
2023-06-28 6:46 ` gregkh
2023-06-28 8:56 ` Huang, Kai
2023-06-28 9:02 ` gregkh
2023-06-28 9:45 ` Huang, Kai
2023-06-28 2:52 ` Dan Williams
2023-06-29 16:25 ` Dionna Amalie Glaze
2023-06-28 15:31 ` Samuel Ortiz
2023-06-28 15:24 ` Samuel Ortiz
2023-06-27 23:44 ` Dan Williams
2023-06-28 2:47 ` Huang, Kai
[not found] ` <CAAYXXYyK4g9k7a78CU9w6Sn9KTBdoNLOu9gcgrSHJfp+3-tO=w@mail.gmail.com>
2023-06-23 22:49 ` Dan Williams
2023-08-23 8:25 ` Thomas Gleixner
2023-05-24 21:33 ` [PATCH v3 0/3] TDX Guest Quote generation support Chong Cai
2023-05-25 22:55 ` Sathyanarayanan Kuppuswamy
2023-06-24 4:05 ` Dan Williams
2023-06-25 20:21 ` Dan Williams
2023-06-26 3:07 ` Sathyanarayanan Kuppuswamy
2023-06-26 4:31 ` Dan Williams
2023-06-27 7:50 ` Chong Cai
2023-08-23 7:33 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b99d329e5a28a06dfb947270b8a9032cc6960f83.camel@intel.com \
--to=kai.huang@intel.com \
--cc=atishp@rivosinc.com \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=chongc@google.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=dionnaglaze@google.com \
--cc=erdemaktas@google.com \
--cc=fan.du@intel.com \
--cc=guorui.yu@linux.alibaba.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=qinkun@apache.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wander@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).